You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/14 22:36:59 UTC
[GitHub] [kafka] jolshan opened a new pull request #10125: MINOR: Add note about topic IDs to upgrade doc
jolshan opened a new pull request #10125:
URL: https://github.com/apache/kafka/pull/10125
Added a note about how topic IDs will be added in version 2.8 and the implications of downgrading + reupgrading.
Also fixed small typo and made all notable changes part of a single list.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao merged pull request #10125: MINOR: Add note about topic IDs to upgrade doc
Posted by GitBox <gi...@apache.org>.
junrao merged pull request #10125:
URL: https://github.com/apache/kafka/pull/10125
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao commented on a change in pull request #10125: MINOR: Add note about topic IDs to upgrade doc
Posted by GitBox <gi...@apache.org>.
junrao commented on a change in pull request #10125:
URL: https://github.com/apache/kafka/pull/10125#discussion_r577781142
##########
File path: docs/upgrade.html
##########
@@ -23,13 +23,17 @@ <h5><a id="upgrade_280_notable" href="#upgrade_280_notable">Notable changes in 2
<ul>
<li>
The 2.8.0 release added a new method to the Authorizer Interface introduced in
- <a href="https://cwiki.apache.org/confluen ce/display/KAFKA/KIP-679%3A+Producer+will+enable+the+strongest+delivery+guarantee+by+default">KIP-679</a>.
+ <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-679%3A+Producer+will+enable+the+strongest+delivery+guarantee+by+default">KIP-679</a>.
The motivation is to unblock our future plan to enable the strongest message delivery guarantee by default.
Custom authorizer should consider providing a more efficient implementation that supports audit logging and any custom configs or access rules.
</li>
-</ul>
-
-<ul>
+ <li>
+ IBP 2.8 introduces topic IDs to topics as a part of
+ <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-516%3A+Topic+Identifiers">KIP-516</a>.
+ When using ZooKeeper, this information is stored in the TopicZNode. If the cluster is downgraded to a previous IBP or version,
+ future topics will not get topic IDs and it is not guaranteed that topics will retain their topic IDs in ZooKeeper.
+ This means that upon upgrading again, topics some or all topics will be assigned new IDs.
Review comment:
"topics some" : Do you mean "some topics"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on a change in pull request #10125: MINOR: Add note about topic IDs to upgrade doc
Posted by GitBox <gi...@apache.org>.
jolshan commented on a change in pull request #10125:
URL: https://github.com/apache/kafka/pull/10125#discussion_r577794185
##########
File path: docs/upgrade.html
##########
@@ -23,13 +23,17 @@ <h5><a id="upgrade_280_notable" href="#upgrade_280_notable">Notable changes in 2
<ul>
<li>
The 2.8.0 release added a new method to the Authorizer Interface introduced in
- <a href="https://cwiki.apache.org/confluen ce/display/KAFKA/KIP-679%3A+Producer+will+enable+the+strongest+delivery+guarantee+by+default">KIP-679</a>.
+ <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-679%3A+Producer+will+enable+the+strongest+delivery+guarantee+by+default">KIP-679</a>.
The motivation is to unblock our future plan to enable the strongest message delivery guarantee by default.
Custom authorizer should consider providing a more efficient implementation that supports audit logging and any custom configs or access rules.
</li>
-</ul>
-
-<ul>
+ <li>
+ IBP 2.8 introduces topic IDs to topics as a part of
+ <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-516%3A+Topic+Identifiers">KIP-516</a>.
+ When using ZooKeeper, this information is stored in the TopicZNode. If the cluster is downgraded to a previous IBP or version,
+ future topics will not get topic IDs and it is not guaranteed that topics will retain their topic IDs in ZooKeeper.
+ This means that upon upgrading again, topics some or all topics will be assigned new IDs.
Review comment:
Good catch. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao commented on pull request #10125: MINOR: Add note about topic IDs to upgrade doc
Posted by GitBox <gi...@apache.org>.
junrao commented on pull request #10125:
URL: https://github.com/apache/kafka/pull/10125#issuecomment-780733439
cherry-picked to trunk too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org