You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/28 12:07:24 UTC
[GitHub] [incubator-shardingsphere] strongduanmu opened a new pull request
#4987: Add start-index and stop-index assertion for
ConstraintDefinitionSegment
strongduanmu opened a new pull request #4987: Add start-index and stop-index assertion for ConstraintDefinitionSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4987
Fixes #4890 .
Changes proposed in this pull request:
- Add start-index and stop-index assertion for ConstraintDefinitionSegment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4987: Add
start-index and stop-index assertion for ConstraintDefinitionSegment
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4987: Add start-index and stop-index assertion for ConstraintDefinitionSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4987#issuecomment-605444344
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4987?src=pr&el=h1) Report
> Merging [#4987](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4987?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/3876ffaba720cee808b3514ae90097c03292793f&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4987?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4987 +/- ##
=========================================
Coverage 54.13% 54.13%
Complexity 444 444
=========================================
Files 1146 1146
Lines 20520 20520
Branches 3746 3746
=========================================
Hits 11109 11109
Misses 8707 8707
Partials 704 704
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4987?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4987?src=pr&el=footer). Last update [3876ffa...c802e06](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4987?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4987: Add
start-index and stop-index assertion for ConstraintDefinitionSegment
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4987: Add start-index and stop-index assertion for ConstraintDefinitionSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4987
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4987: Add
start-index and stop-index assertion for ConstraintDefinitionSegment
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4987: Add start-index and stop-index assertion for ConstraintDefinitionSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4987#issuecomment-605444872
## Pull Request Test Coverage Report for [Build 10677](https://coveralls.io/builds/29678681)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.005%**) to **57.627%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29678681/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/29678681) |
| :-- | --: |
| Change from base [Build 1202](https://coveralls.io/builds/29676912): | -0.005% |
| Covered Lines: | 11825 |
| Relevant Lines: | 20520 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services