You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/07 02:21:58 UTC

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #670: webclient: 304 and 305 are not really redirects

yamt opened a new pull request #670:
URL: https://github.com/apache/incubator-nuttx-apps/pull/670


   ## Summary
   webclient: 304 and 305 are not really redirects
   
   Eg. The docker API sometimes returns 304 even for requests without etags.
   https://docs.docker.com/engine/api/v1.40/#operation/ContainerStop
   
   ## Impact
   
   ## Testing
   tested against the docker api
   (not on nuttx, with my fork of webclient.c)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #670: webclient: 304 and 305 are not really redirects

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #670:
URL: https://github.com/apache/incubator-nuttx-apps/pull/670#issuecomment-814613543


   @yamt one nxstyle warning need to fix:
   /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/webclient/webclient.c:2:1: error: Path relative to repository


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #670: webclient: 304 and 305 are not really redirects

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #670:
URL: https://github.com/apache/incubator-nuttx-apps/pull/670#issuecomment-814613543


   @yamt one nxstyle warning need to fix:
   ```
   /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/webclient/webclient.c:2:1: error: Path relative to repository
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #670: webclient: 304 and 305 are not really redirects

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #670:
URL: https://github.com/apache/incubator-nuttx-apps/pull/670


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] yamt commented on pull request #670: webclient: 304 and 305 are not really redirects

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #670:
URL: https://github.com/apache/incubator-nuttx-apps/pull/670#issuecomment-814617699


   > @yamt one nxstyle warning need to fix:
   > 
   > ```
   > /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/webclient/webclient.c:2:1: error: Path relative to repository
   > ```
   
   oops. fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org