You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/10/30 01:26:19 UTC

[GitHub] [guacamole-client] mike-jumper commented on pull request #527: GUACAMOLE-903: Improved Chinese internationalization support

mike-jumper commented on pull request #527:
URL: https://github.com/apache/guacamole-client/pull/527#issuecomment-719114597


   Hi @XYUU, the commits for this PR still show two duplicate messages:
   
   ![Duplicate commits](https://user-images.githubusercontent.com/4632905/97648889-22792e80-1a13-11eb-8e5f-228fe84b6cc2.png)
   
   As @necouchman mentioned, can you please:
   
   > Either collapse all of your commits into a single commit, or update the commit messages such that they describe the actual changes being made in each of the commits instead of a generic message ...
   
   Thanks!
   
   Reviewing the translation changes themselves, things look fine to me. The only issue I see is with the existence of those two duplicate commits.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org