You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/08/01 17:42:11 UTC
Re: Review Request 61182: Sent a resource provider message when
providers subscribe.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61182/
-----------------------------------------------------------
(Updated Aug. 1, 2017, 7:42 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Used a single file for RP manager-related tests; used `MockResourceProvider`; rebased.
Bugs: MESOS-7837
https://issues.apache.org/jira/browse/MESOS-7837
Repository: mesos
Description
-------
In order to inform users of resource provider managers that the
managed resources have changed, we add a new 'ResourceProviderMessage'
type for communicating changes to the managed total resources.
We add code to trigger sending of that message when a resource
provider subscribes with the manager.
In the future this message could also be used to communicate changes
to an already subscribed resource provider's total resources.
Diffs (updated)
-----
src/resource_provider/manager.cpp 44e1576d4462295d404429d51682134306047462
src/resource_provider/message.hpp 916926bf278de9ed919384a82a452d3ced06bd04
src/tests/resource_provider_manager_tests.cpp 85906ea5e1bb3516ef264de22913ce0a3c9c58c5
Diff: https://reviews.apache.org/r/61182/diff/3/
Changes: https://reviews.apache.org/r/61182/diff/2-3/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 61182: Sent a resource provider message when
providers subscribe.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On Aug. 8, 2017, 3:53 p.m., Jan Schlicht wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 383 (patched)
> > <https://reviews.apache.org/r/61182/diff/3/?file=1786858#file1786858line383>
> >
> > Nit: Use `v1::ResourceProviderInfo` instead of `mesos::v1::ResourceProviderInfo` to be consistent with the use of the `v1` namespace in this test.
>
> Benjamin Bannier wrote:
> This does not work for my compiler and requires explicit disambiguation (e.g., `no type named 'ResourceProviderInfo' in namespace 'mesos::internal::tests::v1'; did you mean simply 'ResourceProviderInfo'?`). Note that for other `v1` types in this file we typically import the name directly into the current scope with a using decl.
You're right, I even ran into that in my patches.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61182/#review182387
-----------------------------------------------------------
On Sept. 6, 2017, 1:59 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61182/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2017, 1:59 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7837
> https://issues.apache.org/jira/browse/MESOS-7837
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to inform users of resource provider managers that the
> managed resources have changed, we add a new 'ResourceProviderMessage'
> type for communicating changes to the managed total resources.
>
> We add code to trigger sending of that message when a resource
> provider subscribes with the manager.
>
> In the future this message could also be used to communicate changes
> to an already subscribed resource provider's total resources.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp da9dff1e9bb18780ac5a5b25d2fd98e931da74af
> src/resource_provider/message.hpp 916926bf278de9ed919384a82a452d3ced06bd04
> src/tests/resource_provider_manager_tests.cpp 83a1340fa16b19e3297a8c0ca413afc312de00ec
>
>
> Diff: https://reviews.apache.org/r/61182/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 61182: Sent a resource provider message when
providers subscribe.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Aug. 8, 2017, 3:53 p.m., Jan Schlicht wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 383 (patched)
> > <https://reviews.apache.org/r/61182/diff/3/?file=1786858#file1786858line383>
> >
> > Nit: Use `v1::ResourceProviderInfo` instead of `mesos::v1::ResourceProviderInfo` to be consistent with the use of the `v1` namespace in this test.
This does not work for my compiler and requires explicit disambiguation (e.g., `no type named 'ResourceProviderInfo' in namespace 'mesos::internal::tests::v1'; did you mean simply 'ResourceProviderInfo'?`). Note that for other `v1` types in this file we typically import the name directly into the current scope with a using decl.
> On Aug. 8, 2017, 3:53 p.m., Jan Schlicht wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 394 (patched)
> > <https://reviews.apache.org/r/61182/diff/3/?file=1786858#file1786858line394>
> >
> > See nit above.
See above.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61182/#review182387
-----------------------------------------------------------
On Sept. 6, 2017, 1:59 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61182/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2017, 1:59 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7837
> https://issues.apache.org/jira/browse/MESOS-7837
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to inform users of resource provider managers that the
> managed resources have changed, we add a new 'ResourceProviderMessage'
> type for communicating changes to the managed total resources.
>
> We add code to trigger sending of that message when a resource
> provider subscribes with the manager.
>
> In the future this message could also be used to communicate changes
> to an already subscribed resource provider's total resources.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp da9dff1e9bb18780ac5a5b25d2fd98e931da74af
> src/resource_provider/message.hpp 916926bf278de9ed919384a82a452d3ced06bd04
> src/tests/resource_provider_manager_tests.cpp 83a1340fa16b19e3297a8c0ca413afc312de00ec
>
>
> Diff: https://reviews.apache.org/r/61182/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 61182: Sent a resource provider message when
providers subscribe.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61182/#review182387
-----------------------------------------------------------
Looks great, only nitpicking here. Please rebase, `resource_provider::Driver` has been changed to allow reconnections using an `EndpointDetector`.
src/tests/resource_provider_manager_tests.cpp
Lines 383 (patched)
<https://reviews.apache.org/r/61182/#comment258276>
Nit: Use `v1::ResourceProviderInfo` instead of `mesos::v1::ResourceProviderInfo` to be consistent with the use of the `v1` namespace in this test.
src/tests/resource_provider_manager_tests.cpp
Lines 394 (patched)
<https://reviews.apache.org/r/61182/#comment258277>
See nit above.
- Jan Schlicht
On Aug. 1, 2017, 7:42 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61182/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 7:42 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7837
> https://issues.apache.org/jira/browse/MESOS-7837
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to inform users of resource provider managers that the
> managed resources have changed, we add a new 'ResourceProviderMessage'
> type for communicating changes to the managed total resources.
>
> We add code to trigger sending of that message when a resource
> provider subscribes with the manager.
>
> In the future this message could also be used to communicate changes
> to an already subscribed resource provider's total resources.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 44e1576d4462295d404429d51682134306047462
> src/resource_provider/message.hpp 916926bf278de9ed919384a82a452d3ced06bd04
> src/tests/resource_provider_manager_tests.cpp 85906ea5e1bb3516ef264de22913ce0a3c9c58c5
>
>
> Diff: https://reviews.apache.org/r/61182/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 61182: Sent a resource provider message when
providers subscribe.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61182/#review184746
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 6, 2017, 11:59 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61182/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2017, 11:59 a.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7837
> https://issues.apache.org/jira/browse/MESOS-7837
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to inform users of resource provider managers that the
> managed resources have changed, we add a new 'ResourceProviderMessage'
> type for communicating changes to the managed total resources.
>
> We add code to trigger sending of that message when a resource
> provider subscribes with the manager.
>
> In the future this message could also be used to communicate changes
> to an already subscribed resource provider's total resources.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp da9dff1e9bb18780ac5a5b25d2fd98e931da74af
> src/resource_provider/message.hpp 916926bf278de9ed919384a82a452d3ced06bd04
> src/tests/resource_provider_manager_tests.cpp 83a1340fa16b19e3297a8c0ca413afc312de00ec
>
>
> Diff: https://reviews.apache.org/r/61182/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 61182: Sent a resource provider message when
providers subscribe.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61182/
-----------------------------------------------------------
(Updated Sept. 6, 2017, 1:59 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Extended existing test; rebased.
Bugs: MESOS-7837
https://issues.apache.org/jira/browse/MESOS-7837
Repository: mesos
Description
-------
In order to inform users of resource provider managers that the
managed resources have changed, we add a new 'ResourceProviderMessage'
type for communicating changes to the managed total resources.
We add code to trigger sending of that message when a resource
provider subscribes with the manager.
In the future this message could also be used to communicate changes
to an already subscribed resource provider's total resources.
Diffs (updated)
-----
src/resource_provider/manager.cpp da9dff1e9bb18780ac5a5b25d2fd98e931da74af
src/resource_provider/message.hpp 916926bf278de9ed919384a82a452d3ced06bd04
src/tests/resource_provider_manager_tests.cpp 83a1340fa16b19e3297a8c0ca413afc312de00ec
Diff: https://reviews.apache.org/r/61182/diff/4/
Changes: https://reviews.apache.org/r/61182/diff/3-4/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 61182: Sent a resource provider message when
providers subscribe.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61182/#review183197
-----------------------------------------------------------
Can you rebase?
- Jie Yu
On Aug. 1, 2017, 5:42 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61182/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 5:42 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7837
> https://issues.apache.org/jira/browse/MESOS-7837
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to inform users of resource provider managers that the
> managed resources have changed, we add a new 'ResourceProviderMessage'
> type for communicating changes to the managed total resources.
>
> We add code to trigger sending of that message when a resource
> provider subscribes with the manager.
>
> In the future this message could also be used to communicate changes
> to an already subscribed resource provider's total resources.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 44e1576d4462295d404429d51682134306047462
> src/resource_provider/message.hpp 916926bf278de9ed919384a82a452d3ced06bd04
> src/tests/resource_provider_manager_tests.cpp 85906ea5e1bb3516ef264de22913ce0a3c9c58c5
>
>
> Diff: https://reviews.apache.org/r/61182/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>