You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/01/14 18:43:47 UTC

[GitHub] [pinot] richardstartin commented on a change in pull request #7916: FILTER Clauses for Aggregates

richardstartin commented on a change in pull request #7916:
URL: https://github.com/apache/pinot/pull/7916#discussion_r785074311



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/ProjectionBlock.java
##########
@@ -52,7 +61,8 @@ public BlockValSet getBlockValueSet(String column) {
 
   @Override
   public BlockDocIdSet getBlockDocIdSet() {
-    throw new UnsupportedOperationException();
+    return _docIdSetBlock != null ? _docIdSetBlock.getBlockDocIdSet()

Review comment:
       I don’t think this null check improves the readability of the code. Whenever I see a null check, I think about when and how the reference can be null, so adding tautological checks adds cognitive burden.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org