You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/10 06:46:39 UTC

[GitHub] [airflow] ecodina commented on pull request #24943: Added exception catching to send default email if template file raises any exception

ecodina commented on PR #24943:
URL: https://github.com/apache/airflow/pull/24943#issuecomment-1179668301

   A test failed, but I'd like to argue my case:
   
   In this try - except we will mostly catch the FileNotFoundError, which is explicit.
   
   In any other case (e.g. an IO error), I believe we should still send the email with the default template to make sure we are always notified.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org