You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomee.apache.org by David Salter <we...@gmail.com> on 2019/09/05 11:21:42 UTC

Merge PRs ?

Hi,

I’ve got a couple of PRs that have been outstanding for a few weeks.

Can anybody merge these for me, or let me know if they need changes?

https://github.com/apache/tomee/pull/530 <https://github.com/apache/tomee/pull/530>
https://github.com/apache/tomee/pull/531 <https://github.com/apache/tomee/pull/531>

Thanks.

David.

Re: Merge PRs ?

Posted by Jonathan Gallimore <jo...@gmail.com>.

You're welcome. Thanks for the PRs - I think I had seen one of them already
(I thought I has already merged it!). Sorry for the delay!

Jon

On Thu, Sep 5, 2019 at 12:24 PM David Salter <we...@gmail.com>
wrote:

> Wow.  That was quick.  Thanks Jon :)
>
> > On 5 Sep 2019, at 12:23, Jonathan Gallimore <
> jonathan.gallimore@gmail.com> wrote:
> >
> > Hi David
> >
> > Thanks for the nudge! I've merged those. Thanks for the PRs!
> >
> > Jon
> >
> > On Thu, Sep 5, 2019 at 12:21 PM David Salter <we...@gmail.com>
> > wrote:
> >
> >> Hi,
> >>
> >> I’ve got a couple of PRs that have been outstanding for a few weeks.
> >>
> >> Can anybody merge these for me, or let me know if they need changes?
> >>
> >> https://github.com/apache/tomee/pull/530 <
> >> https://github.com/apache/tomee/pull/530>
> >> https://github.com/apache/tomee/pull/531 <
> >> https://github.com/apache/tomee/pull/531>
> >>
> >> Thanks.
> >>
> >> David.
>
>

Re: Merge PRs ?

Posted by David Salter <we...@gmail.com>.

Wow.  That was quick.  Thanks Jon :)

> On 5 Sep 2019, at 12:23, Jonathan Gallimore <jo...@gmail.com> wrote:
> 
> Hi David
> 
> Thanks for the nudge! I've merged those. Thanks for the PRs!
> 
> Jon
> 
> On Thu, Sep 5, 2019 at 12:21 PM David Salter <we...@gmail.com>
> wrote:
> 
>> Hi,
>> 
>> I’ve got a couple of PRs that have been outstanding for a few weeks.
>> 
>> Can anybody merge these for me, or let me know if they need changes?
>> 
>> https://github.com/apache/tomee/pull/530 <
>> https://github.com/apache/tomee/pull/530>
>> https://github.com/apache/tomee/pull/531 <
>> https://github.com/apache/tomee/pull/531>
>> 
>> Thanks.
>> 
>> David.

Re: Merge PRs ?

Posted by Jonathan Gallimore <jo...@gmail.com>.

Hi David

Thanks for the nudge! I've merged those. Thanks for the PRs!

Jon

On Thu, Sep 5, 2019 at 12:21 PM David Salter <we...@gmail.com>
wrote:

> Hi,
>
> I’ve got a couple of PRs that have been outstanding for a few weeks.
>
> Can anybody merge these for me, or let me know if they need changes?
>
> https://github.com/apache/tomee/pull/530 <
> https://github.com/apache/tomee/pull/530>
> https://github.com/apache/tomee/pull/531 <
> https://github.com/apache/tomee/pull/531>
>
> Thanks.
>
> David.