You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/11 09:26:54 UTC

[GitHub] [arrow] jorisvandenbossche commented on pull request #8984: ARROW-5336: [C++] Implement arrow::Concatenate for dictionary-encoded arrays with unequal dictionaries

jorisvandenbossche commented on pull request #8984:
URL: https://github.com/apache/arrow/pull/8984#issuecomment-757789871


   A bit late that I think of it, but the arrow->pandas code already has some dictionary concatenation code (https://github.com/apache/arrow/blob/97f8160e56036909cdf554860baa341c46d3caf3/cpp/src/arrow/python/arrow_to_pandas.cc#L1641-L1676). I am not that familiar with the code, but there might be room for simplification there with the functionality added in this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org