[PR] Move SLF4J artifacts to boot classloader [maven]

["kwin (via GitHub)" <gi...@apache.org>]

kwin opened a new pull request, #11691:
URL: https://github.com/apache/maven/pull/11691

   This makes it possible to use the SLF4J System.LoggerFinder This is looked up with ClassLoader.getSystemClassLoader(). This also requires the SLF4J API to be provided in that classloader.
   
   This closes #11684
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
   - [ ] Your pull request should address just one issue, without pulling in other changes.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
     Note that commits might be squashed by a maintainer on merge.
   - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
     This may not always be possible but is a best-practice.
   - [ ] Run `mvn verify` to make sure basic checks pass.
     A more thorough check will be performed on your pull request automatically.
   - [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move SLF4J artifacts to boot classloader [maven]

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas commented on PR #11691:
URL: https://github.com/apache/maven/pull/11691#issuecomment-3884800374

   This is not so simple.
   
   See here:
   https://github.com/apache/maven/blob/5bcfc50834638b7798cc699c7d460e564b0eedb8/apache-maven/src/bin/mvn#L211
   and then here:
   https://github.com/apache/maven/blob/5bcfc50834638b7798cc699c7d460e564b0eedb8/apache-maven/src/bin/m2.conf
   
   We use classworlds launcher (that is refd in mvn script, and loads m2.conf):
   https://codehaus-plexus.github.io/plexus-classworlds/launcher.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org