You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2014/12/24 21:41:35 UTC
Review Request 29406: Introduce libevent ssl socket.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos-git
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
Diffs
-----
3rdparty/libprocess/Makefile.am 75870ac754e500bb4ca689201bde677fa7d854d0
3rdparty/libprocess/include/process/socket.hpp 7e1e3f22583f44a9aea8259bafedc2877ad2e633
3rdparty/libprocess/src/libevent.hpp PRE-CREATION
3rdparty/libprocess/src/libevent.cpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 028b33e7ecb7e0a39334ac4ab0279ee327a72a56
3rdparty/libprocess/src/socket.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: WIP: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Dec. 29, 2014, 11:01 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/src/libevent_ssl_socket.cpp, lines 24-26
> > <https://reviews.apache.org/r/29406/diff/1/?file=800352#file800352line24>
> >
> > Let's give these defaults, and some comments explaining their purpose please!
I'm leaving this and some of the other openssl comments until we rebase on BenH's introduction of these as a separate commit.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review66306
-----------------------------------------------------------
On Jan. 7, 2015, 12:16 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 12:16 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> USE_SSL=(0,1)
> SSL_CERT=(path to certificate)
> SSL_KEY=(path to key)
> SSL_VERIFY_CERT=(0,1)
> SSL_REQUIRE_CERT=(0,1)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 75870ac754e500bb4ca689201bde677fa7d854d0
> 3rdparty/libprocess/include/process/socket.hpp 7e1e3f22583f44a9aea8259bafedc2877ad2e633
> 3rdparty/libprocess/src/libevent.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent.cpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 028b33e7ecb7e0a39334ac4ab0279ee327a72a56
> 3rdparty/libprocess/src/socket.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review66306
-----------------------------------------------------------
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/29406/#comment109708>
The practice in the code base is s/void (void/void(void/, please update here and below, thanks!
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/29406/#comment109705>
Please use ThreadLocal until we can just use __thread please.
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/29406/#comment109706>
It appears as though you're creating a timer event in order to do the async loop interrupt. This does match the libev model fairly well, but is there a better way to do it in libevent? In particular, can you just inject an event in a thread-safe way directly in run_in_event_loop by calling event_active? As in, do you have to make an event pending first with event_add?
Either way, a little more documentation here would go a long way. libev has a mechanism to interrupt the event loop ("async" watchers) so it's slightly more self-documenting.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109724>
Why is this capitalized? It doesn't look like a constant.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109709>
Let's give these defaults, and some comments explaining their purpose please!
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109710>
Let's get some comments explaining what each of these structs, functions, and variables are used for please!
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109711>
s/char */char* /
Here and everywhere else please!
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109712>
s/long)pthread/long) pthread/
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109715>
One parameter per line please. Here and everywhere else!
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109716>
How about we format this as:
struct CRYPTO_dynlock_value* value = (struct CRYPTO_dynlock_value*)
malloc(sizeof(struct CRYPTO_dynlock_value));
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109714>
value == NULL
Here and everywhere else please!
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109717>
s/l/value/ to be consistent with the naming above? Here and everywhere else please!
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109718>
Even though I commented on this above, just a friendly reminder to do 'bev != NULL' here and everywhere else please!
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109720>
s/ctx/ssl/ to be consistent with the rest of the code in this review.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109719>
This is safe to do outside of the event loop? What if the event loop thread is currently executing the 'recvCb' call? It looks like maybe 'recvCb' and friends needs to take either a Socket or better the shared_ptr<LibeventSSLSocketImpl> so that we don't prematurely call delete. And then a comment explaining why it's therefore safe to call these functions in the destructor would be great!
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109721>
Maybe another helpful comment here that calling free automatically closes the socket which is why we don't need to do anything special here?
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109722>
Let's fully spell out the word 'Callback' here and everywhere else to stay consistent with our codebase please.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109702>
Let's just use CHECK everywhere, rather than both assert and CHECK. And for a case like this, please use CHECK_NOTNULL. And note that CHECK_NOTNULL returns the pointer, so feel free to use it to wrapper, for example:
T* t = CHECK_NOTNULL(...pointer...);
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109700>
Can we create scopes for these lock blocks? How about:
bufferevent_lock(bev);
{
...;
}
bufferevent_unlock(bev);
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109725>
Unused?
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment109726>
We really need to document the fact that we're passing in a file descriptor here but we're overriding it when we do a connect. It's not obvious that we are doing this or why we need to do this and it could be very confusing to someone coming across the code later. Probably a good place for this comment would be both here and in LibeventSSLSocketImpl::connect where you pass in -1 to bufferevent_openssl_socket_new.
Also, it looks like we might be pretty close to being able kill the version of Socket::create that takes the file descriptor anyway, and I think we want to strive for that long term?
- Benjamin Hindman
On Dec. 24, 2014, 8:41 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2014, 8:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> USE_SSL=(0,1)
> SSL_CERT=(path to certificate)
> SSL_KEY=(path to key)
> SSL_VERIFY_CERT=(0,1)
> SSL_REQUIRE_CERT=(0,1)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 75870ac754e500bb4ca689201bde677fa7d854d0
> 3rdparty/libprocess/include/process/socket.hpp 7e1e3f22583f44a9aea8259bafedc2877ad2e633
> 3rdparty/libprocess/src/libevent.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent.cpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 028b33e7ecb7e0a39334ac4ab0279ee327a72a56
> 3rdparty/libprocess/src/socket.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review66055
-----------------------------------------------------------
Bad patch!
Reviews applied: [28314, 28315]
Failed command: ./support/apply-review.sh -n -r 28315
Error:
2014-12-24 20:53:31 URL:https://reviews.apache.org/r/28315/diff/raw/ [20372/20372] -> "28315.patch" [1]
error: patch failed: 3rdparty/libprocess/src/clock.cpp:69
error: 3rdparty/libprocess/src/clock.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Dec. 24, 2014, 8:41 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2014, 8:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> USE_SSL=(0,1)
> SSL_CERT=(path to certificate)
> SSL_KEY=(path to key)
> SSL_VERIFY_CERT=(0,1)
> SSL_REQUIRE_CERT=(0,1)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 75870ac754e500bb4ca689201bde677fa7d854d0
> 3rdparty/libprocess/include/process/socket.hpp 7e1e3f22583f44a9aea8259bafedc2877ad2e633
> 3rdparty/libprocess/src/libevent.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent.cpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 028b33e7ecb7e0a39334ac4ab0279ee327a72a56
> 3rdparty/libprocess/src/socket.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: WIP: Introduce libevent ssl socket.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review66956
-----------------------------------------------------------
Bad patch!
Reviews applied: [28314, 28315, 29225, 28319, 28320, 28321, 29226, 28322, 28323, 28467, 28670, 28671, 28672, 28673]
Failed command: ./support/apply-review.sh -n -r 28673
Error:
2015-01-07 00:23:35 URL:https://reviews.apache.org/r/28673/diff/raw/ [11923/11923] -> "28673.patch" [1]
error: patch failed: 3rdparty/libprocess/src/socket.cpp:5
error: 3rdparty/libprocess/src/socket.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Jan. 7, 2015, 12:16 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 12:16 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> USE_SSL=(0,1)
> SSL_CERT=(path to certificate)
> SSL_KEY=(path to key)
> SSL_VERIFY_CERT=(0,1)
> SSL_REQUIRE_CERT=(0,1)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 75870ac754e500bb4ca689201bde677fa7d854d0
> 3rdparty/libprocess/include/process/socket.hpp 7e1e3f22583f44a9aea8259bafedc2877ad2e633
> 3rdparty/libprocess/src/libevent.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent.cpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 028b33e7ecb7e0a39334ac4ab0279ee327a72a56
> 3rdparty/libprocess/src/socket.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: WIP: Introduce libevent ssl socket.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review70513
-----------------------------------------------------------
Bad patch!
Reviews applied: [29526, 29527]
Failed command: ./support/apply-review.sh -n -r 29527
Error:
2015-01-31 23:44:00 URL:https://reviews.apache.org/r/29527/diff/raw/ [8219/8219] -> "29527.patch" [1]
error: patch failed: 3rdparty/libprocess/src/tests/process_tests.cpp:21
error: 3rdparty/libprocess/src/tests/process_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Jan. 31, 2015, 11:28 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 11:28 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> USE_SSL=(0,1)
> SSL_CERT=(path to certificate)
> SSL_KEY=(path to key)
> SSL_VERIFY_CERT=(0,1)
> SSL_REQUIRE_CERT=(0,1)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
> 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review76119
-----------------------------------------------------------
3rdparty/libprocess/src/openssl.cpp
<https://reviews.apache.org/r/29406/#comment123548>
Use the verify flag correctly. Currently it is being ignored and we always verify the cert if provided.
- Joris Van Remoortere
On Feb. 20, 2015, 7:24 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2015, 7:24 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> USE_SSL=(0,1)
> SSL_CERT=(path to certificate)
> SSL_KEY=(path to key)
> SSL_VERIFY_CERT=(0,1)
> SSL_REQUIRE_CERT=(0,1)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
> 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Ben Mahler <be...@gmail.com>.
> On June 12, 2015, 6:17 p.m., Ben Mahler wrote:
> > Are the changes to process.cpp, libevent.{hpp|cpp} independent? Hard to tell if these are related to SSL, can you pull them out into separate reviews?
>
> Benjamin Hindman wrote:
> Ben: I've been reviewing this closely with Joris and asked him to keep these in the same review to make it easier for me to review!
I'm surprised that makes it easier, as a bystander I can't easily tell what motivates the libevent.{hpp|cpp} and process.cpp changes (e.g. are they good to have even without SSL?). If they are independent I'd imagine you'd want to reduce the cognitive overhead of having them within this large patch?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review87735
-----------------------------------------------------------
On June 12, 2015, 6:06 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 6:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> ```
> SSL_ENABLED=(false|0,true|1)
> SSL_CERT_FILE=(path to certificate)
> SSL_KEY_FILE=(path to key)
> SSL_VERIFY_CERT=(false|0,true|1)
> SSL_REQUIRE_CERT=(false|0,true|1)
> SSL_VERIFY_DEPTH=(4)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
> SSL_CIPHERS=(accepted ciphers separated by ':')
> SSL_ENABLE_SSL_V2=(false|0,true|1)
> SSL_ENABLE_SSL_V3=(false|0,true|1)
> SSL_ENABLE_TLS_V1_0=(false|0,true|1)
> SSL_ENABLE_TLS_V1_1=(false|0,true|1)
> SSL_ENABLE_TLS_V1_2=(false|0,true|1)
> ```
>
> Only TLSV1.2 is enabled by default.
> Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
> Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
> 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On June 12, 2015, 6:17 p.m., Ben Mahler wrote:
> > Are the changes to process.cpp, libevent.{hpp|cpp} independent? Hard to tell if these are related to SSL, can you pull them out into separate reviews?
Ben: I've been reviewing this closely with Joris and asked him to keep these in the same review to make it easier for me to review!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review87735
-----------------------------------------------------------
On June 12, 2015, 6:06 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 6:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> ```
> SSL_ENABLED=(false|0,true|1)
> SSL_CERT_FILE=(path to certificate)
> SSL_KEY_FILE=(path to key)
> SSL_VERIFY_CERT=(false|0,true|1)
> SSL_REQUIRE_CERT=(false|0,true|1)
> SSL_VERIFY_DEPTH=(4)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
> SSL_CIPHERS=(accepted ciphers separated by ':')
> SSL_ENABLE_SSL_V2=(false|0,true|1)
> SSL_ENABLE_SSL_V3=(false|0,true|1)
> SSL_ENABLE_TLS_V1_0=(false|0,true|1)
> SSL_ENABLE_TLS_V1_1=(false|0,true|1)
> SSL_ENABLE_TLS_V1_2=(false|0,true|1)
> ```
>
> Only TLSV1.2 is enabled by default.
> Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
> Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
> 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review87735
-----------------------------------------------------------
Are the changes to process.cpp, libevent.{hpp|cpp} independent? Hard to tell if these are related to SSL, can you pull them out into separate reviews?
- Ben Mahler
On June 12, 2015, 6:06 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 6:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> ```
> SSL_ENABLED=(false|0,true|1)
> SSL_CERT_FILE=(path to certificate)
> SSL_KEY_FILE=(path to key)
> SSL_VERIFY_CERT=(false|0,true|1)
> SSL_REQUIRE_CERT=(false|0,true|1)
> SSL_VERIFY_DEPTH=(4)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
> SSL_CIPHERS=(accepted ciphers separated by ':')
> SSL_ENABLE_SSL_V2=(false|0,true|1)
> SSL_ENABLE_SSL_V3=(false|0,true|1)
> SSL_ENABLE_TLS_V1_0=(false|0,true|1)
> SSL_ENABLE_TLS_V1_1=(false|0,true|1)
> SSL_ENABLE_TLS_V1_2=(false|0,true|1)
> ```
>
> Only TLSV1.2 is enabled by default.
> Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
> Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
> 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review87687
-----------------------------------------------------------
3rdparty/libprocess/src/libevent_ssl_socket.hpp
<https://reviews.apache.org/r/29406/#comment140109>
s/the the/ the
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140111>
s/scneario/scenario
- Joerg Schad
On June 12, 2015, 6:06 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 6:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> ```
> SSL_ENABLED=(false|0,true|1)
> SSL_CERT_FILE=(path to certificate)
> SSL_KEY_FILE=(path to key)
> SSL_VERIFY_CERT=(false|0,true|1)
> SSL_REQUIRE_CERT=(false|0,true|1)
> SSL_VERIFY_DEPTH=(4)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
> SSL_CIPHERS=(accepted ciphers separated by ':')
> SSL_ENABLE_SSL_V2=(false|0,true|1)
> SSL_ENABLE_SSL_V3=(false|0,true|1)
> SSL_ENABLE_TLS_V1_0=(false|0,true|1)
> SSL_ENABLE_TLS_V1_1=(false|0,true|1)
> SSL_ENABLE_TLS_V1_2=(false|0,true|1)
> ```
>
> Only TLSV1.2 is enabled by default.
> Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
> Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
> 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review87858
-----------------------------------------------------------
Ship it!
This looks good Joris! Thans for all the hard work, iterations, simplifications, cleanup, etc.
**To the broader dev community:** *I'm going to be committing this code but Joris still has other work to be done in order to use this in production! Look for an email from Joris to the dev@mesos.apache.org list addressing these things.*
- Benjamin Hindman
On June 13, 2015, 9:23 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated June 13, 2015, 9:23 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> ```
> SSL_ENABLED=(false|0,true|1)
> SSL_CERT_FILE=(path to certificate)
> SSL_KEY_FILE=(path to key)
> SSL_VERIFY_CERT=(false|0,true|1)
> SSL_REQUIRE_CERT=(false|0,true|1)
> SSL_VERIFY_DEPTH=(4)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
> SSL_CIPHERS=(accepted ciphers separated by ':')
> SSL_ENABLE_SSL_V2=(false|0,true|1)
> SSL_ENABLE_SSL_V3=(false|0,true|1)
> SSL_ENABLE_TLS_V1_0=(false|0,true|1)
> SSL_ENABLE_TLS_V1_1=(false|0,true|1)
> SSL_ENABLE_TLS_V1_2=(false|0,true|1)
> ```
>
> Only TLSV1.2 is enabled by default.
> Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
> Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
> 3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158
> 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review87834
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On June 13, 2015, 9:23 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated June 13, 2015, 9:23 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> ```
> SSL_ENABLED=(false|0,true|1)
> SSL_CERT_FILE=(path to certificate)
> SSL_KEY_FILE=(path to key)
> SSL_VERIFY_CERT=(false|0,true|1)
> SSL_REQUIRE_CERT=(false|0,true|1)
> SSL_VERIFY_DEPTH=(4)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
> SSL_CIPHERS=(accepted ciphers separated by ':')
> SSL_ENABLE_SSL_V2=(false|0,true|1)
> SSL_ENABLE_SSL_V3=(false|0,true|1)
> SSL_ENABLE_TLS_V1_0=(false|0,true|1)
> SSL_ENABLE_TLS_V1_1=(false|0,true|1)
> SSL_ENABLE_TLS_V1_2=(false|0,true|1)
> ```
>
> Only TLSV1.2 is enabled by default.
> Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
> Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
> 3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158
> 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review87885
-----------------------------------------------------------
3rdparty/libprocess/include/process/address.hpp
<https://reviews.apache.org/r/29406/#comment140298>
General question about the net namespace in the code: why is the network structure not templatized on the Layer 3(IP) family(inet/inet6 etc)? This would make it easy to specialize on these families and also make Ipv6 easy.
- Jojy Varghese
On June 13, 2015, 9:23 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated June 13, 2015, 9:23 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> ```
> SSL_ENABLED=(false|0,true|1)
> SSL_CERT_FILE=(path to certificate)
> SSL_KEY_FILE=(path to key)
> SSL_VERIFY_CERT=(false|0,true|1)
> SSL_REQUIRE_CERT=(false|0,true|1)
> SSL_VERIFY_DEPTH=(4)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
> SSL_CIPHERS=(accepted ciphers separated by ':')
> SSL_ENABLE_SSL_V2=(false|0,true|1)
> SSL_ENABLE_SSL_V3=(false|0,true|1)
> SSL_ENABLE_TLS_V1_0=(false|0,true|1)
> SSL_ENABLE_TLS_V1_1=(false|0,true|1)
> SSL_ENABLE_TLS_V1_2=(false|0,true|1)
> ```
>
> Only TLSV1.2 is enabled by default.
> Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
> Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
> 3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158
> 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Michael Park <mc...@gmail.com>.
> On June 15, 2015, 5:28 p.m., Jojy Varghese wrote:
> > 3rdparty/libprocess/include/process/address.hpp, line 84
> > <https://reviews.apache.org/r/29406/diff/29/?file=984330#file984330line84>
> >
> > There are a few "if family == INET" (or similar) in the code. By specializing the net address structures on FAMILY, we will get rid of them. As most of the network structures (socket for example) are classified based on family, this should naturally fit into the overall scheme.
I think we'll probably want a version-agnostic one as well as specialized ones if we care about supporting the differences IPv4 and IPv6. `Boost.Asio` and the proposed networking library for the C++ standard based on it provide `address`, `address_v4` and `address_v6` for example. We could provide the same alternatives via template specializations, but my point is that we'll probably want to keep the version-agnostic one for cases where we can't know or don't care which version we have.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review87936
-----------------------------------------------------------
On June 13, 2015, 9:23 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated June 13, 2015, 9:23 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> ```
> SSL_ENABLED=(false|0,true|1)
> SSL_CERT_FILE=(path to certificate)
> SSL_KEY_FILE=(path to key)
> SSL_VERIFY_CERT=(false|0,true|1)
> SSL_REQUIRE_CERT=(false|0,true|1)
> SSL_VERIFY_DEPTH=(4)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
> SSL_CIPHERS=(accepted ciphers separated by ':')
> SSL_ENABLE_SSL_V2=(false|0,true|1)
> SSL_ENABLE_SSL_V3=(false|0,true|1)
> SSL_ENABLE_TLS_V1_0=(false|0,true|1)
> SSL_ENABLE_TLS_V1_1=(false|0,true|1)
> SSL_ENABLE_TLS_V1_2=(false|0,true|1)
> ```
>
> Only TLSV1.2 is enabled by default.
> Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
> Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
> 3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158
> 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review87936
-----------------------------------------------------------
3rdparty/libprocess/include/process/address.hpp
<https://reviews.apache.org/r/29406/#comment140363>
There are a few "if family == INET" (or similar) in the code. By specializing the net address structures on FAMILY, we will get rid of them. As most of the network structures (socket for example) are classified based on family, this should naturally fit into the overall scheme.
- Jojy Varghese
On June 13, 2015, 9:23 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated June 13, 2015, 9:23 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> ```
> SSL_ENABLED=(false|0,true|1)
> SSL_CERT_FILE=(path to certificate)
> SSL_KEY_FILE=(path to key)
> SSL_VERIFY_CERT=(false|0,true|1)
> SSL_REQUIRE_CERT=(false|0,true|1)
> SSL_VERIFY_DEPTH=(4)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
> SSL_CIPHERS=(accepted ciphers separated by ':')
> SSL_ENABLE_SSL_V2=(false|0,true|1)
> SSL_ENABLE_SSL_V3=(false|0,true|1)
> SSL_ENABLE_TLS_V1_0=(false|0,true|1)
> SSL_ENABLE_TLS_V1_1=(false|0,true|1)
> SSL_ENABLE_TLS_V1_2=(false|0,true|1)
> ```
>
> Only TLSV1.2 is enabled by default.
> Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
> Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
> 3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158
> 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 13, 2015, 9:23 a.m.)
Review request for mesos, Benjamin Hindman and Michael Park.
Changes
-------
address mpark's comments.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_ENABLED=(false|0,true|1)
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 13, 2015, 8:47 a.m.)
Review request for mesos, Benjamin Hindman and Michael Park.
Changes
-------
fix gcc compilation error.
fix configure error.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_ENABLED=(false|0,true|1)
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 13, 2015, 8:27 a.m.)
Review request for mesos, Benjamin Hindman and Michael Park.
Changes
-------
modify LIB line during configure as opposed to makefile
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_ENABLED=(false|0,true|1)
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review87783
-----------------------------------------------------------
Reviewed `libevent_ssl_socket.{hpp,cpp}`.
I don't have much confidence at all around whether we free memory properly. The calls to `SSL_free`, `delete request`, `bufferevent_free(bev); bev = NULL;` occur in many places :( Otherwise things look good to me.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140225>
Now that we don't capture `this` and use `self`, the `NOTE` is inaccurate.
> Note: The 'self' needs to be explicitly captured because we're not using it in the body of the lambda.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140207>
`bev` is unused and also shadows the member variable. Omit?
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140208>
`bev` is unused and also shadows the member variable. Omit?
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140209>
`bev` is unused and also shadows the member variable. Omit?
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140210>
```cpp
current_connect_request->promise.fail(
"Failed connect: connection closed");
```
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140229>
Remove newline.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140217>
This fits in one line.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140218>
No need for `else`.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140216>
Maybe `s/weak_socket/weak_self/`?
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140214>
Add space after `//`: `// executed.`
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140215>
`s/un-necessarily/unnecessarily/`
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140220>
Now that we don't capture `this` and use `self`, the `NOTE` is inaccurate.
> Note: The 'self' needs to be explicitly captured because we're not using it in the body of the lambda.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140212>
No need for `else`.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140219>
Now that we don't capture `this` and use `self`, the `NOTE` is inaccurate.
> Note: The 'self' needs to be explicitly captured because we're not using it in the body of the lambda.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140213>
The `size` is captured here but not used?
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140221>
No need for `else`.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140222>
Now that we don't capture `this` and use `self`, the `NOTE` is inaccurate.
> Note: The 'self' needs to be explicitly captured because we're not using it in the body of the lambda.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140223>
No need for `else`.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140224>
Now that we don't capture `this` and use `self`, the `NOTE` is inaccurate.
> Note: The 'self' needs to be explicitly captured because we're not using it in the body of the lambda.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140230>
Remove newline.
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140226>
Can we move this below the `bufferevent_setcb` call? That way we construct it as late as possible, and we can also do: `Socket socket = Socket::Impl::socket(std::move(impl));`
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140227>
`char error_buffer[1024] = {};`
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment140228>
`ERR_error_string_n(openssl_error, error_buffer, sizeof(error_buffer));`
Also, I don't think we need `sizeof(error_buffer) - 1`.
> ERR_error_string_n() is a variant of ERR_error_string() that writes at most `len` characters (__including the terminating 0__) and truncates the string if necessary. For ERR_error_string_n(), buf may not be NULL.
3rdparty/libprocess/src/openssl.cpp
<https://reviews.apache.org/r/29406/#comment140231>
Remove newline.
- Michael Park
On June 13, 2015, 8:02 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated June 13, 2015, 8:02 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> ```
> SSL_ENABLED=(false|0,true|1)
> SSL_CERT_FILE=(path to certificate)
> SSL_KEY_FILE=(path to key)
> SSL_VERIFY_CERT=(false|0,true|1)
> SSL_REQUIRE_CERT=(false|0,true|1)
> SSL_VERIFY_DEPTH=(4)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
> SSL_CIPHERS=(accepted ciphers separated by ':')
> SSL_ENABLE_SSL_V2=(false|0,true|1)
> SSL_ENABLE_SSL_V3=(false|0,true|1)
> SSL_ENABLE_TLS_V1_0=(false|0,true|1)
> SSL_ENABLE_TLS_V1_1=(false|0,true|1)
> SSL_ENABLE_TLS_V1_2=(false|0,true|1)
> ```
>
> Only TLSV1.2 is enabled by default.
> Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
> Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
> 3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158
> 3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
> 3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 13, 2015, 8:02 a.m.)
Review request for mesos, Benjamin Hindman and Michael Park.
Changes
-------
Use `address.hostname()` instead.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_ENABLED=(false|0,true|1)
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/address.hpp 729f5cd7ea981e43a33c1fe9d99d58b906a31158
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 13, 2015, 7:13 a.m.)
Review request for mesos, Benjamin Hindman and Michael Park.
Changes
-------
Clean up some error cases.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_ENABLED=(false|0,true|1)
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 12, 2015, 6:06 p.m.)
Review request for mesos, Benjamin Hindman and Michael Park.
Changes
-------
more updates from peer review.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_ENABLED=(false|0,true|1)
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 12, 2015, 4:19 p.m.)
Review request for Benjamin Hindman and Michael Park.
Changes
-------
update based on peer review comments.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_ENABLED=(false|0,true|1)
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 11, 2015, 10:36 p.m.)
Review request for Benjamin Hindman and Michael Park.
Changes
-------
handle mpark's issues.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_ENABLED=(false|0,true|1)
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 11, 2015, 9:29 p.m.)
Review request for Benjamin Hindman and Michael Park.
Changes
-------
fixed initialization bug.
Exit early from initialization if ssl is not enabled.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_ENABLED=(false|0,true|1)
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 11, 2015, 4:57 p.m.)
Review request for Benjamin Hindman and Michael Park.
Changes
-------
Use synchronized(bev).
Change to snake_case.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description (updated)
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_ENABLED=(false|0,true|1)
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 11, 2015, 3:20 p.m.)
Review request for Benjamin Hindman and Michael Park.
Changes
-------
Fix wrapping. Rebased commits don't seem to run the commit hooks...
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 11, 2015, 2:57 p.m.)
Review request for Benjamin Hindman and Michael Park.
Changes
-------
Unwind accidental inclusion of upgrade path.
Turn more static functions into lambdas.
Clean up some style issues.
Use EXIT(EXIT_FAILURE) for some user based error messages.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 11, 2015, 10:30 a.m.)
Review request for Benjamin Hindman and Michael Park.
Changes
-------
Address some of ben's issues:
- Use an enum to specify short-circuit behavior in `run_in_event_loop`
- Add a comment as to why we're blocking SIGPIPE
- clean up the flags object.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 11, 2015, 9:27 a.m.)
Review request for Benjamin Hindman and Michael Park.
Changes
-------
Switch to lambdas.
Address some of Ben's issues.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 9, 2015, 3:09 p.m.)
Review request for Benjamin Hindman and Michael Park.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 9, 2015, 2:40 p.m.)
Review request for Benjamin Hindman and Michael Park.
Changes
-------
Fix null initialization.
Fix conf variable accesibility for OSX.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 9, 2015, 1:29 p.m.)
Review request for Benjamin Hindman and Michael Park.
Changes
-------
move ssl flags into header for external access.
Use `SSL_ENABLED=(false|0,true|1)` instead of USE_SSL
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp d1b4d469a11abc618c1406bce602300dd9793b58
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 9, 2015, 9:22 a.m.)
Review request for Benjamin Hindman and Michael Park.
Changes
-------
Remove accidental inclusion of upgrade path.
Add environment variables to control supported protocol version. Default is only TLS V1.2.
Make verification depth an environment variable.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description (updated)
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
```
SSL_CERT_FILE=(path to certificate)
SSL_KEY_FILE=(path to key)
SSL_VERIFY_CERT=(false|0,true|1)
SSL_REQUIRE_CERT=(false|0,true|1)
SSL_VERIFY_DEPTH=(4)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
SSL_CIPHERS=(accepted ciphers separated by ':')
SSL_ENABLE_SSL_V2=(false|0,true|1)
SSL_ENABLE_SSL_V3=(false|0,true|1)
SSL_ENABLE_TLS_V1_0=(false|0,true|1)
SSL_ENABLE_TLS_V1_1=(false|0,true|1)
SSL_ENABLE_TLS_V1_2=(false|0,true|1)
```
Only TLSV1.2 is enabled by default.
Use the `ENABLE_SSL_V*` and `ENABLE_TLS_V*` environment variables to open up more protocols.
Use the `SSL_CIPHERS` environment variable to restrict or open up the supported ciphers.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp d1b4d469a11abc618c1406bce602300dd9793b58
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 8, 2015, 5:48 p.m.)
Review request for Michael Park.
Changes
-------
Fix leak.
Fix bug introduced by net::IP refactor.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
TODO:
Restrict SSL version more tightly
Track down leak in crypto from accept
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp d1b4d469a11abc618c1406bce602300dd9793b58
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated June 8, 2015, 12:58 p.m.)
Review request for Michael Park.
Changes
-------
fixed issues.
rebased.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
TODO:
Restrict SSL version more tightly
Track down leak in crypto from accept
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp d1b4d469a11abc618c1406bce602300dd9793b58
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated May 30, 2015, 5:29 a.m.)
Review request for Michael Park.
Changes
-------
rebasing. addressing some of mpark's issues.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
TODO:
Restrict SSL version more tightly
Track down leak in crypto from accept
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 6e8972fc4f6e0867874e30beb435a35f1ecb9c79
3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp d27fcb9d1b254b6bb7f77817819931c95d610582
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp e3de3cd6b536aaaf59784360aed546512dd04dc9
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated April 17, 2015, 4:05 p.m.)
Review request for Benjamin Hindman, Bernd Mathiske, Cody Maloney, Joerg Schad, Marco Massenzio, and Michael Park.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description (updated)
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
TODO:
Restrict SSL version more tightly
Track down leak in crypto from accept
Diffs
-----
3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated April 9, 2015, 10:04 p.m.)
Review request for Benjamin Hindman, Cody Maloney, Joerg Schad, Michael Park, and Niklas Nielsen.
Changes
-------
add missing include file.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated March 11, 2015, 11:17 p.m.)
Review request for Benjamin Hindman and Niklas Nielsen.
Changes
-------
1) Fix verify flag
2) Use create pattern like in poll socket
3) Rename postInit to initialize
4) Rename eventDtor to finalize
5) Expand comment for 'eventLoopHandle' weak_ptr
7) Add comment to and rename freeSSLCtx to 'accepted'
8) Add comment to _accept() continuation
9) Bind acceptRequest members earlier, so they don't have to be passed through acceptcallback()
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated Feb. 20, 2015, 7:24 a.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
1) Add a short-circuit flag to run_in_event_loop.
2) Don't allow short-circuit in the event loop as there is a bug with deferred callbacks in libevent_openssl.
3) Bind the shared_pointer to the socket into the shutdown continuation to avoid an invalid socket when executing shutdown.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated Feb. 19, 2015, 8:59 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Block SIGPIPE inside the event loop, as we don't have the opportunity to use MSG_NOSIGNAL with the underlying ssl bufferevents.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review73032
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29526, 29527, 29528, 29529, 29530, 29531, 29532, 29533, 29534, 29535, 29536, 29538, 29539, 29540, 29569, 28763, 29406]
All tests passed.
- Mesos ReviewBot
On Feb. 18, 2015, 11:30 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 11:30 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> USE_SSL=(0,1)
> SSL_CERT=(path to certificate)
> SSL_KEY=(path to key)
> SSL_VERIFY_CERT=(0,1)
> SSL_REQUIRE_CERT=(0,1)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
> 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated Feb. 18, 2015, 11:30 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Rather than using a watermark, we check the bufferevent upon a read request and return early if there is already data.
We can bind lambdas to a shared_pointer (which keeps it alive), so some of the run_in_event_loop calls have been refactored to use this pattern.
Cleaned up a few if statements that were checking for not-null by making this check explicit.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated Feb. 18, 2015, 11:35 a.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Summary (updated)
-----------------
Introduce libevent ssl socket.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
Diffs
-----
3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: WIP: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review71528
-----------------------------------------------------------
3rdparty/libprocess/src/libevent_ssl_socket.cpp
<https://reviews.apache.org/r/29406/#comment117272>
Turn this into non-c++11 lambda
- Joris Van Remoortere
On Feb. 6, 2015, 11:43 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2015, 11:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> USE_SSL=(0,1)
> SSL_CERT=(path to certificate)
> SSL_KEY=(path to key)
> SSL_VERIFY_CERT=(0,1)
> SSL_REQUIRE_CERT=(0,1)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
> 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: WIP: Introduce libevent ssl socket.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/#review71534
-----------------------------------------------------------
Bad patch!
Reviews applied: [29526, 29527]
Failed command: ./support/apply-review.sh -n -r 29527
Error:
2015-02-07 00:24:58 URL:https://reviews.apache.org/r/29527/diff/raw/ [8219/8219] -> "29527.patch" [1]
error: patch failed: 3rdparty/libprocess/src/tests/process_tests.cpp:21
error: 3rdparty/libprocess/src/tests/process_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Feb. 6, 2015, 11:43 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29406/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2015, 11:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1913
> https://issues.apache.org/jira/browse/MESOS-1913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Requires:
> configure --enable-libevent --enable-libevent-socket --enable-ssl
> New environment variables:
> USE_SSL=(0,1)
> SSL_CERT=(path to certificate)
> SSL_KEY=(path to key)
> SSL_VERIFY_CERT=(0,1)
> SSL_REQUIRE_CERT=(0,1)
> SSL_CA_DIR=(path to CA directory)
> SSL_CA_FILE=(path to CA file)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
> 3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.hpp PRE-CREATION
> 3rdparty/libprocess/src/openssl.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
> 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
>
> Diff: https://reviews.apache.org/r/29406/diff/
>
>
> Testing
> -------
>
> make check (uses non-ssl socket)
> benchmarks using ssl sockets
> master, slave, framework, webui launch with ssl sockets
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 29406: WIP: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated Feb. 6, 2015, 11:43 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Refactored for code-readability.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: WIP: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated Jan. 31, 2015, 11:28 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Rebased onto r29569
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212
3rdparty/libprocess/src/libevent.cpp 28c2cf7f49cc153158f2a470a1812e35f7d4b93a
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/openssl.hpp PRE-CREATION
3rdparty/libprocess/src/openssl.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere
Re: Review Request 29406: WIP: Introduce libevent ssl socket.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------
(Updated Jan. 7, 2015, 12:16 a.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
This is a Work in progress. I've left the openSSL code in for now, but this needs to be removed once we can rebase on BenH's review that introduces the openssl library functions.
Summary (updated)
-----------------
WIP: Introduce libevent ssl socket.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos-git
Description
-------
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 75870ac754e500bb4ca689201bde677fa7d854d0
3rdparty/libprocess/include/process/socket.hpp 7e1e3f22583f44a9aea8259bafedc2877ad2e633
3rdparty/libprocess/src/libevent.hpp PRE-CREATION
3rdparty/libprocess/src/libevent.cpp PRE-CREATION
3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 028b33e7ecb7e0a39334ac4ab0279ee327a72a56
3rdparty/libprocess/src/socket.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29406/diff/
Testing
-------
make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets
Thanks,
Joris Van Remoortere