[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #4182: [FIX-#4172][server-worker] kill task NPE

[GitBox <gi...@apache.org>]

lenboo commented on a change in pull request #4182:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4182#discussion_r539121372



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/AbstractCommandExecutor.java
##########
@@ -135,12 +143,17 @@ private void buildProcess(String commandFile) throws IOException {
      * @return CommandExecuteResult
      * @throws Exception if error throws Exception
      */
-    public CommandExecuteResult run(String execCommand) throws Exception{
+    public CommandExecuteResult run(String execCommand) throws Exception {
 
         CommandExecuteResult result = new CommandExecuteResult();
 
-
+        int taskInstanceId = taskExecutionContext.getTaskInstanceId();
+        // If the task has been killed, then the task in the cache is null
+        if (null == taskExecutionContextCacheManager.getByTaskInstanceId(taskInstanceId)) {
+            result.setExitStatusCode(EXIT_CODE_KILL);

Review comment:
       i think here you can return result and ignore the next process




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org