You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/02/05 07:02:19 UTC
[GitHub] [httpcomponents-core] arturobernalg opened a new pull request #254: Minor Improvements:
arturobernalg opened a new pull request #254:
URL: https://github.com/apache/httpcomponents-core/pull/254
* Simplify Case
* Simplify Object equals
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #254: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #254:
URL: https://github.com/apache/httpcomponents-core/pull/254#discussion_r570828457
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/protocol/UriPatternType.java
##########
@@ -41,11 +41,10 @@
switch (type) {
case REGEX:
return new UriRegexMatcher<>();
- case URI_PATTERN:
- return new UriPatternMatcher<>();
case URI_PATTERN_IN_ORDER:
return new UriPatternOrderedMatcher<>();
- default:
+ case URI_PATTERN:
+ default:
Review comment:
Restore indentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #254: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #254:
URL: https://github.com/apache/httpcomponents-core/pull/254#discussion_r570836570
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/protocol/UriPatternType.java
##########
@@ -41,11 +41,10 @@
switch (type) {
case REGEX:
return new UriRegexMatcher<>();
- case URI_PATTERN:
- return new UriPatternMatcher<>();
case URI_PATTERN_IN_ORDER:
return new UriPatternOrderedMatcher<>();
- default:
+ case URI_PATTERN:
+ default:
Review comment:
Changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c merged pull request #254: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #254:
URL: https://github.com/apache/httpcomponents-core/pull/254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #254: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #254:
URL: https://github.com/apache/httpcomponents-core/pull/254#discussion_r570836570
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/protocol/UriPatternType.java
##########
@@ -41,11 +41,10 @@
switch (type) {
case REGEX:
return new UriRegexMatcher<>();
- case URI_PATTERN:
- return new UriPatternMatcher<>();
case URI_PATTERN_IN_ORDER:
return new UriPatternOrderedMatcher<>();
- default:
+ case URI_PATTERN:
+ default:
Review comment:
Changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #254: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #254:
URL: https://github.com/apache/httpcomponents-core/pull/254#discussion_r570828457
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/protocol/UriPatternType.java
##########
@@ -41,11 +41,10 @@
switch (type) {
case REGEX:
return new UriRegexMatcher<>();
- case URI_PATTERN:
- return new UriPatternMatcher<>();
case URI_PATTERN_IN_ORDER:
return new UriPatternOrderedMatcher<>();
- default:
+ case URI_PATTERN:
+ default:
Review comment:
Restore indentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org