You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Richard Holt (JIRA)" <ji...@apache.org> on 2008/10/13 12:26:44 UTC

[jira] Created: (CXF-1860) JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread

JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread
-----------------------------------------------------------------------------

                 Key: CXF-1860
                 URL: https://issues.apache.org/jira/browse/CXF-1860
             Project: CXF
          Issue Type: Bug
          Components: Transports
    Affects Versions: 2.1.2
            Reporter: Richard Holt
            Priority: Critical
         Attachments: JMSDestination.java

when running a mass test against a CXF/JMS endpoint we discovered that our solution was disposing of messages. On further investigation we discovered that the code in the JMSListenerThread when it runs out of threads on the workqueue doesn't loop like the comment suggests but rather disposes of the message. 

We altered the code to follow the comments advice (shown below) and now it calls into the code held in the else statement (which just runs the message in the listener thread, maybe not ideal from an architectural viewpoint but we don't lose messages).

//FIXME - no room left on workqueue, what to do
//for now, loop until it WILL fit on the queue, 
//although we could just dispatch on this thread.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-1860) JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639067#action_12639067 ] 

Willem Jiang commented on CXF-1860:
-----------------------------------

Hi Richard,

There are some refacting works of JMS Transport[1][2][3][4] in CXF 2.1.3 snapshot, the JMSDestination has been changed a lot.
Could you try your test cast against latest CXF 2.1.3 snapshot[4] to see if the issue is still there?

[1]https://issues.apache.org/jira/browse/CXF-1773
[2]https://issues.apache.org/jira/browse/CXF-1783
[3]https://issues.apache.org/jira/browse/CXF-1827
[4]https://issues.apache.org/jira/browse/CXF-1832
[5] http://cwiki.apache.org/CXF/download.html

Willem

> JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread
> -----------------------------------------------------------------------------
>
>                 Key: CXF-1860
>                 URL: https://issues.apache.org/jira/browse/CXF-1860
>             Project: CXF
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Richard Holt
>            Priority: Critical
>         Attachments: JMSDestination.java
>
>
> when running a mass test against a CXF/JMS endpoint we discovered that our solution was disposing of messages. On further investigation we discovered that the code in the JMSListenerThread when it runs out of threads on the workqueue doesn't loop like the comment suggests but rather disposes of the message. 
> We altered the code to follow the comments advice (shown below) and now it calls into the code held in the else statement (which just runs the message in the listener thread, maybe not ideal from an architectural viewpoint but we don't lose messages).
> //FIXME - no room left on workqueue, what to do
> //for now, loop until it WILL fit on the queue, 
> //although we could just dispatch on this thread.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CXF-1860) JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread

Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schneider resolved CXF-1860.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.3

Hi Willem,

I think we can close this

Greetings,

Christian

> JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread
> -----------------------------------------------------------------------------
>
>                 Key: CXF-1860
>                 URL: https://issues.apache.org/jira/browse/CXF-1860
>             Project: CXF
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Richard Holt
>            Assignee: Christian Schneider
>            Priority: Critical
>             Fix For: 2.1.3
>
>         Attachments: JMSDestination.java
>
>
> when running a mass test against a CXF/JMS endpoint we discovered that our solution was disposing of messages. On further investigation we discovered that the code in the JMSListenerThread when it runs out of threads on the workqueue doesn't loop like the comment suggests but rather disposes of the message. 
> We altered the code to follow the comments advice (shown below) and now it calls into the code held in the else statement (which just runs the message in the listener thread, maybe not ideal from an architectural viewpoint but we don't lose messages).
> //FIXME - no room left on workqueue, what to do
> //for now, loop until it WILL fit on the queue, 
> //although we could just dispatch on this thread.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (CXF-1860) JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang closed CXF-1860.
-----------------------------


> JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread
> -----------------------------------------------------------------------------
>
>                 Key: CXF-1860
>                 URL: https://issues.apache.org/jira/browse/CXF-1860
>             Project: CXF
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Richard Holt
>            Assignee: Christian Schneider
>            Priority: Critical
>             Fix For: 2.1.3
>
>         Attachments: JMSDestination.java
>
>
> when running a mass test against a CXF/JMS endpoint we discovered that our solution was disposing of messages. On further investigation we discovered that the code in the JMSListenerThread when it runs out of threads on the workqueue doesn't loop like the comment suggests but rather disposes of the message. 
> We altered the code to follow the comments advice (shown below) and now it calls into the code held in the else statement (which just runs the message in the listener thread, maybe not ideal from an architectural viewpoint but we don't lose messages).
> //FIXME - no room left on workqueue, what to do
> //for now, loop until it WILL fit on the queue, 
> //although we could just dispatch on this thread.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-1860) JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread

Posted by "Richard Holt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639376#action_12639376 ] 

Richard Holt commented on CXF-1860:
-----------------------------------

the latest snapshot version solves this issue. thanks for your prompt reply.

regards,

> JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread
> -----------------------------------------------------------------------------
>
>                 Key: CXF-1860
>                 URL: https://issues.apache.org/jira/browse/CXF-1860
>             Project: CXF
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Richard Holt
>            Priority: Critical
>         Attachments: JMSDestination.java
>
>
> when running a mass test against a CXF/JMS endpoint we discovered that our solution was disposing of messages. On further investigation we discovered that the code in the JMSListenerThread when it runs out of threads on the workqueue doesn't loop like the comment suggests but rather disposes of the message. 
> We altered the code to follow the comments advice (shown below) and now it calls into the code held in the else statement (which just runs the message in the listener thread, maybe not ideal from an architectural viewpoint but we don't lose messages).
> //FIXME - no room left on workqueue, what to do
> //for now, loop until it WILL fit on the queue, 
> //although we could just dispatch on this thread.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CXF-1860) JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread

Posted by "Richard Holt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Holt updated CXF-1860:
------------------------------

    Attachment: JMSDestination.java

fix to allow the messages to post to the listener thread

> JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread
> -----------------------------------------------------------------------------
>
>                 Key: CXF-1860
>                 URL: https://issues.apache.org/jira/browse/CXF-1860
>             Project: CXF
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Richard Holt
>            Priority: Critical
>         Attachments: JMSDestination.java
>
>
> when running a mass test against a CXF/JMS endpoint we discovered that our solution was disposing of messages. On further investigation we discovered that the code in the JMSListenerThread when it runs out of threads on the workqueue doesn't loop like the comment suggests but rather disposes of the message. 
> We altered the code to follow the comments advice (shown below) and now it calls into the code held in the else statement (which just runs the message in the listener thread, maybe not ideal from an architectural viewpoint but we don't lose messages).
> //FIXME - no room left on workqueue, what to do
> //for now, loop until it WILL fit on the queue, 
> //although we could just dispatch on this thread.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CXF-1860) JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread

Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schneider reassigned CXF-1860:
----------------------------------------

    Assignee: Christian Schneider

> JMS Transport - JMSDestination no room left on workqueue in JMSListenerThread
> -----------------------------------------------------------------------------
>
>                 Key: CXF-1860
>                 URL: https://issues.apache.org/jira/browse/CXF-1860
>             Project: CXF
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Richard Holt
>            Assignee: Christian Schneider
>            Priority: Critical
>             Fix For: 2.1.3
>
>         Attachments: JMSDestination.java
>
>
> when running a mass test against a CXF/JMS endpoint we discovered that our solution was disposing of messages. On further investigation we discovered that the code in the JMSListenerThread when it runs out of threads on the workqueue doesn't loop like the comment suggests but rather disposes of the message. 
> We altered the code to follow the comments advice (shown below) and now it calls into the code held in the else statement (which just runs the message in the listener thread, maybe not ideal from an architectural viewpoint but we don't lose messages).
> //FIXME - no room left on workqueue, what to do
> //for now, loop until it WILL fit on the queue, 
> //although we could just dispatch on this thread.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.