You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/18 01:44:45 UTC
[GitHub] [pulsar] zplinuxlover opened a new pull request #6758: change test
case code
org.apache.pulsar.io.PulsarFunctionE2ETest#testFunctionAutomaticSubCleanup
zplinuxlover opened a new pull request #6758: change test case code org.apache.pulsar.io.PulsarFunctionE2ETest#testFunctionAutomaticSubCleanup
URL: https://github.com/apache/pulsar/pull/6758
in testcase org.apache.pulsar.io.PulsarFunctionE2ETest#testFunctionAutomaticSubCleanup,
1. there is one test checkpoint, we should not check `admin.functions().getFunction(tenant, namespacePortion, functionName).getCleanupSubscription()`,
we shold check `admin.functions().getFunction(tenant, namespacePortion, functionName)` is not null,
and `admin.functions().getFunction(tenant, namespacePortion, functionName).getCleanupSubscription()` should not be null
2. we should not check `Parallelism`, because the code here is 1 instead of 2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] zplinuxlover commented on issue #6758: change test case
code
org.apache.pulsar.io.PulsarFunctionE2ETest#testFunctionAutomaticSubCleanup
Posted by GitBox <gi...@apache.org>.
zplinuxlover commented on issue #6758: change test case code org.apache.pulsar.io.PulsarFunctionE2ETest#testFunctionAutomaticSubCleanup
URL: https://github.com/apache/pulsar/pull/6758#issuecomment-615717270
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] zplinuxlover commented on issue #6758: change test case
code
org.apache.pulsar.io.PulsarFunctionE2ETest#testFunctionAutomaticSubCleanup
Posted by GitBox <gi...@apache.org>.
zplinuxlover commented on issue #6758: change test case code org.apache.pulsar.io.PulsarFunctionE2ETest#testFunctionAutomaticSubCleanup
URL: https://github.com/apache/pulsar/pull/6758#issuecomment-615843955
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] zplinuxlover commented on issue #6758: change test case
code
org.apache.pulsar.io.PulsarFunctionE2ETest#testFunctionAutomaticSubCleanup
Posted by GitBox <gi...@apache.org>.
zplinuxlover commented on issue #6758: change test case code org.apache.pulsar.io.PulsarFunctionE2ETest#testFunctionAutomaticSubCleanup
URL: https://github.com/apache/pulsar/pull/6758#issuecomment-615716810
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services