You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Christopher Tubbs (JIRA)" <ji...@apache.org> on 2018/03/14 17:03:00 UTC

[jira] [Created] (ACCUMULO-4847) Fix Retry API

Christopher Tubbs created ACCUMULO-4847:
-------------------------------------------

             Summary: Fix Retry API
                 Key: ACCUMULO-4847
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4847
             Project: Accumulo
          Issue Type: Bug
          Components: fate
            Reporter: Christopher Tubbs
            Assignee: Christopher Tubbs
             Fix For: 1.7.4, 1.9.0, 2.0.0


ACCUMULO-4834 exposed a merge bug from ACCUMULO-4777. ACCUMULO-4777 added a parameter to the two Retry constructors, but since all the parameters are longs, this masked what should have been a compile failure by causing calls to the longer constructor to now use the shorter one.

The side effect is that any calls with "unlimited number of retries", would now be interpreted as "unlimited wait time between retries"... causing the first failure to sleep for Long.MAX_LONG millis before retrying.

I propose a refactor with a builder so the parameters cannot be confused for one another, since they all have the same long type. This is internal code, so there is no public API change.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)