You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Mike Drob <md...@mdrob.com> on 2014/03/18 21:40:46 UTC
Re: Review Request 19368: ACCUMULO-2494 Delegate math to commons-math
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19368/
-----------------------------------------------------------
(Updated March 18, 2014, 8:40 p.m.)
Review request for accumulo.
Changes
-------
Switch everything to use commons-math.
Summary (updated)
-----------------
ACCUMULO-2494 Delegate math to commons-math
Bugs: ACCUMULO-2494
https://issues.apache.org/jira/browse/ACCUMULO-2494
Repository: accumulo
Description (updated)
-------
ACCUMULO-2494 Delegate math to commons-math
Diffs (updated)
-----
core/src/main/java/org/apache/accumulo/core/util/Stat.java e65265c6decde47ef229377653112a677fef8112
core/src/test/java/org/apache/accumulo/core/util/StatTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/19368/diff/
Testing
-------
Unit tests results compared with calculations from Wolfram Alpha.
Thanks,
Mike Drob
Re: Review Request 19368: ACCUMULO-2494 Delegate math to commons-math
Posted by Mike Drob <md...@mdrob.com>.
> On March 18, 2014, 9:32 p.m., Sean Busbey wrote:
> > core/src/test/java/org/apache/accumulo/core/util/StatTest.java, line 11
> > <https://reviews.apache.org/r/19368/diff/2/?file=526415#file526415line11>
> >
> > nit: whitespace
Will fix before committing.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19368/#review37639
-----------------------------------------------------------
On March 18, 2014, 8:40 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19368/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 8:40 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2494
> https://issues.apache.org/jira/browse/ACCUMULO-2494
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2494 Delegate math to commons-math
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/accumulo/core/util/Stat.java e65265c6decde47ef229377653112a677fef8112
> core/src/test/java/org/apache/accumulo/core/util/StatTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19368/diff/
>
>
> Testing
> -------
>
> Unit tests results compared with calculations from Wolfram Alpha.
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 19368: ACCUMULO-2494 Delegate math to commons-math
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19368/#review37639
-----------------------------------------------------------
Ship it!
conditioned on open tickets from Keith against the test class
core/src/test/java/org/apache/accumulo/core/util/StatTest.java
<https://reviews.apache.org/r/19368/#comment69261>
nit: whitespace
- Sean Busbey
On March 18, 2014, 8:40 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19368/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 8:40 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2494
> https://issues.apache.org/jira/browse/ACCUMULO-2494
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2494 Delegate math to commons-math
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/accumulo/core/util/Stat.java e65265c6decde47ef229377653112a677fef8112
> core/src/test/java/org/apache/accumulo/core/util/StatTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19368/diff/
>
>
> Testing
> -------
>
> Unit tests results compared with calculations from Wolfram Alpha.
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 19368: ACCUMULO-2494 Delegate math to commons-math
Posted by Bill Havanki <bh...@clouderagovt.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19368/#review37633
-----------------------------------------------------------
Ship it!
winning
- Bill Havanki
On March 18, 2014, 4:40 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19368/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 4:40 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2494
> https://issues.apache.org/jira/browse/ACCUMULO-2494
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2494 Delegate math to commons-math
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/accumulo/core/util/Stat.java e65265c6decde47ef229377653112a677fef8112
> core/src/test/java/org/apache/accumulo/core/util/StatTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19368/diff/
>
>
> Testing
> -------
>
> Unit tests results compared with calculations from Wolfram Alpha.
>
>
> Thanks,
>
> Mike Drob
>
>