You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/03/31 11:41:36 UTC
[GitHub] [systemml] kev-inn opened a new pull request #873: Update python
package, making use of java distribution bin zip
kev-inn opened a new pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873
Updates the `setup.py`, making it read the `README.md` to remove redundancy and using the new github link.
Additionally now the steps for python packaging require calling `mvn package -DskipTests -Pdistribution` instead of just `mvn package -DskipTests`, because we now use the generated `systemds-*-SNAPSHOT-bin.zip` from which we copy the fewer jars used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] Baunsgaard commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400858736
##########
File path: src/main/python/README.md
##########
@@ -1,4 +1,7 @@
-# Python Readme
+# SystemDS
Review comment:
Missing License
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] Baunsgaard commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400855332
##########
File path: .github/workflows/python.yml
##########
@@ -86,16 +86,5 @@ jobs:
cd src/main/python
ls tests/
echo "Beginning tests"
- python tests/test_matrix_binary_op.py
- echo "Exit Status: " $?
- sleep 3
- python tests/test_matrix_aggregations.py
- echo "Exit Status: " $?
- sleep 3
- python tests/test_l2svm.py
- echo "Exit Status: " $?
- python tests/test_lineagetrace.py
- sleep 3
- echo "Exit Status: " $?
- python tests/test_l2svm_lineage.py
+ python -m unittest tests/*.py
Review comment:
:+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] Baunsgaard commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400877466
##########
File path: src/main/python/setup.py
##########
@@ -49,19 +48,7 @@
name=ARTIFACT_NAME,
version=ARTIFACT_VERSION_SHORT,
description='SystemDS is a distributed and declarative machine learning platform.',
- long_description='''SystemDS is a versatile system for the end-to-end data science lifecycle from data integration,
- cleaning, and feature engineering, over efficient, local and distributed ML model training,
- to deployment and serving.
- To facilitate this, bindings from different languages and different system abstractions provide help for:
- (1) the different tasks of the data-science lifecycle, and
- (2) users with different expertise.
-
-
- These high-level scripts are compiled into hybrid execution plans of local, in-memory CPU and GPU operations,
- as well as distributed operations on Apache Spark. In contrast to existing systems
- - that either provide homogeneous tensors or 2D Datasets - and in order to serve the entire
- data science lifecycle, the underlying data model are DataTensors, i.e.,
- tensors (multi-dimensional arrays) whose first dimension may have a heterogeneous and nested schema.''',
+ long_description=open('README.md').read(),
Review comment:
then keep it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] Baunsgaard commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400859398
##########
File path: src/main/python/setup.py
##########
@@ -49,19 +48,7 @@
name=ARTIFACT_NAME,
version=ARTIFACT_VERSION_SHORT,
description='SystemDS is a distributed and declarative machine learning platform.',
- long_description='''SystemDS is a versatile system for the end-to-end data science lifecycle from data integration,
- cleaning, and feature engineering, over efficient, local and distributed ML model training,
- to deployment and serving.
- To facilitate this, bindings from different languages and different system abstractions provide help for:
- (1) the different tasks of the data-science lifecycle, and
- (2) users with different expertise.
-
-
- These high-level scripts are compiled into hybrid execution plans of local, in-memory CPU and GPU operations,
- as well as distributed operations on Apache Spark. In contrast to existing systems
- - that either provide homogeneous tensors or 2D Datasets - and in order to serve the entire
- data science lifecycle, the underlying data model are DataTensors, i.e.,
- tensors (multi-dimensional arrays) whose first dimension may have a heterogeneous and nested schema.''',
+ long_description=open('README.md').read(),
Review comment:
Once the license is added in the README, you might want to skip that amount of lines here to shorten the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] kev-inn commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400862401
##########
File path: src/main/python/README.md
##########
@@ -1,4 +1,7 @@
-# Python Readme
+# SystemDS
+
+[](https://travis-ci.com/tugraz-isds/systemds)
+[](https://opensource.org/licenses/Apache-2.0)
Review comment:
Should I keep the build status? or just license and python?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] Baunsgaard commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400857253
##########
File path: src/main/python/README.md
##########
@@ -1,4 +1,7 @@
-# Python Readme
+# SystemDS
+
+[](https://travis-ci.com/tugraz-isds/systemds)
+[](https://opensource.org/licenses/Apache-2.0)
Review comment:
The Travis is pointing at out old Repository, and more importantly, the Travis test only execute component test which does not effect the python part.
Look at the main README, and maybe copy the python badges?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] Baunsgaard commented on issue #873: Update python
package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on issue #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#issuecomment-606612194
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] kev-inn commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400865792
##########
File path: src/main/python/BUILD_INSTRUCTIONS.md
##########
@@ -23,27 +23,34 @@ limitations under the License.
The following steps have to be done for both cases
-- Build SystemDS with maven first `mvn package -DskipTests`, with the working directory being `SYSTEMDS_ROOT` (Root directory of SystemDS)
+- Build SystemDS with maven first `mvn package -Pdistribution`, with the working directory being `SYSTEMDS_ROOT` (Root directory of SystemDS)
- `cd` to this folder (basically `SYSTEMDS_ROOT/src/main/python`
-### Building package
+### Building package for release
If we want to build the package for uploading to the repository via `python3 -m twine upload --repository-url [URL] dist/*` (will be automated in the future)
+- Install twine with `pip install --upgrade twine`
- Run `create_python_dist.py`
```bash
python3 create_python_dist.py
```
- now in the `./dist` directory there will exist the source distribution `systemds-VERSION.tar.gz` and the wheel distribution `systemds-VERSION-py3-none-any.whl`, with `VERSION` being the current version number
-- Finished. We can now upload it with `python3 -m twine upload --repository-url [URL] dist/*`
+
+- Follow the instructions from the [Guide](https://packaging.python.org/tutorials/packaging-projects/)
+ 1. Create an API-Token in the account (leave the page open or copy the token, it will only be shown once)
+ 2. Execute the command `python3 -m twine upload dist/*`
+ - Optional: `pip install keyrings.alt` if you get `UserWarning: No recommended backend was available.`
+ 3. Username is `__token__`
+ 4. Password is the created API-Token **with** `pypi-` prefix
Review comment:
I can do this for the `Building for development` but the other case is actually for releasing the package. We probably anyway want to move this somewhere else (and automate it at some point), but for now should I just rename the file `PUBLISH_INSTRUCTIONS.md`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] Baunsgaard commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400857902
##########
File path: src/main/python/setup.py
##########
@@ -49,19 +48,7 @@
name=ARTIFACT_NAME,
version=ARTIFACT_VERSION_SHORT,
description='SystemDS is a distributed and declarative machine learning platform.',
- long_description='''SystemDS is a versatile system for the end-to-end data science lifecycle from data integration,
- cleaning, and feature engineering, over efficient, local and distributed ML model training,
- to deployment and serving.
- To facilitate this, bindings from different languages and different system abstractions provide help for:
- (1) the different tasks of the data-science lifecycle, and
- (2) users with different expertise.
-
-
- These high-level scripts are compiled into hybrid execution plans of local, in-memory CPU and GPU operations,
- as well as distributed operations on Apache Spark. In contrast to existing systems
- - that either provide homogeneous tensors or 2D Datasets - and in order to serve the entire
- data science lifecycle, the underlying data model are DataTensors, i.e.,
- tensors (multi-dimensional arrays) whose first dimension may have a heterogeneous and nested schema.''',
+ long_description=open('README.md').read(),
Review comment:
:+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] Baunsgaard commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400863094
##########
File path: .github/workflows/python.yml
##########
@@ -86,16 +86,5 @@ jobs:
cd src/main/python
ls tests/
echo "Beginning tests"
- python tests/test_matrix_binary_op.py
- echo "Exit Status: " $?
- sleep 3
- python tests/test_matrix_aggregations.py
- echo "Exit Status: " $?
- sleep 3
- python tests/test_l2svm.py
- echo "Exit Status: " $?
- python tests/test_lineagetrace.py
- sleep 3
- echo "Exit Status: " $?
- python tests/test_l2svm_lineage.py
+ python -m unittest tests/*.py
Review comment:
For the federated i have made a separate folder, since we need the workers to start up. This fits perfectly with that. Furthermore, i think in the future we need to separate the tests into sub-folders. But this is perfect for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] Baunsgaard commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400878301
##########
File path: src/main/python/BUILD_INSTRUCTIONS.md
##########
@@ -23,27 +23,34 @@ limitations under the License.
The following steps have to be done for both cases
-- Build SystemDS with maven first `mvn package -DskipTests`, with the working directory being `SYSTEMDS_ROOT` (Root directory of SystemDS)
+- Build SystemDS with maven first `mvn package -Pdistribution`, with the working directory being `SYSTEMDS_ROOT` (Root directory of SystemDS)
- `cd` to this folder (basically `SYSTEMDS_ROOT/src/main/python`
-### Building package
+### Building package for release
If we want to build the package for uploading to the repository via `python3 -m twine upload --repository-url [URL] dist/*` (will be automated in the future)
+- Install twine with `pip install --upgrade twine`
- Run `create_python_dist.py`
```bash
python3 create_python_dist.py
```
- now in the `./dist` directory there will exist the source distribution `systemds-VERSION.tar.gz` and the wheel distribution `systemds-VERSION-py3-none-any.whl`, with `VERSION` being the current version number
-- Finished. We can now upload it with `python3 -m twine upload --repository-url [URL] dist/*`
+
+- Follow the instructions from the [Guide](https://packaging.python.org/tutorials/packaging-projects/)
+ 1. Create an API-Token in the account (leave the page open or copy the token, it will only be shown once)
+ 2. Execute the command `python3 -m twine upload dist/*`
+ - Optional: `pip install keyrings.alt` if you get `UserWarning: No recommended backend was available.`
+ 3. Username is `__token__`
+ 4. Password is the created API-Token **with** `pypi-` prefix
Review comment:
hmm, i think the name change sounds good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] Baunsgaard commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400863444
##########
File path: src/main/python/BUILD_INSTRUCTIONS.md
##########
@@ -23,27 +23,34 @@ limitations under the License.
The following steps have to be done for both cases
-- Build SystemDS with maven first `mvn package -DskipTests`, with the working directory being `SYSTEMDS_ROOT` (Root directory of SystemDS)
+- Build SystemDS with maven first `mvn package -Pdistribution`, with the working directory being `SYSTEMDS_ROOT` (Root directory of SystemDS)
- `cd` to this folder (basically `SYSTEMDS_ROOT/src/main/python`
-### Building package
+### Building package for release
If we want to build the package for uploading to the repository via `python3 -m twine upload --repository-url [URL] dist/*` (will be automated in the future)
+- Install twine with `pip install --upgrade twine`
- Run `create_python_dist.py`
```bash
python3 create_python_dist.py
```
- now in the `./dist` directory there will exist the source distribution `systemds-VERSION.tar.gz` and the wheel distribution `systemds-VERSION-py3-none-any.whl`, with `VERSION` being the current version number
-- Finished. We can now upload it with `python3 -m twine upload --repository-url [URL] dist/*`
+
+- Follow the instructions from the [Guide](https://packaging.python.org/tutorials/packaging-projects/)
+ 1. Create an API-Token in the account (leave the page open or copy the token, it will only be shown once)
+ 2. Execute the command `python3 -m twine upload dist/*`
+ - Optional: `pip install keyrings.alt` if you get `UserWarning: No recommended backend was available.`
+ 3. Username is `__token__`
+ 4. Password is the created API-Token **with** `pypi-` prefix
Review comment:
https://damslab.github.io/docs/sysdspython/install.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] kev-inn commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400860953
##########
File path: .github/workflows/python.yml
##########
@@ -57,7 +57,7 @@ jobs:
${{ runner.os }}-maven-
- name: Maven clean & package
- run: mvn clean package
+ run: mvn clean package -Pdistribution
Review comment:
Didn't know that is also a valid command, will update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] kev-inn commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400863451
##########
File path: src/main/python/setup.py
##########
@@ -49,19 +48,7 @@
name=ARTIFACT_NAME,
version=ARTIFACT_VERSION_SHORT,
description='SystemDS is a distributed and declarative machine learning platform.',
- long_description='''SystemDS is a versatile system for the end-to-end data science lifecycle from data integration,
- cleaning, and feature engineering, over efficient, local and distributed ML model training,
- to deployment and serving.
- To facilitate this, bindings from different languages and different system abstractions provide help for:
- (1) the different tasks of the data-science lifecycle, and
- (2) users with different expertise.
-
-
- These high-level scripts are compiled into hybrid execution plans of local, in-memory CPU and GPU operations,
- as well as distributed operations on Apache Spark. In contrast to existing systems
- - that either provide homogeneous tensors or 2D Datasets - and in order to serve the entire
- data science lifecycle, the underlying data model are DataTensors, i.e.,
- tensors (multi-dimensional arrays) whose first dimension may have a heterogeneous and nested schema.''',
+ long_description=open('README.md').read(),
Review comment:
Do you think it is worth it? I like the simplicity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] kev-inn commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400861801
##########
File path: src/main/python/BUILD_INSTRUCTIONS.md
##########
@@ -23,27 +23,34 @@ limitations under the License.
The following steps have to be done for both cases
-- Build SystemDS with maven first `mvn package -DskipTests`, with the working directory being `SYSTEMDS_ROOT` (Root directory of SystemDS)
+- Build SystemDS with maven first `mvn package -Pdistribution`, with the working directory being `SYSTEMDS_ROOT` (Root directory of SystemDS)
- `cd` to this folder (basically `SYSTEMDS_ROOT/src/main/python`
-### Building package
+### Building package for release
If we want to build the package for uploading to the repository via `python3 -m twine upload --repository-url [URL] dist/*` (will be automated in the future)
+- Install twine with `pip install --upgrade twine`
- Run `create_python_dist.py`
```bash
python3 create_python_dist.py
```
- now in the `./dist` directory there will exist the source distribution `systemds-VERSION.tar.gz` and the wheel distribution `systemds-VERSION-py3-none-any.whl`, with `VERSION` being the current version number
-- Finished. We can now upload it with `python3 -m twine upload --repository-url [URL] dist/*`
+
+- Follow the instructions from the [Guide](https://packaging.python.org/tutorials/packaging-projects/)
+ 1. Create an API-Token in the account (leave the page open or copy the token, it will only be shown once)
+ 2. Execute the command `python3 -m twine upload dist/*`
+ - Optional: `pip install keyrings.alt` if you get `UserWarning: No recommended backend was available.`
+ 3. Username is `__token__`
+ 4. Password is the created API-Token **with** `pypi-` prefix
Review comment:
Which ones?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] kev-inn commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400870534
##########
File path: src/main/python/README.md
##########
@@ -1,4 +1,7 @@
-# Python Readme
+# SystemDS
+
+[](https://travis-ci.com/tugraz-isds/systemds)
+[](https://opensource.org/licenses/Apache-2.0)
Review comment:
I decided on just the python test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] kev-inn commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400861209
##########
File path: .github/workflows/python.yml
##########
@@ -86,16 +86,5 @@ jobs:
cd src/main/python
ls tests/
echo "Beginning tests"
- python tests/test_matrix_binary_op.py
- echo "Exit Status: " $?
- sleep 3
- python tests/test_matrix_aggregations.py
- echo "Exit Status: " $?
- sleep 3
- python tests/test_l2svm.py
- echo "Exit Status: " $?
- python tests/test_lineagetrace.py
- sleep 3
- echo "Exit Status: " $?
- python tests/test_l2svm_lineage.py
+ python -m unittest tests/*.py
Review comment:
for federated we have to adapt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] Baunsgaard commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400855878
##########
File path: src/main/python/BUILD_INSTRUCTIONS.md
##########
@@ -23,27 +23,34 @@ limitations under the License.
The following steps have to be done for both cases
-- Build SystemDS with maven first `mvn package -DskipTests`, with the working directory being `SYSTEMDS_ROOT` (Root directory of SystemDS)
+- Build SystemDS with maven first `mvn package -Pdistribution`, with the working directory being `SYSTEMDS_ROOT` (Root directory of SystemDS)
- `cd` to this folder (basically `SYSTEMDS_ROOT/src/main/python`
-### Building package
+### Building package for release
If we want to build the package for uploading to the repository via `python3 -m twine upload --repository-url [URL] dist/*` (will be automated in the future)
+- Install twine with `pip install --upgrade twine`
- Run `create_python_dist.py`
```bash
python3 create_python_dist.py
```
- now in the `./dist` directory there will exist the source distribution `systemds-VERSION.tar.gz` and the wheel distribution `systemds-VERSION-py3-none-any.whl`, with `VERSION` being the current version number
-- Finished. We can now upload it with `python3 -m twine upload --repository-url [URL] dist/*`
+
+- Follow the instructions from the [Guide](https://packaging.python.org/tutorials/packaging-projects/)
+ 1. Create an API-Token in the account (leave the page open or copy the token, it will only be shown once)
+ 2. Execute the command `python3 -m twine upload dist/*`
+ - Optional: `pip install keyrings.alt` if you get `UserWarning: No recommended backend was available.`
+ 3. Username is `__token__`
+ 4. Password is the created API-Token **with** `pypi-` prefix
Review comment:
Maybe just link to the docs, Then we have one place instead of two with the information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] kev-inn commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
kev-inn commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400878868
##########
File path: src/main/python/BUILD_INSTRUCTIONS.md
##########
@@ -23,27 +23,34 @@ limitations under the License.
The following steps have to be done for both cases
-- Build SystemDS with maven first `mvn package -DskipTests`, with the working directory being `SYSTEMDS_ROOT` (Root directory of SystemDS)
+- Build SystemDS with maven first `mvn package -Pdistribution`, with the working directory being `SYSTEMDS_ROOT` (Root directory of SystemDS)
- `cd` to this folder (basically `SYSTEMDS_ROOT/src/main/python`
-### Building package
+### Building package for release
If we want to build the package for uploading to the repository via `python3 -m twine upload --repository-url [URL] dist/*` (will be automated in the future)
+- Install twine with `pip install --upgrade twine`
- Run `create_python_dist.py`
```bash
python3 create_python_dist.py
```
- now in the `./dist` directory there will exist the source distribution `systemds-VERSION.tar.gz` and the wheel distribution `systemds-VERSION-py3-none-any.whl`, with `VERSION` being the current version number
-- Finished. We can now upload it with `python3 -m twine upload --repository-url [URL] dist/*`
+
+- Follow the instructions from the [Guide](https://packaging.python.org/tutorials/packaging-projects/)
+ 1. Create an API-Token in the account (leave the page open or copy the token, it will only be shown once)
+ 2. Execute the command `python3 -m twine upload dist/*`
+ - Optional: `pip install keyrings.alt` if you get `UserWarning: No recommended backend was available.`
+ 3. Username is `__token__`
+ 4. Password is the created API-Token **with** `pypi-` prefix
Review comment:
Ok :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] Baunsgaard commented on a change in pull request #873:
Update python package, making use of java distribution bin zip
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #873: Update python package, making use of java distribution bin zip
URL: https://github.com/apache/systemml/pull/873#discussion_r400855251
##########
File path: .github/workflows/python.yml
##########
@@ -57,7 +57,7 @@ jobs:
${{ runner.os }}-maven-
- name: Maven clean & package
- run: mvn clean package
+ run: mvn clean package -Pdistribution
Review comment:
Why is it not:
```bash
mvn clean package -P distribution
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services