You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yadavay-amzn (via GitHub)" <gi...@apache.org> on 2026/06/09 06:11:50 UTC
[PR] [SPARK-57148][SQL] Rename splitSemiColonWithIndex to splitSemiColon [spark]
yadavay-amzn opened a new pull request, #56386:
URL: https://github.com/apache/spark/pull/56386
### What changes were proposed in this pull request?
Rename `splitSemiColonWithIndex` to `splitSemiColon` in `StringUtils`. The method no longer returns indices (it returns `List[String]`), so the name is misleading.
Follow-up to #55466 as suggested by @cloud-fan.
### Why are the changes needed?
The method was originally named `splitSemiColonWithIndex` when it returned index information. After the structural scanner refactor in SPARK-54876, it returns `List[String]` with no index information. The name should match the return type.
### Does this PR introduce _any_ user-facing change?
No. This is an internal API rename (package-private method).
### How was this patch tested?
Existing tests pass. No behavioral change.
### Was this patch authored or co-authored using generative AI tooling?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57148][SQL] Rename splitSemiColonWithIndex to splitSemiColon [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #56386:
URL: https://github.com/apache/spark/pull/56386#issuecomment-4663092527
thanks, merging to master/4.x!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57148][SQL] Rename splitSemiColonWithIndex to splitSemiColon [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #56386: [SPARK-57148][SQL] Rename splitSemiColonWithIndex to splitSemiColon
URL: https://github.com/apache/spark/pull/56386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org