[GitHub] [helix] jiajunwang commented on pull request #1540: Move subscribeForChange out of critical section

[GitBox <gi...@apache.org>]

jiajunwang commented on pull request #1540:
URL: https://github.com/apache/helix/pull/1540#issuecomment-729305647


   Should be good, but it would be great if you can rebase to the top of the master with more test fixes and see if it can pass without any error.
   I can also help to trigger more github tests for you to ensure it is 100% safe.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org