You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/18 17:12:58 UTC
[GitHub] [beam] sethvargo opened a new pull request #17123: Pin setup-gcloud to v0 instead of master
sethvargo opened a new pull request #17123:
URL: https://github.com/apache/beam/pull/17123
setup-gcloud will be updating the branch name from master to main in
a future release. Even though GitHub will establish redirects, this
will break any GitHub Actions workflows that pin to master. This PR
updates your GitHub Actions workflows to pin to v0, which is the
recommended best practice.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. N/A
- [x] Update `CHANGES.md` with noteworthy changes. N/A
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). N/A
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sethvargo commented on pull request #17123: Pin setup-gcloud to v0 instead of master
Posted by GitBox <gi...@apache.org>.
sethvargo commented on pull request #17123:
URL: https://github.com/apache/beam/pull/17123#issuecomment-1072617992
There doesn't seem to be an obvious owner for this. @damccorm @jrmccluskey you edited these files more recently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #17123: Pin setup-gcloud to v0 instead of master
Posted by GitBox <gi...@apache.org>.
lostluck commented on pull request #17123:
URL: https://github.com/apache/beam/pull/17123#issuecomment-1072899622
Done. The Collect and Deploy workflow seems a bit heavy handed in when it runs (I've seen it on everything), but I can ensure the setup-gcloud step passes at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #17123: Pin setup-gcloud to v0 instead of master
Posted by GitBox <gi...@apache.org>.
lostluck commented on pull request #17123:
URL: https://github.com/apache/beam/pull/17123#issuecomment-1072900015
It passes that step, and fails on the a later step about JSON parsing. I'm happy to call this PR good though. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #17123: Pin setup-gcloud to v0 instead of master
Posted by GitBox <gi...@apache.org>.
lostluck merged pull request #17123:
URL: https://github.com/apache/beam/pull/17123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #17123: Pin setup-gcloud to v0 instead of master
Posted by GitBox <gi...@apache.org>.
jrmccluskey commented on pull request #17123:
URL: https://github.com/apache/beam/pull/17123#issuecomment-1072630702
R: @lostluck @youngoli
Can we get approval to run the workflows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org