You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/09/11 22:43:29 UTC
[GitHub] [zookeeper] lvfangmin commented on a change in pull request #1088:
ZOOKEEPER-3542 X509UtilTest#testClientRenegotiationFails is flaky on JDK8 +
linux on machines with 2 cores
lvfangmin commented on a change in pull request #1088: ZOOKEEPER-3542 X509UtilTest#testClientRenegotiationFails is flaky on JDK8 + linux on machines with 2 cores
URL: https://github.com/apache/zookeeper/pull/1088#discussion_r323491064
##########
File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java
##########
@@ -538,6 +540,7 @@ public void testClientRenegotiationFails() throws Throwable {
SSLSocket clientSocket = null;
SSLSocket serverSocket = null;
final AtomicInteger handshakesCompleted = new AtomicInteger(0);
Review comment:
Looks like we can remove handshakesCompleted after adding the count down.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services