You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/10/23 09:58:56 UTC
Review Request 39579: Updated docker registry client to check HTTP
code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39579/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jojy Varghese.
Repository: mesos
Description
-------
Updated docker registry client to check HTTP code.
Diffs
-----
src/slave/containerizer/provisioner/docker/registry_client.cpp 24aa95c5800ff4dfb37465b71421b014b5dd5998
Diff: https://reviews.apache.org/r/39579/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 39579: Updated docker registry client to check
HTTP code.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39579/#review103748
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38416, 38779, 39579]
All tests passed.
- Mesos ReviewBot
On Oct. 23, 2015, 7:58 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39579/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 7:58 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated docker registry client to check HTTP code.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/docker/registry_client.cpp 24aa95c5800ff4dfb37465b71421b014b5dd5998
>
> Diff: https://reviews.apache.org/r/39579/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 39579: Updated docker registry client to check
HTTP code.
Posted by Gilbert Song <gi...@mesoshere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39579/#review103791
-----------------------------------------------------------
Ship it!
LGTM! Ship It!
- Gilbert Song
On Oct. 23, 2015, 12:58 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39579/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 12:58 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated docker registry client to check HTTP code.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/docker/registry_client.cpp 24aa95c5800ff4dfb37465b71421b014b5dd5998
>
> Diff: https://reviews.apache.org/r/39579/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 39579: Updated docker registry client to check
HTTP code.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39579/#review103795
-----------------------------------------------------------
src/slave/containerizer/provisioner/docker/registry_client.cpp (line 360)
<https://reviews.apache.org/r/39579/#comment161883>
We are refactoring this code and have split the method into small chunks. I was expecting this change as part of that.
- Jojy Varghese
On Oct. 23, 2015, 7:58 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39579/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 7:58 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated docker registry client to check HTTP code.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/docker/registry_client.cpp 24aa95c5800ff4dfb37465b71421b014b5dd5998
>
> Diff: https://reviews.apache.org/r/39579/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>