You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Nigel Daley (JIRA)" <ji...@apache.org> on 2007/05/15 00:02:16 UTC

[jira] Created: (HADOOP-1357) Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)

Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)
-------------------------------------------------------------------------------------------------------

                 Key: HADOOP-1357
                 URL: https://issues.apache.org/jira/browse/HADOOP-1357
             Project: Hadoop
          Issue Type: Bug
          Components: util
    Affects Versions: 0.12.3
            Reporter: Nigel Daley
            Priority: Blocker
             Fix For: 0.13.0


CopyFiles.java line 369

The call to equals is comparing a Path and a String, which will never be equal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1357) Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-1357:
----------------------------------

    Fix Version/s:     (was: 0.13.0)
                   0.14.0
         Assignee: Arun C Murthy
         Priority: Minor  (was: Blocker)

I don't think this is a _blocker_, pls feel free to correct me...

> Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1357
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1357
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.12.3
>            Reporter: Nigel Daley
>         Assigned To: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.14.0
>
>
> CopyFiles.java line 369
> The call to equals is comparing a Path and a String, which will never be equal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1357) Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495935 ] 

Hadoop QA commented on HADOOP-1357:
-----------------------------------

+1

http://issues.apache.org/jira/secure/attachment/12357367/HADOOP-1357_1_20070515.patch applied and successfully tested against trunk revision r537939.

Test results:   http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/141/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/141/console

> Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1357
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1357
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.12.3
>            Reporter: Nigel Daley
>         Assigned To: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: HADOOP-1357_1_20070515.patch
>
>
> CopyFiles.java line 369
> The call to equals is comparing a Path and a String, which will never be equal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1357) Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-1357:
----------------------------------

    Attachment: HADOOP-1357_1_20070515.patch

Straight-forward fix...

> Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1357
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1357
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.12.3
>            Reporter: Nigel Daley
>         Assigned To: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: HADOOP-1357_1_20070515.patch
>
>
> CopyFiles.java line 369
> The call to equals is comparing a Path and a String, which will never be equal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1357) Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496533 ] 

Hadoop QA commented on HADOOP-1357:
-----------------------------------

Integrated in Hadoop-Nightly #91 (See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/91/)

> Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1357
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1357
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.12.3
>            Reporter: Nigel Daley
>         Assigned To: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: HADOOP-1357_1_20070515.patch
>
>
> CopyFiles.java line 369
> The call to equals is comparing a Path and a String, which will never be equal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1357) Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated HADOOP-1357:
---------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this.  Thanks, Arun!

> Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1357
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1357
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.12.3
>            Reporter: Nigel Daley
>         Assigned To: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: HADOOP-1357_1_20070515.patch
>
>
> CopyFiles.java line 369
> The call to equals is comparing a Path and a String, which will never be equal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1357) Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495798 ] 

Nigel Daley commented on HADOOP-1357:
-------------------------------------

Same problem on line 508 of CopyFiles.java

> Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1357
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1357
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.12.3
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.13.0
>
>
> CopyFiles.java line 369
> The call to equals is comparing a Path and a String, which will never be equal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1357) Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-1357:
----------------------------------

    Status: Patch Available  (was: Open)

> Call to equals() comparing different types in CopyFiles.cleanup(Configuration, JobConf, String, String)
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1357
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1357
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.12.3
>            Reporter: Nigel Daley
>         Assigned To: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: HADOOP-1357_1_20070515.patch
>
>
> CopyFiles.java line 369
> The call to equals is comparing a Path and a String, which will never be equal.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.