[GitHub] [phoenix] priyankporwal commented on a change in pull request #597: PHOENIX-5522 If index is disabled, IndexUpgradeTool should not fail d…

[GitBox <gi...@apache.org>]

priyankporwal commented on a change in pull request #597: PHOENIX-5522 If index is disabled, IndexUpgradeTool should not fail d…
URL: https://github.com/apache/phoenix/pull/597#discussion_r334577091
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java
 ##########
 @@ -221,25 +235,25 @@ private void checkOldIndexingCoprocessors(String [] indexList, String [] tableLi
         }
     }
 
-    @Parameters(name ="IndexUpgradeToolIT_mutable={0},upgrade={1},isNamespaceEnabled={2}")
+    @Parameters(name ="IndexUpgradeToolIT_mutable={0},upgrade={1},isNamespaceEnabled={2},isDisabledIndex={3}")
     public static Collection<Object[]> data() {
-        return Arrays.asList(new Object[][] {
-            {false, false, true},
-            {true, false, true},
-            {false, true, true},
-            {true, true, true},
-            {false, false, false},
-            {true, false, false},
-            {false, true, false},
-            {true, true, false}
-        });
+        return Arrays.asList(new Object[][] { { false, false, true, true },
+                { false, false, true, false }, { true, false, true, true },
 
 Review comment:
   +1 .. The test matrix keeps getting doubled for every variant. Perhaps mix these up with some random combination of isNamespaceEnbaled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services