You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dominic Mitchell (JIRA)" <ji...@codehaus.org> on 2010/01/10 22:22:55 UTC
[jira] Created: (MNG-4526) Shade plugin includes too much (relative
to 2.2.1)
Shade plugin includes too much (relative to 2.2.1)
--------------------------------------------------
Key: MNG-4526
URL: http://jira.codehaus.org/browse/MNG-4526
Project: Maven 2 & 3
Issue Type: Bug
Components: Plugins and Lifecycle
Affects Versions: 3.0-alpha-6
Environment: OS X 10.5.8
Reporter: Dominic Mitchell
Attachments: happygiraffe-jslint4java-957bfd1.zip, jslint4java-mvn-2.2.1.out, jslint4java-mvn-3.0-alpha-6.out
When creating a shaded jar using the maven 3.0-alpha-6, I get too many dependencies included. I think it's incorrectly including things in provided scope.
My project is [jslint4java|http://github.com/happygiraffe/jslint4java/]. This is what I see when I run {{mvn -Pdist clean package}}:
{noformat}
[INFO] --- maven-shade-plugin:1.2.2:shade (make-shaded-jar) @ jslint4java-ant ---
[INFO] Including com.googlecode.jslint4java:jslint4java:jar:1.3.4-SNAPSHOT in the shaded jar.
[INFO] Including rhino:js:jar:1.7R1 in the shaded jar.
[INFO] Including org.apache.ant:ant:jar:1.7.1 in the shaded jar.
[INFO] Including org.apache.ant:ant-launcher:jar:1.7.1 in the shaded jar.
[INFO] Including org.apache.ant:ant-antunit:jar:1.1 in the shaded jar.
[INFO] Including junit:junit:jar:4.6 in the shaded jar.
[INFO] Attaching shaded artifact.
{noformat}
Of those dependencies, only the first two should be included. This worked correctly in maven-2.2.1.
Unfortunately, I've no idea what's going wrong whether it's the shade plugin or something in core maven. I've attached a zip of the source, as well as mvn -X output for both 3.0-alpha-6 and 2.2.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-4526) [regression] Shade plugin includes too
much (relative to 2.2.1)
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-4526:
-----------------------------------
Summary: [regression] Shade plugin includes too much (relative to 2.2.1) (was: Shade plugin includes too much (relative to 2.2.1))
> [regression] Shade plugin includes too much (relative to 2.2.1)
> ---------------------------------------------------------------
>
> Key: MNG-4526
> URL: http://jira.codehaus.org/browse/MNG-4526
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Plugins and Lifecycle
> Affects Versions: 3.0-alpha-6
> Environment: OS X 10.5.8
> Reporter: Dominic Mitchell
> Attachments: happygiraffe-jslint4java-957bfd1.zip, jslint4java-mvn-2.2.1.out, jslint4java-mvn-3.0-alpha-6.out
>
>
> When creating a shaded jar using the maven 3.0-alpha-6, I get too many dependencies included. I think it's incorrectly including things in provided scope.
> My project is [jslint4java|http://github.com/happygiraffe/jslint4java/]. This is what I see when I run {{mvn -Pdist clean package}}:
> {noformat}
> [INFO] --- maven-shade-plugin:1.2.2:shade (make-shaded-jar) @ jslint4java-ant ---
> [INFO] Including com.googlecode.jslint4java:jslint4java:jar:1.3.4-SNAPSHOT in the shaded jar.
> [INFO] Including rhino:js:jar:1.7R1 in the shaded jar.
> [INFO] Including org.apache.ant:ant:jar:1.7.1 in the shaded jar.
> [INFO] Including org.apache.ant:ant-launcher:jar:1.7.1 in the shaded jar.
> [INFO] Including org.apache.ant:ant-antunit:jar:1.1 in the shaded jar.
> [INFO] Including junit:junit:jar:4.6 in the shaded jar.
> [INFO] Attaching shaded artifact.
> {noformat}
> Of those dependencies, only the first two should be included. This worked correctly in maven-2.2.1.
> Unfortunately, I've no idea what's going wrong whether it's the shade plugin or something in core maven. I've attached a zip of the source, as well as mvn -X output for both 3.0-alpha-6 and 2.2.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-4526) [regression] Shade plugin includes too
much (relative to 2.2.1)
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann closed MNG-4526.
----------------------------------
Resolution: Fixed
Fix Version/s: 3.0-alpha-7
Assignee: Benjamin Bentmann
Fixed in [r904309|http://svn.apache.org/viewvc?view=revision&revision=904309]. Thanks for the example project!
> [regression] Shade plugin includes too much (relative to 2.2.1)
> ---------------------------------------------------------------
>
> Key: MNG-4526
> URL: http://jira.codehaus.org/browse/MNG-4526
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Plugins and Lifecycle
> Affects Versions: 3.0-alpha-6
> Environment: OS X 10.5.8
> Reporter: Dominic Mitchell
> Assignee: Benjamin Bentmann
> Fix For: 3.0-alpha-7
>
> Attachments: happygiraffe-jslint4java-957bfd1.zip, jslint4java-mvn-2.2.1.out, jslint4java-mvn-3.0-alpha-6.out
>
>
> When creating a shaded jar using the maven 3.0-alpha-6, I get too many dependencies included. I think it's incorrectly including things in provided scope.
> My project is [jslint4java|http://github.com/happygiraffe/jslint4java/]. This is what I see when I run {{mvn -Pdist clean package}}:
> {noformat}
> [INFO] --- maven-shade-plugin:1.2.2:shade (make-shaded-jar) @ jslint4java-ant ---
> [INFO] Including com.googlecode.jslint4java:jslint4java:jar:1.3.4-SNAPSHOT in the shaded jar.
> [INFO] Including rhino:js:jar:1.7R1 in the shaded jar.
> [INFO] Including org.apache.ant:ant:jar:1.7.1 in the shaded jar.
> [INFO] Including org.apache.ant:ant-launcher:jar:1.7.1 in the shaded jar.
> [INFO] Including org.apache.ant:ant-antunit:jar:1.1 in the shaded jar.
> [INFO] Including junit:junit:jar:4.6 in the shaded jar.
> [INFO] Attaching shaded artifact.
> {noformat}
> Of those dependencies, only the first two should be included. This worked correctly in maven-2.2.1.
> Unfortunately, I've no idea what's going wrong whether it's the shade plugin or something in core maven. I've attached a zip of the source, as well as mvn -X output for both 3.0-alpha-6 and 2.2.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira