You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "linliu-code (via GitHub)" <gi...@apache.org> on 2025/01/16 19:06:41 UTC
[PR] [HUDI-7656] Fix a flaky test for concurrent writes [hudi]
linliu-code opened a new pull request, #12655:
URL: https://github.com/apache/hudi/pull/12655
### Change Logs
Make sure the conflict happens.
### Impact
Fix a flaky test
### Risk level (write none, low medium or high below)
None.
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7656] Fix a flaky test for concurrent writes [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12655:
URL: https://github.com/apache/hudi/pull/12655#issuecomment-2597365317
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15901e2018f75583c1a7640c1f1484338ac4cb38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2904",
"triggerID" : "15901e2018f75583c1a7640c1f1484338ac4cb38",
"triggerType" : "PUSH"
}, {
"hash" : "4e1995209ae2d7e00919304f67121b134d204074",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4e1995209ae2d7e00919304f67121b134d204074",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 15901e2018f75583c1a7640c1f1484338ac4cb38 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2904)
* 4e1995209ae2d7e00919304f67121b134d204074 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7656] Fix a flaky test for concurrent writes [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #12655:
URL: https://github.com/apache/hudi/pull/12655#discussion_r1919422219
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala:
##########
@@ -690,7 +690,7 @@ class TestCOWDataSource extends HoodieSparkClientTestBase with ScalaAssertionSup
class UpdateThread(dataGen: HoodieTestDataGenerator, spark: SparkSession, commonOpts: Map[String, String], basePath: String,
instantTime: String, countDownLatch: CountDownLatch, numRetries: Integer = 0) extends Runnable {
override def run() {
- val updateRecs = recordsToStrings(dataGen.generateUniqueUpdates(instantTime, 500)).asScala.toList
+ val updateRecs = recordsToStrings(dataGen.generateUniqueUpdates(instantTime, 550)).asScala.toList
Review Comment:
This guarantees on the intersection, since the updates are unique record keys among initial 1000 record keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7656] Fix a flaky test for concurrent writes [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12655:
URL: https://github.com/apache/hudi/pull/12655#issuecomment-2596571951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15901e2018f75583c1a7640c1f1484338ac4cb38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2904",
"triggerID" : "15901e2018f75583c1a7640c1f1484338ac4cb38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 15901e2018f75583c1a7640c1f1484338ac4cb38 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2904)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7656] Fix a flaky test for concurrent writes [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12655:
URL: https://github.com/apache/hudi/pull/12655#issuecomment-2597470668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15901e2018f75583c1a7640c1f1484338ac4cb38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2904",
"triggerID" : "15901e2018f75583c1a7640c1f1484338ac4cb38",
"triggerType" : "PUSH"
}, {
"hash" : "4e1995209ae2d7e00919304f67121b134d204074",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2918",
"triggerID" : "4e1995209ae2d7e00919304f67121b134d204074",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4e1995209ae2d7e00919304f67121b134d204074 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2918)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7656] Fix a flaky test for concurrent writes [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12655:
URL: https://github.com/apache/hudi/pull/12655#issuecomment-2597366472
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15901e2018f75583c1a7640c1f1484338ac4cb38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2904",
"triggerID" : "15901e2018f75583c1a7640c1f1484338ac4cb38",
"triggerType" : "PUSH"
}, {
"hash" : "4e1995209ae2d7e00919304f67121b134d204074",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2918",
"triggerID" : "4e1995209ae2d7e00919304f67121b134d204074",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 15901e2018f75583c1a7640c1f1484338ac4cb38 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2904)
* 4e1995209ae2d7e00919304f67121b134d204074 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2918)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7656] Fix a flaky test for concurrent writes [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #12655:
URL: https://github.com/apache/hudi/pull/12655#discussion_r1919506995
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala:
##########
@@ -690,7 +690,7 @@ class TestCOWDataSource extends HoodieSparkClientTestBase with ScalaAssertionSup
class UpdateThread(dataGen: HoodieTestDataGenerator, spark: SparkSession, commonOpts: Map[String, String], basePath: String,
instantTime: String, countDownLatch: CountDownLatch, numRetries: Integer = 0) extends Runnable {
override def run() {
- val updateRecs = recordsToStrings(dataGen.generateUniqueUpdates(instantTime, 500)).asScala.toList
+ val updateRecs = recordsToStrings(dataGen.generateUniqueUpdates(instantTime, 550)).asScala.toList
Review Comment:
Ok, shared update records are passed instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7656] Fix a flaky test for concurrent writes [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12655:
URL: https://github.com/apache/hudi/pull/12655#issuecomment-2596895160
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15901e2018f75583c1a7640c1f1484338ac4cb38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2904",
"triggerID" : "15901e2018f75583c1a7640c1f1484338ac4cb38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 15901e2018f75583c1a7640c1f1484338ac4cb38 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2904)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7656] Fix a flaky test for concurrent writes [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #12655:
URL: https://github.com/apache/hudi/pull/12655#discussion_r1919408669
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala:
##########
@@ -690,7 +690,7 @@ class TestCOWDataSource extends HoodieSparkClientTestBase with ScalaAssertionSup
class UpdateThread(dataGen: HoodieTestDataGenerator, spark: SparkSession, commonOpts: Map[String, String], basePath: String,
instantTime: String, countDownLatch: CountDownLatch, numRetries: Integer = 0) extends Runnable {
override def run() {
- val updateRecs = recordsToStrings(dataGen.generateUniqueUpdates(instantTime, 500)).asScala.toList
+ val updateRecs = recordsToStrings(dataGen.generateUniqueUpdates(instantTime, 550)).asScala.toList
Review Comment:
This still does not guarantee intersection of updates. Could you prepare the updates so that they contain the same record key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7656] Fix a flaky test for concurrent writes [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12655:
URL: https://github.com/apache/hudi/pull/12655#issuecomment-2596565652
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15901e2018f75583c1a7640c1f1484338ac4cb38",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "15901e2018f75583c1a7640c1f1484338ac4cb38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 15901e2018f75583c1a7640c1f1484338ac4cb38 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7656] Fix a flaky test for concurrent writes [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #12655:
URL: https://github.com/apache/hudi/pull/12655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org