[GitHub] dawidwys commented on a change in pull request #7621: [FLINK-11451][table] move *QueryConfig and TableDescriptor to flink-table-api-java

[GitBox <gi...@apache.org>]

dawidwys commented on a change in pull request #7621: [FLINK-11451][table] move *QueryConfig and TableDescriptor to flink-table-api-java
URL: https://github.com/apache/flink/pull/7621#discussion_r252969750
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/descriptors/TableDescriptor.java
 ##########
 @@ -16,9 +16,14 @@
  * limitations under the License.
  */
 
-package org.apache.flink.table.descriptors
+package org.apache.flink.table.descriptors;
+
+import org.apache.flink.annotation.PublicEvolving;
 
 /**
   * Common class for all descriptors describing table sources and sinks.
   */
-abstract class TableDescriptor extends DescriptorBase
+@PublicEvolving
+public abstract class TableDescriptor extends DescriptorBase {
 
 Review comment:
   Just a thought. How about we convert it to interface? That means converting `DescriptorBase` to interface as well. What do you think @twalthr about it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services