You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2011/12/19 00:04:53 UTC

DO NOT REPLY [Bug 52354] New: Protect concurrent accesses to field "org.apache.catalina.tribes.transport.bio.util.FastQueue.inRemove"

https://issues.apache.org/bugzilla/show_bug.cgi?id=52354

             Bug #: 52354
           Summary: Protect concurrent accesses to field
                    "org.apache.catalina.tribes.transport.bio.util.FastQue
                    ue.inRemove"
           Product: Tomcat 7
           Version: trunk
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: reprogrammer@gmail.com
    Classification: Unclassified


Field "org.apache.catalina.tribes.transport.bio.util.FastQueue.inRemove" may be
read and written in parallel. Thus, accesses to it should be synchronized. The
following is a sequence of method calls from the "run" method of a class that
implements "Runnable" to a method that accesses "FastQueue.inRemove" without
proper synchronization.

1.
org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.run()
2.
org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.removeFromQueue()
3. org.apache.catalina.tribes.transport.bio.util.FastQueue.remove()

Field "FastQueue.inRemove" is declared at
<http://svn.apache.org/repos/asf/!svn/bc/1220560/tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/FastQueue.java>.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 52354] Protect concurrent accesses to field "org.apache.catalina.tribes.transport.bio.util.FastQueue.inRemove"

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52354

Mohsen Vakilian <re...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |reprogrammer@gmail.com

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 52354] Protect concurrent accesses to field "org.apache.catalina.tribes.transport.bio.util.FastQueue.inRemove"

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52354

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Mark Thomas <ma...@apache.org> 2011-12-23 21:17:24 UTC ---
Fixed in trunk and 7.0.x and will be included in 7.0.24 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 52354] Protect concurrent accesses to field "org.apache.catalina.tribes.transport.bio.util.FastQueue.inRemove"

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52354

--- Comment #3 from Mohsen Vakilian <re...@gmail.com> 2011-12-24 00:10:25 UTC ---
Thanks for resolving the visibility issue. Keshmesh
<http://keshmesh.cs.illinois.edu/> detected this problem when we ran it on
Tomcat using method
"org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.run()"
as an entry point.

(In reply to comment #2)
> Fixed in trunk and 7.0.x and will be included in 7.0.24 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 52354] Protect concurrent accesses to field "org.apache.catalina.tribes.transport.bio.util.FastQueue.inRemove"

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52354

--- Comment #1 from Mark Thomas <ma...@apache.org> 2011-12-23 21:06:21 UTC ---
There is a concurrency issue but not the one described here. Access to that
field is protected by an exclusive lock. It does however need to be volatile.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org