You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/04 13:42:20 UTC
[GitHub] [flink] zentol opened a new pull request, #19356: [FLINK-26993][tests] Wait until checkpoint was actually triggered
zentol opened a new pull request, #19356:
URL: https://github.com/apache/flink/pull/19356
This is a rather crude fix :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a diff in pull request #19356: [FLINK-26993][tests] Wait until checkpoint was actually triggered
Posted by GitBox <gi...@apache.org>.
pnowojski commented on code in PR #19356:
URL: https://github.com/apache/flink/pull/19356#discussion_r844806467
##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java:
##########
@@ -388,8 +388,9 @@ public void testMinCheckpointPause() throws Exception {
coordinator.triggerCheckpoint(
true); // enqueue and later see if it gets executed in the middle of
// receiveAcknowledgeMessage
- while (coordinator.getNumberOfPendingCheckpoints()
- == 0) { // wait for at least 1 request to be fully processed
+ while (coordinator.getPendingCheckpoints().values().stream()
+ .noneMatch(pc -> pc.getCheckpointStorageLocation() != null)) {
+ // wait for at least 1 request to be fully processed
Review Comment:
Can you add a comment above why do we need this hacky check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #19356: [FLINK-26993][tests] Wait until checkpoint was actually triggered
Posted by GitBox <gi...@apache.org>.
zentol merged PR #19356:
URL: https://github.com/apache/flink/pull/19356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19356: [FLINK-26993][tests] Wait until checkpoint was actually triggered
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19356:
URL: https://github.com/apache/flink/pull/19356#issuecomment-1087584893
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a561e7d0e90e337b9d28f2b2abf9f0e8e8863515",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a561e7d0e90e337b9d28f2b2abf9f0e8e8863515",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a561e7d0e90e337b9d28f2b2abf9f0e8e8863515 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19356: [FLINK-26993][tests] Wait until checkpoint was actually triggered
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19356:
URL: https://github.com/apache/flink/pull/19356#issuecomment-1091298725
> Can you also post an example stack trace in the Jira ticket
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #19356: [FLINK-26993][tests] Wait until checkpoint was actually triggered
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #19356:
URL: https://github.com/apache/flink/pull/19356#discussion_r844859983
##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java:
##########
@@ -388,8 +388,9 @@ public void testMinCheckpointPause() throws Exception {
coordinator.triggerCheckpoint(
true); // enqueue and later see if it gets executed in the middle of
// receiveAcknowledgeMessage
- while (coordinator.getNumberOfPendingCheckpoints()
- == 0) { // wait for at least 1 request to be fully processed
+ while (coordinator.getPendingCheckpoints().values().stream()
+ .noneMatch(pc -> pc.getCheckpointStorageLocation() != null)) {
+ // wait for at least 1 request to be fully processed
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org