You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/08/19 22:18:42 UTC

[GitHub] [trafficserver] shinrich opened a new pull request #7128: Protect TSActionCancel from null INKContInternal actions

shinrich opened a new pull request #7128:
URL: https://github.com/apache/trafficserver/pull/7128


   
   This closes issue #7127 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] zwoop commented on pull request #7128: Protect TSActionCancel from null INKContInternal actions

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7128:
URL: https://github.com/apache/trafficserver/pull/7128#issuecomment-681124843


   Cherry-picked to v9.0.x branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] shinrich commented on pull request #7128: Protect TSActionCancel from null INKContInternal actions

Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7128:
URL: https://github.com/apache/trafficserver/pull/7128#issuecomment-677654475


   True.  Should add a null check too.  Our plugin code was doing a null check before calling TSActionCancel.  It is easy for the plugin to check null, but it would be more unusual for the plugin to check that the action is not equal to 1.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] zwoop merged pull request #7128: Protect TSActionCancel from null INKContInternal actions

Posted by GitBox <gi...@apache.org>.
zwoop merged pull request #7128:
URL: https://github.com/apache/trafficserver/pull/7128


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] randall commented on pull request #7128: Protect TSActionCancel from null INKContInternal actions

Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7128:
URL: https://github.com/apache/trafficserver/pull/7128#issuecomment-678344106


   [approve ci docs]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] randall removed a comment on pull request #7128: Protect TSActionCancel from null INKContInternal actions

Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #7128:
URL: https://github.com/apache/trafficserver/pull/7128#issuecomment-678344106


   [approve ci docs]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] shinrich edited a comment on pull request #7128: Protect TSActionCancel from null INKContInternal actions

Posted by GitBox <gi...@apache.org>.
shinrich edited a comment on pull request #7128:
URL: https://github.com/apache/trafficserver/pull/7128#issuecomment-677654475


   True.  Should add a null check too.  Our plugin code was doing a null check before calling TSActionCancel.  It is easy for the plugin to check null, but it would be more unusual for the plugin to check that the action is not equal to 1.
   
   Updated PR to add the straight null check.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] maskit commented on pull request #7128: Protect TSActionCancel from null INKContInternal actions

Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7128:
URL: https://github.com/apache/trafficserver/pull/7128#issuecomment-676969225


   We want to avoid crashes only if (null) action is associated with an InkContInternal continuation? Passing a simple null would crash on calling `cancel()`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org