DO NOT REPLY [Bug 26457] New: - offer ActionErrors.addAll(ActionErrors errors)

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26457>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26457

offer ActionErrors.addAll(ActionErrors errors)

           Summary: offer ActionErrors.addAll(ActionErrors errors)
           Product: Struts
           Version: 1.1 Final
          Platform: Other
               URL: http://cvs.apache.org/viewcvs.cgi/jakarta-
                    struts/src/share/org/apache/struts/action/ActionErrors.j
                    ava?rev=1.15&view=markup
        OS/Version: Other
            Status: NEW
          Severity: Enhancement
          Priority: Other
         Component: Validator Framework
        AssignedTo: struts-dev@jakarta.apache.org
        ReportedBy: hauser@acm.org


It may occurr that using ValidatorForm.validate(mapping, request);
is not the first validation I do in my form, but I may have others that are even
more important to execute before.

This may lead to the situation that I end up with multiple sets of ActionErrors.

How would one merge those best?
>From looking at the source of ActionErrors.java as per the above URL and
ActionMessages.java 1.17, it appears that ActionMessages.add(ActionMessages
messages) does exactly what I need.

If so, perhaps the javadoc could be extended to make this more obvious to the user?
Or, since those who use an IDE with the binary jars and did not link the source
to it, perhaps

in ActionErrors.java, add

public boolean addAll(ActionErrors errors) {
   super.add(errors);
   return true;
   // perhaps one day super may also fail?
}

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org