You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/04 16:32:59 UTC
[GitHub] [tvm] ashutosh-arm commented on a change in pull request #9338: [4a/10] [CMSIS-NN] Calculate CMSIS-NN buffer size with respect to architecture extensions
ashutosh-arm commented on a change in pull request #9338:
URL: https://github.com/apache/tvm/pull/9338#discussion_r778221116
##########
File path: tests/cpp/relay/backend/contrib/cmsisnn/buffer_size_test.cc
##########
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifdef TVM_USE_CMSISNN
+
+#include "../../../../../../src/relay/backend/contrib/cmsisnn/buffer_size.h"
+
+#include <gtest/gtest.h>
+#include <tvm/ir/transform.h>
+
+#include <cmath>
+#include <random>
+#include <string>
+
+#include "../../../../../../src/relay/backend/contrib/cmsisnn/compiler_attrs.h"
+
+namespace tvm {
+namespace relay {
+namespace contrib {
+namespace cmsisnn {
+
+static std::random_device rd;
+static std::mt19937 gen(rd());
+static std::uniform_int_distribution<> fake_parameters(1, 100);
+
+class CMSISNNCalculatedBufferSize : public testing::TestWithParam<std::array<int32_t, 3>> {};
+
+TEST(CMSISNNConv2dBufferSize, Conv1x1) {
+ int32_t any = fake_parameters(gen);
+ auto conv2d_1x1 = [=](CMSISNNFlags flags, int32_t input_c) {
+ return Conv2dBufferSize(flags, 0, 0, any, any, input_c, any, any, 1, 1, 1, 1);
+ };
+
+ ASSERT_EQ(conv2d_1x1(kNoExt, 4), 0);
+ ASSERT_EQ(conv2d_1x1(kNoExt, 8), 0);
+ ASSERT_EQ(conv2d_1x1(kNoExt, 12), 0);
+ ASSERT_EQ(conv2d_1x1(kNoExt, 16), 0);
+ ASSERT_EQ(conv2d_1x1(kNoExt, 32), 0);
+
+ ASSERT_EQ(conv2d_1x1(kHasDSP, 4), 0);
+ ASSERT_EQ(conv2d_1x1(kHasDSP, 8), 0);
+ ASSERT_EQ(conv2d_1x1(kHasDSP, 12), 0);
+ ASSERT_EQ(conv2d_1x1(kHasDSP, 16), 0);
+ ASSERT_EQ(conv2d_1x1(kHasDSP, 32), 0);
+
+ ASSERT_EQ(conv2d_1x1(kHasMVE, 4), 0);
+ ASSERT_EQ(conv2d_1x1(kHasMVE, 8), 0);
+ ASSERT_EQ(conv2d_1x1(kHasMVE, 12), 0);
+ ASSERT_EQ(conv2d_1x1(kHasMVE, 16), 0);
+ ASSERT_EQ(conv2d_1x1(kHasMVE, 32), 0);
+}
+
+TEST(CMSISNNConv2dBufferSize, Conv1xN) {
+ int32_t any = fake_parameters(gen);
+ int32_t input_c = fake_parameters(gen);
+ int32_t filter_w = fake_parameters(gen);
+ int32_t filter_h = 1;
+ int32_t calculated_buffer = (2 * input_c * filter_w * filter_h) * (int32_t)sizeof(int16_t);
+
+ auto conv2d_1xn = [=](CMSISNNFlags flags, int32_t output_w) {
+ return Conv2dBufferSize(flags, any, any, 1, 1, input_c, 1, output_w, any, any, filter_w,
+ filter_h);
+ };
+
+ ASSERT_EQ(conv2d_1xn(kNoExt, 4), 0);
+ ASSERT_EQ(conv2d_1xn(kNoExt, 8), 0);
+ ASSERT_EQ(conv2d_1xn(kNoExt, 12), 0);
+ ASSERT_EQ(conv2d_1xn(kNoExt, 16), 0);
+ ASSERT_EQ(conv2d_1xn(kNoExt, 32), 0);
+
+ ASSERT_EQ(conv2d_1xn(kHasDSP, 4), calculated_buffer);
+ ASSERT_EQ(conv2d_1xn(kHasDSP, 8), calculated_buffer);
+ ASSERT_EQ(conv2d_1xn(kHasDSP, 12), calculated_buffer);
+ ASSERT_EQ(conv2d_1xn(kHasDSP, 16), calculated_buffer);
+ ASSERT_EQ(conv2d_1xn(kHasDSP, 32), calculated_buffer);
+
+ ASSERT_EQ(conv2d_1xn(kHasMVE, 4), 0);
+ ASSERT_EQ(conv2d_1xn(kHasMVE, 8), 0);
+ ASSERT_EQ(conv2d_1xn(kHasMVE, 12), 0);
+ ASSERT_EQ(conv2d_1xn(kHasMVE, 16), 0);
+ ASSERT_EQ(conv2d_1xn(kHasMVE, 32), 0);
+}
+
+TEST(CMSISNNConv2dBufferSize, Default) {
+ int32_t any = fake_parameters(gen);
+
+ int32_t input_c = fake_parameters(gen);
+ int32_t filter_w = fake_parameters(gen);
+ int32_t filter_h = fake_parameters(gen);
+ int32_t calculated_buffer = (2 * input_c * filter_w * filter_h) * (int32_t)sizeof(int16_t);
+
+ auto conv2d = [=](CMSISNNFlags flags, int32_t output_w) {
+ return Conv2dBufferSize(flags, any, any, 1, 1, input_c, 1, output_w, any, any, filter_w,
+ filter_h);
+ };
+
+ ASSERT_EQ(conv2d(kNoExt, 4), 0);
+ ASSERT_EQ(conv2d(kNoExt, 8), 0);
+ ASSERT_EQ(conv2d(kNoExt, 12), 0);
+ ASSERT_EQ(conv2d(kNoExt, 16), 0);
+ ASSERT_EQ(conv2d(kNoExt, 32), 0);
+
+ ASSERT_EQ(conv2d(kHasDSP, 4), calculated_buffer);
+ ASSERT_EQ(conv2d(kHasDSP, 8), calculated_buffer);
+ ASSERT_EQ(conv2d(kHasDSP, 12), calculated_buffer);
+ ASSERT_EQ(conv2d(kHasDSP, 16), calculated_buffer);
+ ASSERT_EQ(conv2d(kHasDSP, 32), calculated_buffer);
+
+ ASSERT_EQ(conv2d(kHasMVE, 4), calculated_buffer);
+ ASSERT_EQ(conv2d(kHasMVE, 8), calculated_buffer);
+ ASSERT_EQ(conv2d(kHasMVE, 12), calculated_buffer);
+ ASSERT_EQ(conv2d(kHasMVE, 16), calculated_buffer);
+ ASSERT_EQ(conv2d(kHasMVE, 32), calculated_buffer);
+}
+
+TEST(CMSISNNDepthwiseConv2dBufferSize, UnEvenChannels) {
+ int32_t filter_w = fake_parameters(gen);
+ int32_t filter_h = fake_parameters(gen);
+ int32_t input_n = 1;
+
+ auto depthwise_conv2d_with_channels = [=](CMSISNNFlags flags, int32_t input_c, int32_t output_c) {
+ return DepthwiseConv2dBufferSize(flags, input_n, input_c, output_c, filter_w, filter_h);
+ };
+
+ ASSERT_EQ(depthwise_conv2d_with_channels(kNoExt, 4, 6), 0);
+ ASSERT_EQ(depthwise_conv2d_with_channels(kNoExt, 8, 7), 0);
+ ASSERT_EQ(depthwise_conv2d_with_channels(kHasDSP, 4, 6), 0);
+ ASSERT_EQ(depthwise_conv2d_with_channels(kHasDSP, 8, 7), 0);
+ ASSERT_EQ(depthwise_conv2d_with_channels(kHasMVE, 4, 6), 0);
+ ASSERT_EQ(depthwise_conv2d_with_channels(kHasMVE, 8, 7), 0);
Review comment:
I like it that you have included multiples of 4 cases here for channel :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org