You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/06/03 06:33:38 UTC
Re: Review Request 21787: Keep track of the principals for authenticated
pids in Master and verify FramworkInfo::principal during (re-)registration.
> On May 22, 2014, 10:37 a.m., Dominic Hamon wrote:
> > src/master/master.cpp, line 1070
> > <https://reviews.apache.org/r/21787/diff/1/?file=586808#file586808line1070>
> >
> > pull this out into a common method please to save duplication of logic.
>
> Jiang Yan Xu wrote:
> Such duplication already exists in between registerFramework and reregisterFramework. I will submit a separate patch for this purpose.
This comment is addressed at: https://reviews.apache.org/r/22162
Thanks Dominic!
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21787/#review43733
-----------------------------------------------------------
On May 22, 2014, 1:08 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21787/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 1:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1373
> https://issues.apache.org/jira/browse/MESOS-1373
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This will be used to 'Add "per-framework-principal" counters for all messages from a scheduler on Master': https://issues.apache.org/jira/browse/MESOS-1339
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto ce780ca5c6d288def73a1f5cb956fcdc2693fc96
> src/master/master.hpp 99c70631ba10e8811ab0011881f30134c4d0373c
> src/master/master.cpp e5d8edf4db932e2c48756df67750b02bbff59c55
> src/tests/authentication_tests.cpp b60e595216c2b854adf048002a0d88b548e1d92e
> src/tests/mesos.hpp a1a7d7991c4cdb7a994218602fe4e5d76c056456
>
> Diff: https://reviews.apache.org/r/21787/diff/
>
>
> Testing
> -------
>
> Added tests. Make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>