You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Alanxtl (via GitHub)" <gi...@apache.org> on 2025/07/08 12:23:37 UTC
[PR] feat: replace `filter/polaris/limit` use of config package [dubbo-go]
Alanxtl opened a new pull request, #2947:
URL: https://github.com/apache/dubbo-go/pull/2947
#2741
- `filter/polaris/limit` previous depends on config package, this pr replace it with `url.GetParam`.
- minor improvements to comments and code clarity are included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#issuecomment-3162261398
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2947) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2947&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2947&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2947&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2947&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2947&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl closed pull request #2947: refactor: replace `filter/polaris/limit` use of config package
URL: https://github.com/apache/dubbo-go/pull/2947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#discussion_r2268824656
##########
filter/polaris/limit/limiter.go:
##########
@@ -74,40 +74,52 @@ func (pl *polarisTpsLimiter) IsAllowable(url *common.URL, invocation base.Invoca
return resp.Get().Code == model.QuotaResultOk
}
-func (pl *polarisTpsLimiter) buildQuotaRequest(url *common.URL, invoaction base.Invocation) polaris.QuotaRequest {
+func (pl *polarisTpsLimiter) buildQuotaRequest(url *common.URL, invocation base.Invocation) polaris.QuotaRequest {
ns := remotingpolaris.GetNamespace()
applicationMode := false
+
+ // TODO: only for compatibility with old config, able to directly remove after config is deleted
for _, item := range config.GetRootConfig().Registries {
if item.Protocol == constant.PolarisKey {
applicationMode = item.RegistryType == constant.ServiceKey
}
}
Review Comment:
Will deleting these lines of code have any impact? Will it affect compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#issuecomment-3157566973
this PR seems to have nothing to do with metadata. Why did you modify the metadata code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on code in PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#discussion_r2269125502
##########
filter/polaris/limit/limiter.go:
##########
@@ -74,40 +74,52 @@ func (pl *polarisTpsLimiter) IsAllowable(url *common.URL, invocation base.Invoca
return resp.Get().Code == model.QuotaResultOk
}
-func (pl *polarisTpsLimiter) buildQuotaRequest(url *common.URL, invoaction base.Invocation) polaris.QuotaRequest {
+func (pl *polarisTpsLimiter) buildQuotaRequest(url *common.URL, invocation base.Invocation) polaris.QuotaRequest {
ns := remotingpolaris.GetNamespace()
applicationMode := false
+
+ // TODO: only for compatibility with old config, able to directly remove after config is deleted
for _, item := range config.GetRootConfig().Registries {
if item.Protocol == constant.PolarisKey {
applicationMode = item.RegistryType == constant.ServiceKey
}
}
Review Comment:
these lines are used to compatible with old API. If remove, old API related to this part will be invalid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#issuecomment-3178323550
> this PR seems to have nothing to do with metadata. Why did you modify the metadata code?
all metadata related modify have been removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#issuecomment-3083000850
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2947) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2947&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2947&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2947&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2947&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2947&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#issuecomment-3050778820
good work. hope you add some unit tests for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "marsevilspirit (via GitHub)" <gi...@apache.org>.
marsevilspirit commented on PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#issuecomment-3050788112
Need more information, why add RegistryType, why expose two APIs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "marsevilspirit (via GitHub)" <gi...@apache.org>.
marsevilspirit merged PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#discussion_r2255969757
##########
metadata/options.go:
##########
@@ -107,7 +107,8 @@ func WithMetadataProtocol(protocol string) Option {
}
type ReportOptions struct {
- registryId string
+ registryId string
+ registryType string
Review Comment:
What are the uses of these two fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#discussion_r2268824656
##########
filter/polaris/limit/limiter.go:
##########
@@ -74,40 +74,52 @@ func (pl *polarisTpsLimiter) IsAllowable(url *common.URL, invocation base.Invoca
return resp.Get().Code == model.QuotaResultOk
}
-func (pl *polarisTpsLimiter) buildQuotaRequest(url *common.URL, invoaction base.Invocation) polaris.QuotaRequest {
+func (pl *polarisTpsLimiter) buildQuotaRequest(url *common.URL, invocation base.Invocation) polaris.QuotaRequest {
ns := remotingpolaris.GetNamespace()
applicationMode := false
+
+ // TODO: only for compatibility with old config, able to directly remove after config is deleted
for _, item := range config.GetRootConfig().Registries {
if item.Protocol == constant.PolarisKey {
applicationMode = item.RegistryType == constant.ServiceKey
}
}
Review Comment:
Will deleting these lines of code have any impact? Will it affect compatibility? if not I think we can delete it directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#discussion_r2268820238
##########
filter/polaris/limit/limiter.go:
##########
@@ -74,40 +74,52 @@ func (pl *polarisTpsLimiter) IsAllowable(url *common.URL, invocation base.Invoca
return resp.Get().Code == model.QuotaResultOk
}
-func (pl *polarisTpsLimiter) buildQuotaRequest(url *common.URL, invoaction base.Invocation) polaris.QuotaRequest {
+func (pl *polarisTpsLimiter) buildQuotaRequest(url *common.URL, invocation base.Invocation) polaris.QuotaRequest {
ns := remotingpolaris.GetNamespace()
applicationMode := false
+
+ // TODO: only for compatibility with old config, able to directly remove after config is deleted
for _, item := range config.GetRootConfig().Registries {
if item.Protocol == constant.PolarisKey {
applicationMode = item.RegistryType == constant.ServiceKey
}
}
Review Comment:
If these lines of code are useless, they can be deleted, and the purpose of this PR is to replace the config package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on code in PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#discussion_r2269125502
##########
filter/polaris/limit/limiter.go:
##########
@@ -74,40 +74,52 @@ func (pl *polarisTpsLimiter) IsAllowable(url *common.URL, invocation base.Invoca
return resp.Get().Code == model.QuotaResultOk
}
-func (pl *polarisTpsLimiter) buildQuotaRequest(url *common.URL, invoaction base.Invocation) polaris.QuotaRequest {
+func (pl *polarisTpsLimiter) buildQuotaRequest(url *common.URL, invocation base.Invocation) polaris.QuotaRequest {
ns := remotingpolaris.GetNamespace()
applicationMode := false
+
+ // TODO: only for compatibility with old config, able to directly remove after config is deleted
for _, item := range config.GetRootConfig().Registries {
if item.Protocol == constant.PolarisKey {
applicationMode = item.RegistryType == constant.ServiceKey
}
}
Review Comment:
these lines are used to compatible with old API, if remove old API related to this part will be invalid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "1kasa (via GitHub)" <gi...@apache.org>.
1kasa commented on PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#issuecomment-3066698020
> > Need more information, why add RegistryType, why expose two APIs?需要更多信息，为什么添加 RegistryType，为什么暴露两个 API？
>
> 1. Why expose two APIs 为什么暴露两个 API
> According to polaris previous implementation, `RegistryType` has two types `service` and `interface`, and we already have `WithRegisterInterface()` in `registry/options.go:186` which set `RegistryType` to `interface`. But we don't have `WithRegisterService()` to set RegistryType to `service`, so I expose it.根据 Polaris 之前的实现， `RegistryType` 有两种类型 `service` 和 `interface` ，我们在 `registry/options.go:186` 中已经有了 `WithRegisterInterface()` ，它将 `RegistryType` 设置为 `interface` 。但我们没有 `WithRegisterService()` 来将 RegistryType 设置为 `service` ，所以我将其公开。
> And I add `WithRegistryType()` because the registryType imformation won't be Report previous我添加 `WithRegistryType()` 是因为 registryType 信息不会报告之前
> 2. Why add RegistryType 为什么要添加 RegistryType
> Because `polaris tps limiter`'s behaviour vairous when get different type of `RegistryType`, and previous implemention gets `RegistryType` from `root_config`, in order to replace the use of `config`, We need to transfer `RegistryType` in `url` so I add it.因为 `polaris tps limiter` 在不同类型的 `RegistryType` 获取时的行为不同，而之前的实现从 `root_config` 获取 `RegistryType` ，为了替换 `config` 的使用，我们需要在 `url` 中转移 `RegistryType` ，所以我添加了它。
Can you provide me with some test code? Is it convenient for us to verify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#issuecomment-3067031936
> > > Need more information, why add RegistryType, why expose two APIs?需要更多信息，为什么添加 RegistryType，为什么暴露两个 API？
> >
> >
> >
> > 1. Why expose two APIs 为什么暴露两个 API
> > According to polaris previous implementation, `RegistryType` has two types `service` and `interface`, and we already have `WithRegisterInterface()` in `registry/options.go:186` which set `RegistryType` to `interface`. But we don't have `WithRegisterService()` to set RegistryType to `service`, so I expose it.根据 Polaris 之前的实现， `RegistryType` 有两种类型 `service` 和 `interface` ，我们在 `registry/options.go:186` 中已经有了 `WithRegisterInterface()` ，它将 `RegistryType` 设置为 `interface` 。但我们没有 `WithRegisterService()` 来将 RegistryType 设置为 `service` ，所以我将其公开。
> > And I add `WithRegistryType()` because the registryType imformation won't be Report previous我添加 `WithRegistryType()` 是因为 registryType 信息不会报告之前
> > 2. Why add RegistryType 为什么要添加 RegistryType
> > Because `polaris tps limiter`'s behaviour vairous when get different type of `RegistryType`, and previous implemention gets `RegistryType` from `root_config`, in order to replace the use of `config`, We need to transfer `RegistryType` in `url` so I add it.因为 `polaris tps limiter` 在不同类型的 `RegistryType` 获取时的行为不同，而之前的实现从 `root_config` 获取 `RegistryType` ，为了替换 `config` 的使用，我们需要在 `url` 中转移 `RegistryType` ，所以我添加了它。
>
> Can you provide me with some test code? Is it convenient for us to verify
done, see https://github.com/apache/dubbo-go-samples/pull/868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#issuecomment-3048730654
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2947) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2947&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2947&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2947&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2947&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2947&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#issuecomment-3050961260
> Need more information, why add RegistryType, why expose two APIs?
1. Why expose two APIs
According to polaris previous implementation, `RegistryType` has two types `service` and `interface`, and we already have `WithRegisterInterface()` in `registry/options.go:186` which set `RegistryType` to `interface`. But we don't have `WithRegisterService()` to set RegistryType to `service`, so I expose it.
And I add `WithRegistryType()` because the registryType imformation won't be Report previous
2. Why add RegistryType
Because `polaris tps limiter`'s behaviour vairous when get different type of `RegistryType`, and previous implemention gets `RegistryType` from `root_config`, in order to replace the use of `config`, We need to transfer `RegistryType` in `url` so I add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#issuecomment-3162250948
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2947) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2947&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2947&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2947&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2947&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2947&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] refactor: replace `filter/polaris/limit` use of config package [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#issuecomment-3162288132
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2947) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2947&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2947&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2947&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2947&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2947&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org