You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/07/07 18:53:11 UTC

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #6883: Fix t3c cache to invalidate on version change

rob05c commented on code in PR #6883:
URL: https://github.com/apache/trafficcontrol/pull/6883#discussion_r916188417


##########
cache-config/t3cutil/getdata.go:
##########
@@ -54,6 +54,10 @@ type TCCfg struct {
 
 	// OldCfg is the previously fetched ConfigData, for 'config' requests. May be nil.
 	OldCfg *ConfigData
+
+	// T3cVersion is the version of the t3c app ecosystem
+	// This value will be the same for any t3c app.
+	T3CVersion string

Review Comment:
   It doesn't make sense to ever override this. This version is used by the `t3c` app (via library functions later) writing a cache file. 
   
   Its purpose is so a future `t3c` app can read it, compare to its own version, and determine compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org