[GitHub] [dubbo] CrazyHZM commented on a change in pull request #9831: SimpleReferenceCache bug to cause genericInvoke high lantency(fix: #9829)

[GitBox <gi...@apache.org>]

CrazyHZM commented on a change in pull request #9831:
URL: https://github.com/apache/dubbo/pull/9831#discussion_r833879692



##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/utils/SimpleReferenceCache.java
##########
@@ -67,7 +67,7 @@
 
     private final Map<String, List<ReferenceConfigBase<?>>> referenceKeyMap = new ConcurrentHashMap<>();
     private final Map<Class<?>, List<ReferenceConfigBase<?>>> referenceTypeMap = new ConcurrentHashMap<>();
-    private final Map<ReferenceConfigBase<?>, Object> references = new ConcurrentHashMap<>();
+    private final Map<String, Object> references = new ConcurrentHashMap<>();

Review comment:
       @hanl754 
   Agree with @BurningCN , the reason for not changing here is to consider multi-instance scenarios.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org