You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Brian Hulette <bh...@google.com> on 2020/06/01 17:18:25 UTC
Re: 2.22.0 Release Update
I don't think https://issues.apache.org/jira/browse/BEAM-10024
<https://issues.apache.org/jira/browse/BEAM-10024> and
https://issues.apache.org/jira/browse/BEAM-10025 should block the release
since they're not regressions, they're failures in a newly added test that
is misclassified.
Brian
On Sat, May 30, 2020 at 9:43 AM Ismaël Mejía <ie...@gmail.com> wrote:
> Mmm it seems the issue is due to a misclassified test. Kyle opened a
> PR to reclassify it
> It is still not clear to me why the test is changed to be streaming only.
> For info https://issues.apache.org/jira/browse/BEAM-10024
>
> On Sat, May 30, 2020 at 5:51 PM Ismaël Mejía <ie...@gmail.com> wrote:
> >
> > The classic Spark Runner VR tests are failing both in master and
> > 2.22.0 because of some change
> > introduced two weeks ago (and part of 2.22.0), maybe worth to fix this
> > before RC1
> >
> > https://issues.apache.org/jira/browse/BEAM-10015
> >
> https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/7440/testReport/
> >
> > On Fri, May 29, 2020 at 6:32 PM Brian Hulette <bh...@google.com>
> wrote:
> > >
> > > Hi everyone,
> > >
> > > A cherry-pick [1] for the last open release blocker [2] is going in
> now. I'm planning to start work on an RC unless more blockers arise.
> > >
> > > The only other potential blocker I'm aware of is [3], which was raised
> during 2.21 RC voting. Please let me know if you think this should block
> 2.22.
> > >
> > > Brian
> > >
> > > [1] https://github.com/apache/beam/pull/11859
> > > [2] https://issues.apache.org/jira/browse/BEAM-10078
> > > [3] https://github.com/apache/beam/pull/11777
> > >
> > > On Tue, May 26, 2020 at 9:29 AM Steve Niemitz <sn...@apache.org>
> wrote:
> > >>
> > >>
> > >> On Tue, May 26, 2020 at 12:20 PM Brian Hulette <bh...@google.com>
> wrote:
> > >>>
> > >>>
> > >>> On Mon, May 25, 2020 at 1:30 PM Steve Niemitz <sn...@apache.org>
> wrote:
> > >>>>
> > >>>> I tried to validate the release branch on dataflow, but it looks
> like there's no tag yet for the 2.22 docker containers [1]
> > >>>
> > >>>
> > >>> I haven't built any Dataflow containers yet since BEAM-9971 and
> BEAM-10057 are actively being worked on and their PRs will be cherry-picked
> into the release branch.
> > >>
> > >>
> > >> Cool, makes sense! I ended up just using the latest tag and
> supplying my own worker jar to test.
> > >>
> > >>>>
> > >>>> I'm also fairly concerned with the artifact staging regressions
> introduced in BEAM-9383 [2]
> > >>>
> > >>>
> > >>> There are some Jiras related to artifact staging that are currently
> marked as release blockers: BEAM-10077, BEAM-10078. I didn't initially see
> the connection to a regression, but based on your comments it sounds like
> those should in fact be release blockers.
> > >>
> > >>
> > >> It looks like both of these are being worked on now. [3] [4] I agree
> they should be blockers as well.
> > >>
> > >> [3] https://github.com/apache/beam/pull/11814
> > >> [4] https://github.com/apache/beam/pull/11813
> > >>
> > >>>
> > >>>
> > >>>>
> > >>>>
> > >>>> [1]
> https://console.cloud.google.com/gcr/images/cloud-dataflow/GLOBAL/v1beta3/beam-java-streaming?gcrImageListsize=30&gcrImageListquery=%255B%255D
> > >>>> [2]
> https://issues.apache.org/jira/browse/BEAM-9383?focusedCommentId=17116185&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17116185
> > >>>>
> > >>>> On Wed, May 20, 2020 at 10:10 PM Brian Hulette <bh...@google.com>
> wrote:
> > >>>>>
> > >>>>> Hi everyone,
> > >>>>>
> > >>>>> It's time for dueling release branches! The 2.22.0 branch has been
> cut [1].
> > >>>>> - If you notice any release blockers [2] please tag a jira with
> fix version 2.22.0 and cc me (bhulette).
> > >>>>> - Please update the change log [3] with any significant changes if
> you haven't yet. Put up a PR with the change and tag me (@TheNeuralBit on
> github).
> > >>>>>
> > >>>>> Thanks!
> > >>>>> Brian
> > >>>>>
> > >>>>>
> > >>>>> [1] https://github.com/apache/beam/tree/release-2.22.0
> > >>>>> [2] https://beam.apache.org/contribute/release-blocking/
> > >>>>> [3] https://github.com/apache/beam/blob/master/CHANGES.md
>
Re: 2.22.0 Release Update
Posted by Brian Hulette <bh...@google.com>.
Note that we also have https://issues.apache.org/jira/browse/BEAM-10016 and
https://issues.apache.org/jira/browse/BEAM-10094, for another new test
failing on Portable Flink/Spark. Like BEAM-10024 and BEAM-10025 I'd happily
cherry-pick fixes for these since it makes verification easier, but I don't
think we should block the release for them.
Brian
On Mon, Jun 1, 2020 at 11:14 AM Ismaël Mejía <ie...@gmail.com> wrote:
> I agree but having noisey test signals when validating a release does
> not sound also as a good idea.
>
> On Mon, Jun 1, 2020 at 7:18 PM Brian Hulette <bh...@google.com> wrote:
> >
> > I don't think https://issues.apache.org/jira/browse/BEAM-10024 and
> https://issues.apache.org/jira/browse/BEAM-10025 should block the release
> since they're not regressions, they're failures in a newly added test that
> is misclassified.
> >
> > Brian
> >
> > On Sat, May 30, 2020 at 9:43 AM Ismaël Mejía <ie...@gmail.com> wrote:
> >>
> >> Mmm it seems the issue is due to a misclassified test. Kyle opened a
> >> PR to reclassify it
> >> It is still not clear to me why the test is changed to be streaming
> only.
> >> For info https://issues.apache.org/jira/browse/BEAM-10024
> >>
> >> On Sat, May 30, 2020 at 5:51 PM Ismaël Mejía <ie...@gmail.com> wrote:
> >> >
> >> > The classic Spark Runner VR tests are failing both in master and
> >> > 2.22.0 because of some change
> >> > introduced two weeks ago (and part of 2.22.0), maybe worth to fix this
> >> > before RC1
> >> >
> >> > https://issues.apache.org/jira/browse/BEAM-10015
> >> >
> https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/7440/testReport/
> >> >
> >> > On Fri, May 29, 2020 at 6:32 PM Brian Hulette <bh...@google.com>
> wrote:
> >> > >
> >> > > Hi everyone,
> >> > >
> >> > > A cherry-pick [1] for the last open release blocker [2] is going in
> now. I'm planning to start work on an RC unless more blockers arise.
> >> > >
> >> > > The only other potential blocker I'm aware of is [3], which was
> raised during 2.21 RC voting. Please let me know if you think this should
> block 2.22.
> >> > >
> >> > > Brian
> >> > >
> >> > > [1] https://github.com/apache/beam/pull/11859
> >> > > [2] https://issues.apache.org/jira/browse/BEAM-10078
> >> > > [3] https://github.com/apache/beam/pull/11777
> >> > >
> >> > > On Tue, May 26, 2020 at 9:29 AM Steve Niemitz <sn...@apache.org>
> wrote:
> >> > >>
> >> > >>
> >> > >> On Tue, May 26, 2020 at 12:20 PM Brian Hulette <
> bhulette@google.com> wrote:
> >> > >>>
> >> > >>>
> >> > >>> On Mon, May 25, 2020 at 1:30 PM Steve Niemitz <
> sniemitz@apache.org> wrote:
> >> > >>>>
> >> > >>>> I tried to validate the release branch on dataflow, but it looks
> like there's no tag yet for the 2.22 docker containers [1]
> >> > >>>
> >> > >>>
> >> > >>> I haven't built any Dataflow containers yet since BEAM-9971 and
> BEAM-10057 are actively being worked on and their PRs will be cherry-picked
> into the release branch.
> >> > >>
> >> > >>
> >> > >> Cool, makes sense! I ended up just using the latest tag and
> supplying my own worker jar to test.
> >> > >>
> >> > >>>>
> >> > >>>> I'm also fairly concerned with the artifact staging regressions
> introduced in BEAM-9383 [2]
> >> > >>>
> >> > >>>
> >> > >>> There are some Jiras related to artifact staging that are
> currently marked as release blockers: BEAM-10077, BEAM-10078. I didn't
> initially see the connection to a regression, but based on your comments it
> sounds like those should in fact be release blockers.
> >> > >>
> >> > >>
> >> > >> It looks like both of these are being worked on now. [3] [4] I
> agree they should be blockers as well.
> >> > >>
> >> > >> [3] https://github.com/apache/beam/pull/11814
> >> > >> [4] https://github.com/apache/beam/pull/11813
> >> > >>
> >> > >>>
> >> > >>>
> >> > >>>>
> >> > >>>>
> >> > >>>> [1]
> https://console.cloud.google.com/gcr/images/cloud-dataflow/GLOBAL/v1beta3/beam-java-streaming?gcrImageListsize=30&gcrImageListquery=%255B%255D
> >> > >>>> [2]
> https://issues.apache.org/jira/browse/BEAM-9383?focusedCommentId=17116185&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17116185
> >> > >>>>
> >> > >>>> On Wed, May 20, 2020 at 10:10 PM Brian Hulette <
> bhulette@google.com> wrote:
> >> > >>>>>
> >> > >>>>> Hi everyone,
> >> > >>>>>
> >> > >>>>> It's time for dueling release branches! The 2.22.0 branch has
> been cut [1].
> >> > >>>>> - If you notice any release blockers [2] please tag a jira with
> fix version 2.22.0 and cc me (bhulette).
> >> > >>>>> - Please update the change log [3] with any significant changes
> if you haven't yet. Put up a PR with the change and tag me (@TheNeuralBit
> on github).
> >> > >>>>>
> >> > >>>>> Thanks!
> >> > >>>>> Brian
> >> > >>>>>
> >> > >>>>>
> >> > >>>>> [1] https://github.com/apache/beam/tree/release-2.22.0
> >> > >>>>> [2] https://beam.apache.org/contribute/release-blocking/
> >> > >>>>> [3] https://github.com/apache/beam/blob/master/CHANGES.md
>
Re: 2.22.0 Release Update
Posted by Ismaël Mejía <ie...@gmail.com>.
I agree but having noisey test signals when validating a release does
not sound also as a good idea.
On Mon, Jun 1, 2020 at 7:18 PM Brian Hulette <bh...@google.com> wrote:
>
> I don't think https://issues.apache.org/jira/browse/BEAM-10024 and https://issues.apache.org/jira/browse/BEAM-10025 should block the release since they're not regressions, they're failures in a newly added test that is misclassified.
>
> Brian
>
> On Sat, May 30, 2020 at 9:43 AM Ismaël Mejía <ie...@gmail.com> wrote:
>>
>> Mmm it seems the issue is due to a misclassified test. Kyle opened a
>> PR to reclassify it
>> It is still not clear to me why the test is changed to be streaming only.
>> For info https://issues.apache.org/jira/browse/BEAM-10024
>>
>> On Sat, May 30, 2020 at 5:51 PM Ismaël Mejía <ie...@gmail.com> wrote:
>> >
>> > The classic Spark Runner VR tests are failing both in master and
>> > 2.22.0 because of some change
>> > introduced two weeks ago (and part of 2.22.0), maybe worth to fix this
>> > before RC1
>> >
>> > https://issues.apache.org/jira/browse/BEAM-10015
>> > https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/7440/testReport/
>> >
>> > On Fri, May 29, 2020 at 6:32 PM Brian Hulette <bh...@google.com> wrote:
>> > >
>> > > Hi everyone,
>> > >
>> > > A cherry-pick [1] for the last open release blocker [2] is going in now. I'm planning to start work on an RC unless more blockers arise.
>> > >
>> > > The only other potential blocker I'm aware of is [3], which was raised during 2.21 RC voting. Please let me know if you think this should block 2.22.
>> > >
>> > > Brian
>> > >
>> > > [1] https://github.com/apache/beam/pull/11859
>> > > [2] https://issues.apache.org/jira/browse/BEAM-10078
>> > > [3] https://github.com/apache/beam/pull/11777
>> > >
>> > > On Tue, May 26, 2020 at 9:29 AM Steve Niemitz <sn...@apache.org> wrote:
>> > >>
>> > >>
>> > >> On Tue, May 26, 2020 at 12:20 PM Brian Hulette <bh...@google.com> wrote:
>> > >>>
>> > >>>
>> > >>> On Mon, May 25, 2020 at 1:30 PM Steve Niemitz <sn...@apache.org> wrote:
>> > >>>>
>> > >>>> I tried to validate the release branch on dataflow, but it looks like there's no tag yet for the 2.22 docker containers [1]
>> > >>>
>> > >>>
>> > >>> I haven't built any Dataflow containers yet since BEAM-9971 and BEAM-10057 are actively being worked on and their PRs will be cherry-picked into the release branch.
>> > >>
>> > >>
>> > >> Cool, makes sense! I ended up just using the latest tag and supplying my own worker jar to test.
>> > >>
>> > >>>>
>> > >>>> I'm also fairly concerned with the artifact staging regressions introduced in BEAM-9383 [2]
>> > >>>
>> > >>>
>> > >>> There are some Jiras related to artifact staging that are currently marked as release blockers: BEAM-10077, BEAM-10078. I didn't initially see the connection to a regression, but based on your comments it sounds like those should in fact be release blockers.
>> > >>
>> > >>
>> > >> It looks like both of these are being worked on now. [3] [4] I agree they should be blockers as well.
>> > >>
>> > >> [3] https://github.com/apache/beam/pull/11814
>> > >> [4] https://github.com/apache/beam/pull/11813
>> > >>
>> > >>>
>> > >>>
>> > >>>>
>> > >>>>
>> > >>>> [1] https://console.cloud.google.com/gcr/images/cloud-dataflow/GLOBAL/v1beta3/beam-java-streaming?gcrImageListsize=30&gcrImageListquery=%255B%255D
>> > >>>> [2] https://issues.apache.org/jira/browse/BEAM-9383?focusedCommentId=17116185&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17116185
>> > >>>>
>> > >>>> On Wed, May 20, 2020 at 10:10 PM Brian Hulette <bh...@google.com> wrote:
>> > >>>>>
>> > >>>>> Hi everyone,
>> > >>>>>
>> > >>>>> It's time for dueling release branches! The 2.22.0 branch has been cut [1].
>> > >>>>> - If you notice any release blockers [2] please tag a jira with fix version 2.22.0 and cc me (bhulette).
>> > >>>>> - Please update the change log [3] with any significant changes if you haven't yet. Put up a PR with the change and tag me (@TheNeuralBit on github).
>> > >>>>>
>> > >>>>> Thanks!
>> > >>>>> Brian
>> > >>>>>
>> > >>>>>
>> > >>>>> [1] https://github.com/apache/beam/tree/release-2.22.0
>> > >>>>> [2] https://beam.apache.org/contribute/release-blocking/
>> > >>>>> [3] https://github.com/apache/beam/blob/master/CHANGES.md