You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Kanstantsin Shautsou <ka...@gmail.com> on 2016/01/15 12:37:08 UTC
help review/accept [MSHADE-182]
Hi, could somebody help with processing
https://issues.apache.org/jira/browse/MSHADE-182 <https://issues.apache.org/jira/browse/MSHADE-182>
https://github.com/apache/maven-plugins/pull/79 <https://github.com/apache/maven-plugins/pull/79>
Bug exists for 1 year. Everything described in PR and issue.
Re: help review/accept [MSHADE-182]
Posted by Robert Scholte <rf...@apache.org>.
Already figured out the problem with Arnaud. The test must have profiles,
since (only?) MacOS6 has a classes.jar instead of tools.jar
MSHADE-182 already described that in its example, the IT was simplified a
bit too much.
thanks,
Robert
Op Tue, 26 Jan 2016 21:57:54 +0100 schreef Benson Margulies
<bi...@gmail.com>:
> The tools jar is an old standby, do you need someone to fix a pom to
> have the right profile?
>
>
> On Tue, Jan 26, 2016 at 3:34 PM, Arnaud Héritier <ah...@gmail.com>
> wrote:
>> No feedback guys ?
>>
>> On Thu, Jan 21, 2016 at 11:02 PM, Arnaud Héritier <ah...@gmail.com>
>> wrote:
>>
>>> Build (install -Prun-its) of the PR:
>>> Ok with Java 7 and Maven 3.3.9 on MacOS X
>>> Ko with Java 6 and Maven 3.2.5 on MacOS X
>>>
>>> [INFO] Building: MSHADE-185/pom.xml
>>> [INFO] ..FAILED (1.4 s)
>>>
>>> Could not find artifact com.sun:tools:jar:1.6 at specified path
>>> /Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home/../lib/tools.jar
>>>
>>> But the issue is the same for me on master branch thus there is no
>>> regression with the PR
>>>
>>>
>>> On Thu, Jan 21, 2016 at 9:30 PM, Arnaud Héritier <ah...@gmail.com>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> I may try to help but I imagine that it's not only a merge to do.
>>>> I had a look at the current shade build (without your fix) and it is
>>>> failing on another test on MacOS
>>>> Am I the only one ?
>>>>
>>>> Best regards
>>>>
>>>> On Fri, Jan 15, 2016 at 12:37 PM, Kanstantsin Shautsou <
>>>> kanstantsin.sha@gmail.com> wrote:
>>>>
>>>>> Hi, could somebody help with processing
>>>>> https://issues.apache.org/jira/browse/MSHADE-182
>>>>> https://github.com/apache/maven-plugins/pull/79
>>>>>
>>>>> Bug exists for 1 year. Everything described in PR and issue.
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> -----
>>>> Arnaud Héritier
>>>> http://aheritier.net
>>>> Mail/GTalk: aheritier AT gmail DOT com
>>>> Twitter/Skype : aheritier
>>>>
>>>
>>>
>>>
>>> --
>>> -----
>>> Arnaud Héritier
>>> http://aheritier.net
>>> Mail/GTalk: aheritier AT gmail DOT com
>>> Twitter/Skype : aheritier
>>>
>>
>>
>>
>> --
>> -----
>> Arnaud Héritier
>> http://aheritier.net
>> Mail/GTalk: aheritier AT gmail DOT com
>> Twitter/Skype : aheritier
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: help review/accept [MSHADE-182]
Posted by Benson Margulies <bi...@gmail.com>.
The tools jar is an old standby, do you need someone to fix a pom to
have the right profile?
On Tue, Jan 26, 2016 at 3:34 PM, Arnaud Héritier <ah...@gmail.com> wrote:
> No feedback guys ?
>
> On Thu, Jan 21, 2016 at 11:02 PM, Arnaud Héritier <ah...@gmail.com>
> wrote:
>
>> Build (install -Prun-its) of the PR:
>> Ok with Java 7 and Maven 3.3.9 on MacOS X
>> Ko with Java 6 and Maven 3.2.5 on MacOS X
>>
>> [INFO] Building: MSHADE-185/pom.xml
>> [INFO] ..FAILED (1.4 s)
>>
>> Could not find artifact com.sun:tools:jar:1.6 at specified path
>> /Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home/../lib/tools.jar
>>
>> But the issue is the same for me on master branch thus there is no
>> regression with the PR
>>
>>
>> On Thu, Jan 21, 2016 at 9:30 PM, Arnaud Héritier <ah...@gmail.com>
>> wrote:
>>
>>> Hi,
>>>
>>> I may try to help but I imagine that it's not only a merge to do.
>>> I had a look at the current shade build (without your fix) and it is
>>> failing on another test on MacOS
>>> Am I the only one ?
>>>
>>> Best regards
>>>
>>> On Fri, Jan 15, 2016 at 12:37 PM, Kanstantsin Shautsou <
>>> kanstantsin.sha@gmail.com> wrote:
>>>
>>>> Hi, could somebody help with processing
>>>> https://issues.apache.org/jira/browse/MSHADE-182
>>>> https://github.com/apache/maven-plugins/pull/79
>>>>
>>>> Bug exists for 1 year. Everything described in PR and issue.
>>>>
>>>
>>>
>>>
>>> --
>>> -----
>>> Arnaud Héritier
>>> http://aheritier.net
>>> Mail/GTalk: aheritier AT gmail DOT com
>>> Twitter/Skype : aheritier
>>>
>>
>>
>>
>> --
>> -----
>> Arnaud Héritier
>> http://aheritier.net
>> Mail/GTalk: aheritier AT gmail DOT com
>> Twitter/Skype : aheritier
>>
>
>
>
> --
> -----
> Arnaud Héritier
> http://aheritier.net
> Mail/GTalk: aheritier AT gmail DOT com
> Twitter/Skype : aheritier
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: help review/accept [MSHADE-182]
Posted by Arnaud Héritier <ah...@gmail.com>.
No feedback guys ?
On Thu, Jan 21, 2016 at 11:02 PM, Arnaud Héritier <ah...@gmail.com>
wrote:
> Build (install -Prun-its) of the PR:
> Ok with Java 7 and Maven 3.3.9 on MacOS X
> Ko with Java 6 and Maven 3.2.5 on MacOS X
>
> [INFO] Building: MSHADE-185/pom.xml
> [INFO] ..FAILED (1.4 s)
>
> Could not find artifact com.sun:tools:jar:1.6 at specified path
> /Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home/../lib/tools.jar
>
> But the issue is the same for me on master branch thus there is no
> regression with the PR
>
>
> On Thu, Jan 21, 2016 at 9:30 PM, Arnaud Héritier <ah...@gmail.com>
> wrote:
>
>> Hi,
>>
>> I may try to help but I imagine that it's not only a merge to do.
>> I had a look at the current shade build (without your fix) and it is
>> failing on another test on MacOS
>> Am I the only one ?
>>
>> Best regards
>>
>> On Fri, Jan 15, 2016 at 12:37 PM, Kanstantsin Shautsou <
>> kanstantsin.sha@gmail.com> wrote:
>>
>>> Hi, could somebody help with processing
>>> https://issues.apache.org/jira/browse/MSHADE-182
>>> https://github.com/apache/maven-plugins/pull/79
>>>
>>> Bug exists for 1 year. Everything described in PR and issue.
>>>
>>
>>
>>
>> --
>> -----
>> Arnaud Héritier
>> http://aheritier.net
>> Mail/GTalk: aheritier AT gmail DOT com
>> Twitter/Skype : aheritier
>>
>
>
>
> --
> -----
> Arnaud Héritier
> http://aheritier.net
> Mail/GTalk: aheritier AT gmail DOT com
> Twitter/Skype : aheritier
>
--
-----
Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier
Re: help review/accept [MSHADE-182]
Posted by Arnaud Héritier <ah...@gmail.com>.
Build (install -Prun-its) of the PR:
Ok with Java 7 and Maven 3.3.9 on MacOS X
Ko with Java 6 and Maven 3.2.5 on MacOS X
[INFO] Building: MSHADE-185/pom.xml
[INFO] ..FAILED (1.4 s)
Could not find artifact com.sun:tools:jar:1.6 at specified path
/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home/../lib/tools.jar
But the issue is the same for me on master branch thus there is no
regression with the PR
On Thu, Jan 21, 2016 at 9:30 PM, Arnaud Héritier <ah...@gmail.com>
wrote:
> Hi,
>
> I may try to help but I imagine that it's not only a merge to do.
> I had a look at the current shade build (without your fix) and it is
> failing on another test on MacOS
> Am I the only one ?
>
> Best regards
>
> On Fri, Jan 15, 2016 at 12:37 PM, Kanstantsin Shautsou <
> kanstantsin.sha@gmail.com> wrote:
>
>> Hi, could somebody help with processing
>> https://issues.apache.org/jira/browse/MSHADE-182
>> https://github.com/apache/maven-plugins/pull/79
>>
>> Bug exists for 1 year. Everything described in PR and issue.
>>
>
>
>
> --
> -----
> Arnaud Héritier
> http://aheritier.net
> Mail/GTalk: aheritier AT gmail DOT com
> Twitter/Skype : aheritier
>
--
-----
Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier
Re: help review/accept [MSHADE-182]
Posted by Arnaud Héritier <ah...@gmail.com>.
Hi,
I may try to help but I imagine that it's not only a merge to do.
I had a look at the current shade build (without your fix) and it is
failing on another test on MacOS
Am I the only one ?
Best regards
On Fri, Jan 15, 2016 at 12:37 PM, Kanstantsin Shautsou <
kanstantsin.sha@gmail.com> wrote:
> Hi, could somebody help with processing
> https://issues.apache.org/jira/browse/MSHADE-182
> https://github.com/apache/maven-plugins/pull/79
>
> Bug exists for 1 year. Everything described in PR and issue.
>
--
-----
Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier