You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by er...@apache.org on 2013/01/16 08:00:59 UTC
svn commit: r1433837 - in
/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests:
src/org/apache/flex/compiler/internal/as/codegen/
src/org/apache/flex/compiler/internal/js/codegen/amd/
src/org/apache/flex/compiler/internal/js/codegen/goog/ test-files/
Author: erikdebruin
Date: Wed Jan 16 07:00:59 2013
New Revision: 1433837
URL: http://svn.apache.org/viewvc?rev=1433837&view=rev
Log:
- removed 'assertOutDebug' method from TestWalkerBase, figured out another approach
Added:
flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFile.java
- copied, changed from r1432404, flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFile.java
Modified:
flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestWalkerBase.java
flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/amd/TestAMDEmiter.java
flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/test-files/output.js
Modified: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestWalkerBase.java
URL: http://svn.apache.org/viewvc/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestWalkerBase.java?rev=1433837&r1=1433836&r2=1433837&view=diff
==============================================================================
--- flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestWalkerBase.java (original)
+++ flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestWalkerBase.java Wed Jan 16 07:00:59 2013
@@ -4,7 +4,6 @@ import static org.hamcrest.core.Is.is;
import static org.junit.Assert.assertThat;
import org.apache.flex.compiler.clients.IBackend;
-import org.apache.flex.compiler.internal.as.codegen.ASFilterWriter;
import org.apache.flex.compiler.internal.as.driver.ASBackend;
import org.apache.flex.compiler.visitor.IASBlockVisitor;
import org.junit.After;
@@ -47,15 +46,4 @@ public class TestWalkerBase extends Test
mCode = writer.toString();
assertThat(writer.toString(), is(code));
}
-
- // (erikdebruin) this helps me debug the tests in a way that fits my
- // 'normal' workflow better...
- protected void assertOutDebug(String code)
- {
- mCode = writer.toString();
-
- System.out.println(mCode);
-
- assertThat(writer.toString(), is(code));
- }
}
Modified: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/amd/TestAMDEmiter.java
URL: http://svn.apache.org/viewvc/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/amd/TestAMDEmiter.java?rev=1433837&r1=1433836&r2=1433837&view=diff
==============================================================================
--- flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/amd/TestAMDEmiter.java (original)
+++ flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/amd/TestAMDEmiter.java Wed Jan 16 07:00:59 2013
@@ -52,7 +52,7 @@ public class TestAMDEmiter extends TestW
+ "return \"Don't \" + _privateVar + value; }";
IFileNode node = getFileNode(code);
visitor.visitFile(node);
- assertOutDebug("package com.example.components {\n\tpublic class MyTextButton extends TextButton {\n\t\tcom.example.components.MyTextButton = function() {\n\t\t\tif (foo() != 42) {\n\t\t\t\tbar();\n\t\t\t}\n\t\t}\n\t\tprivate var _privateVar:String = \"do \";\n\t\tpublic var publicProperty:Number = 100;\n\t\tcom.example.components.MyTextButton.prototype.myFunction = function(value) {\n\t\t\treturn \"Don't \" + _privateVar + value;\n\t\t}\n\t}\n}");
+ assertOut("package com.example.components {\n\tpublic class MyTextButton extends TextButton {\n\t\tcom.example.components.MyTextButton = function() {\n\t\t\tif (foo() != 42) {\n\t\t\t\tbar();\n\t\t\t}\n\t\t}\n\t\tprivate var _privateVar:String = \"do \";\n\t\tpublic var publicProperty:Number = 100;\n\t\tcom.example.components.MyTextButton.prototype.myFunction = function(value) {\n\t\t\treturn \"Don't \" + _privateVar + value;\n\t\t}\n\t}\n}");
}
@Test
Copied: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFile.java (from r1432404, flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFile.java)
URL: http://svn.apache.org/viewvc/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFile.java?p2=flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFile.java&p1=flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFile.java&r1=1432404&r2=1433837&rev=1433837&view=diff
==============================================================================
--- flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFile.java (original)
+++ flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFile.java Wed Jan 16 07:00:59 2013
@@ -37,7 +37,7 @@ public class TestGoogFile extends TestWa
{
IFileNode node = getFileNode("input", true);
visitor.visitFile(node);
- assertOutDebug(getCodeFromFile("output", true));
+ assertOut(getCodeFromFile("output", true));
}
@Override
Modified: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/test-files/output.js
URL: http://svn.apache.org/viewvc/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/test-files/output.js?rev=1433837&r1=1433836&r2=1433837&view=diff
==============================================================================
--- flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/test-files/output.js (original)
+++ flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/test-files/output.js Wed Jan 16 07:00:59 2013
@@ -18,5 +18,4 @@ goog.inherits(org.apache.flex.A, spark.c
* @private
* @type {ArgumentError}
*/
-org.apache.flex.A.prototype._a = new ArgumentError();
-
+org.apache.flex.A.prototype._a = new ArgumentError();
\ No newline at end of file