[jira] [Work logged] (HIVE-21240) JSON SerDe Re-Write

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-21240?focusedWorklogId=230298&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230298 ]

ASF GitHub Bot logged work on HIVE-21240:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Apr/19 22:46
            Start Date: 19/Apr/19 22:46
    Worklog Time Spent: 10m 
      Work Description: b-slim commented on pull request #530: HIVE-21240: JSON SerDe Deserialize Re-Write
URL: https://github.com/apache/hive/pull/530#discussion_r277107357
 
 

 ##########
 File path: ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFJsonRead.java
 ##########
 @@ -156,10 +158,8 @@ public void testUndeclaredStructField() throws Exception {
       ObjectInspector[] arguments = buildArguments("struct<a:int>");
       udf.initialize(arguments);
 
-      Object res = udf.evaluate(evalArgs("{\"b\":null}"));
-      assertTrue(res instanceof Object[]);
-      Object o[] = (Object[]) res;
-      assertEquals(null, o[0]);
+      // Invalid - should throw Exception
+      udf.evaluate(evalArgs("{\"b\":null}"));
 
 Review comment:
   am Not sure why this has changed ? seems like this is different from old behavior can you please explain more?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 230298)
    Time Spent: 20m  (was: 10m)

> JSON SerDe Re-Write
> -------------------
>
>                 Key: HIVE-21240
>                 URL: https://issues.apache.org/jira/browse/HIVE-21240
>             Project: Hive
>          Issue Type: Improvement
>          Components: Serializers/Deserializers
>    Affects Versions: 4.0.0, 3.1.1
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21240.1.patch, HIVE-21240.1.patch, HIVE-21240.10.patch, HIVE-21240.11.patch, HIVE-21240.11.patch, HIVE-21240.11.patch, HIVE-21240.11.patch, HIVE-21240.2.patch, HIVE-21240.3.patch, HIVE-21240.4.patch, HIVE-21240.5.patch, HIVE-21240.6.patch, HIVE-21240.7.patch, HIVE-21240.9.patch, HIVE-24240.8.patch, kafka_storage_handler.diff
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The JSON SerDe has a few issues, I will link them to this JIRA.
> * Use Jackson Tree parser instead of manually parsing
> * Added support for base-64 encoded data (the expected format when using JSON)
> * Added support to skip blank lines (returns all columns as null values)
> * Current JSON parser accepts, but does not apply, custom timestamp formats in most cases
> * Added some unit tests
> * Added cache for column-name to column-index searches, currently O\(n\) for each row processed, for each column in the row



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)