You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2022/08/02 15:46:46 UTC

[isis] 02/05: ISIS-3108: fixing unit tests

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git

commit 77330c42bada206c1f62e0ca83f2941883fe7508
Author: Dan Haywood <da...@haywood-associates.co.uk>
AuthorDate: Tue Aug 2 16:19:20 2022 +0100

    ISIS-3108: fixing unit tests
---
 .../DomainObjectAnnotationFacetFactoryTest.java             | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/core/metamodel/src/test/java/org/apache/isis/core/metamodel/facets/object/domainobject/DomainObjectAnnotationFacetFactoryTest.java b/core/metamodel/src/test/java/org/apache/isis/core/metamodel/facets/object/domainobject/DomainObjectAnnotationFacetFactoryTest.java
index f6c649657a..aa2fd69242 100644
--- a/core/metamodel/src/test/java/org/apache/isis/core/metamodel/facets/object/domainobject/DomainObjectAnnotationFacetFactoryTest.java
+++ b/core/metamodel/src/test/java/org/apache/isis/core/metamodel/facets/object/domainobject/DomainObjectAnnotationFacetFactoryTest.java
@@ -22,6 +22,7 @@ import java.util.UUID;
 
 import javax.inject.Named;
 
+import org.assertj.core.api.Assertions;
 import org.jmock.Expectations;
 import org.junit.After;
 import org.junit.Assert;
@@ -148,9 +149,10 @@ extends AbstractFacetFactoryJUnit4TestCase {
                         .forTesting(DomainObjectAnnotationFacetFactoryTest.Customer.class, mockMethodRemover, facetHolder);
                 facetFactory.processEntityChangePublishing(context.synthesizeOnType(DomainObject.class), context);
 
-                final Facet facet = facetHolder.getFacet(EntityChangePublishingFacet.class);
+                final EntityChangePublishingFacet facet = facetHolder.getFacet(EntityChangePublishingFacet.class);
                 assertThat(facet, is(notNullValue()));
                 Assert.assertTrue(facet instanceof EntityChangePublishingFacetFromConfiguration);
+                Assertions.assertThat(facet.isEnabled()).isTrue();
 
                 expectNoMethodsRemoved();
             }
@@ -163,7 +165,8 @@ extends AbstractFacetFactoryJUnit4TestCase {
                         .forTesting(DomainObjectAnnotationFacetFactoryTest.Customer.class, mockMethodRemover, facetHolder));
 
                 final EntityChangePublishingFacet facet = facetHolder.getFacet(EntityChangePublishingFacet.class);
-                Assert.assertNull(facet);
+                Assert.assertNotNull(facet);
+                Assertions.assertThat(facet.isEnabled()).isFalse();
 
                 expectNoMethodsRemoved();
             }
@@ -179,9 +182,10 @@ extends AbstractFacetFactoryJUnit4TestCase {
                 facetFactory.process(ProcessClassContext
                         .forTesting(CustomerWithDomainObjectAndAuditingSetToAsConfigured.class, mockMethodRemover, facetHolder));
 
-                final Facet facet = facetHolder.getFacet(EntityChangePublishingFacet.class);
+                final EntityChangePublishingFacet facet = facetHolder.getFacet(EntityChangePublishingFacet.class);
                 Assert.assertNotNull(facet);
                 Assert.assertTrue(facet instanceof EntityChangePublishingFacetForDomainObjectAnnotationAsConfigured);
+                Assertions.assertThat(facet.isEnabled()).isTrue();
 
                 expectNoMethodsRemoved();
             }
@@ -194,7 +198,8 @@ extends AbstractFacetFactoryJUnit4TestCase {
                         .forTesting(CustomerWithDomainObjectAndAuditingSetToAsConfigured.class, mockMethodRemover, facetHolder));
 
                 final EntityChangePublishingFacet facet = facetHolder.getFacet(EntityChangePublishingFacet.class);
-                Assert.assertNull(facet);
+                Assert.assertNotNull(facet);
+                Assertions.assertThat(facet.isEnabled()).isFalse();
 
                 expectNoMethodsRemoved();
             }