[jira] Commented: (OFBIZ-3071) assigning security group to a party without validations

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777060#action_12777060 ] 

Jacques Le Roux commented on OFBIZ-3071:
----------------------------------------

Hi Abdullah,

{quote}
1) If thruDate is not specified, the record goes forever, and we shouldn't allow one more record.
{quote}

This would prevent to do what David said, you could not create a temporary permission for a limited span of time

{quote}
2) If thruDate specified, then I guess the overlapping should be limited to a limited time, what I mean is, the next overlapping records fromDate should be validate to be a month or so, before the thruDate of the previous record.
{quote}

Why a month ? I can see any reasons to chose a month or anything else. Even int the case of 2 "same" tuples with the thruDate not specified, we would simply takeinto account the "highest" (the one with the most recent fromDate)

In your example, 
    2007-10-10 10:55:10.000 & 2009-10-02 10:55:26.000 
    2007-11-10 10:55:10.000 & 2009-10-02 10:55:26.000 
with David's scenario the 1st tuple (2007-10-10) would be simply ignored as it would be replaced by the 2d. I can't see any problems with that.

I can't see any reasons to have a single properties to set span of time. Sorry but, except if you have strong argument, I think I will close this issue soon as invalid.

Thanks

> assigning security group to a party without validations
> -------------------------------------------------------
>
>                 Key: OFBIZ-3071
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3071
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Abdullah Shaikh
>            Priority: Minor
>         Attachments: OFBIZ-3071_assigning security group to a party without validations.patch
>
>
> When adding user login to Security Group, the fromDate & thruDate input fields are not mandatory, if not specified the fromDate is set to current timestamop and thruDate is entered in database as null, which means the user login is assigned that Security Group forever, but when if the same Security Group is added, it again adds it, but instead it should check that if the thruDate is null in the already entered record then shouldn't add new record.
> If incase the thruDate is specified during the creation of 1st record then while adding the 2nd record for the same Security Group, it should check if the thruDate of previous record is before the fromDate of the new record, this check also doesn't happen.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.