You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "aloyszhang (via GitHub)" <gi...@apache.org> on 2023/08/17 14:49:34 UTC
[GitHub] [pulsar] aloyszhang opened a new pull request, #21017: [fix][broker] fix the non-active bundle clean logic when updating bundles
aloyszhang opened a new pull request, #21017:
URL: https://github.com/apache/pulsar/pull/21017
### Motivation
Pulsar saves all bundles load informations in `loadData` which contains bundleData,
the broker will update the bundleData by traversing all LocalBrokerData reported by every broker and remove non-active bundles (found in loadData but not in the newest reported LocalBrokerData)
the current removing of non-active happens in the wrong place, see
https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java#L540-L571
it removes non-active bundle for every broker
### Modifications
fix the non-active bundle clean logic when updating bundles.
remove non-active bundle after traverse brokers bundle data
### Documentation
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #21017: [fix][broker] fix the non-active bundle clean logic when updating bundles
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21017:
URL: https://github.com/apache/pulsar/pull/21017#issuecomment-1682423392
@aloyszhang Please add the following content to your PR description and select a checkbox:
```
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #21017: [fix][broker] fix the non-active bundle clean logic when updating bundles
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on PR #21017:
URL: https://github.com/apache/pulsar/pull/21017#issuecomment-1683488551
close since duplicate with #20620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #21017: [fix][broker] fix the non-active bundle clean logic when updating bundles
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on PR #21017:
URL: https://github.com/apache/pulsar/pull/21017#issuecomment-1683488238
@lifepuzzlefun sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lifepuzzlefun commented on pull request #21017: [fix][broker] fix the non-active bundle clean logic when updating bundles
Posted by "lifepuzzlefun (via GitHub)" <gi...@apache.org>.
lifepuzzlefun commented on PR #21017:
URL: https://github.com/apache/pulsar/pull/21017#issuecomment-1683442681
@aloyszhang hi this pr duplicated with https://github.com/apache/pulsar/pull/20620 can you help review ? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang closed pull request #21017: [fix][broker] fix the non-active bundle clean logic when updating bundles
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang closed pull request #21017: [fix][broker] fix the non-active bundle clean logic when updating bundles
URL: https://github.com/apache/pulsar/pull/21017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org