[jira] Resolved: (WICKET-3265) Component data_remove returns Object which is never used

["Jeremy Thomerson (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson resolved WICKET-3265.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M4
                   1.4.15

good observation.  thanks

> Component data_remove returns Object which is never used
> --------------------------------------------------------
>
>                 Key: WICKET-3265
>                 URL: https://issues.apache.org/jira/browse/WICKET-3265
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-M3
>         Environment: All
>            Reporter: Richard Emberson
>            Assignee: Jeremy Thomerson
>            Priority: Trivial
>             Fix For: 1.4.15, 1.5-M4
>
>
> The Component method data_remove has the signature:
> private Object data_remove(int position)
> It returns an Object and it is private.
> Only three places call data_remove in Component and none of them use
> the return value.
> Simplify the code in data_remove so that it does not return the data
> being removed.
> At some future time, one can always call data_get if one really needs the 
> value prior to removing it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.