You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/21 07:35:00 UTC
[GitHub] [incubator-doris] WingsGo opened a new pull request #3363: [Bug]Use `close` to replace `finalize` method to avoid OOM
WingsGo opened a new pull request #3363:
URL: https://github.com/apache/incubator-doris/pull/3363
This CL mainly solve the problem that when recycle `OlapTableSink`
object, GC thread will not do it immediately because the class override
the `finalize` method, and it will cause OOM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on issue #3363: [Bug]Use OlapTableSink::close to replace OlapTableSink::finalize method to avoid OOM
Posted by GitBox <gi...@apache.org>.
WingsGo commented on issue #3363:
URL: https://github.com/apache/incubator-doris/pull/3363#issuecomment-617241757
> > @kangkaisen what about `terminate` or `finish`?
>
> How about `complete()`? Which means the end of "handle" this object.
>
> But I am curious why I didn't encounter this kind of OOM in our environment?
>
> And I found that `InsertStmt` also has a `finalize()` method, can you modify it too?
Done, it may because in our environment, there are more than 50W stream load txns in one day
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #3363: [Bug]Use OlapTableSink::close to replace OlapTableSink::finalize method to avoid OOM
Posted by GitBox <gi...@apache.org>.
morningman commented on issue #3363:
URL: https://github.com/apache/incubator-doris/pull/3363#issuecomment-617222803
> @kangkaisen what about `terminate` or `finish`?
How about `complete()`? Which means the end of "handle" this object.
But I am curious why I didn't encounter this kind of OOM in our environment?
And I found that `InsertStmt` also has a `finalize()` method, can you modify it too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on issue #3363: [Bug]Use `close` to replace `finalize` method to avoid OOM
Posted by GitBox <gi...@apache.org>.
WingsGo commented on issue #3363:
URL: https://github.com/apache/incubator-doris/pull/3363#issuecomment-617008047
For #3362
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on issue #3363: [Bug]Use OlapTableSink::close to replace OlapTableSink::finalize method to avoid OOM
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on issue #3363:
URL: https://github.com/apache/incubator-doris/pull/3363#issuecomment-617082201
@WingsGo Hi, would better choose a name could describe the `finalize` method work. current work is not `close`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on issue #3363: [Bug]Use OlapTableSink::close to replace OlapTableSink::finalize method to avoid OOM
Posted by GitBox <gi...@apache.org>.
WingsGo commented on issue #3363:
URL: https://github.com/apache/incubator-doris/pull/3363#issuecomment-617111141
@kangkaisen what about `terminate` or `finish`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3363: [Bug]Use OlapTableSink::close to replace OlapTableSink::finalize method to avoid OOM
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #3363:
URL: https://github.com/apache/incubator-doris/pull/3363#discussion_r412600132
##########
File path: fe/src/main/java/org/apache/doris/planner/OlapTableSink.java
##########
@@ -118,7 +118,7 @@ public void updateLoadId(TUniqueId newLoadId) {
}
// must called after tupleDescriptor is computed
- public void finalize() throws UserException {
+ public void completeq() throws UserException {
Review comment:
```suggestion
public void complete() throws UserException {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org