You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Seetaramayya (via GitHub)" <gi...@apache.org> on 2023/02/09 21:09:22 UTC
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya opened a new pull request, #30: Using pekko config in reference.conf instead of akka
Seetaramayya opened a new pull request, #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30
- Issue https://github.com/apache/incubator-pekko-connectors-kafka/issues/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102053038
##########
tests/src/test/scala/org/apache/pekko/kafka/tests/scaladsl/LogCapturing.scala:
##########
@@ -15,16 +15,16 @@ import org.scalatest.TestSuite
import org.slf4j.LoggerFactory
/**
- * See https://doc.akka.io/docs/akka/current/typed/testing-async.html#silence-logging-output-from-tests
+ * See https://pekko.apache.org/docs/pekko/current/typed/testing-async.html#silence-logging-output-from-tests
*
* Mixin this trait to a ScalaTest test to make log lines appear only when the test failed.
*
* Requires Logback and configuration like the following the logback-test.xml:
*
* {{{
- * <appender name="CapturingAppender" class="akka.actor.testkit.typed.internal.CapturingAppender" />
+ * <appender name="CapturingAppender" class="pekko.actor.testkit.typed.internal.CapturingAppender" />
*
- * <logger name="akka.actor.testkit.typed.internal.CapturingAppenderDelegate" >
+ * <logger name="pekko.actor.testkit.typed.internal.CapturingAppenderDelegate" >
Review Comment:
these are fully qualified class names - class packages start with 'org.apache.pekko'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102049571
##########
benchmarks/src/main/resources/reference.conf:
##########
@@ -1,5 +1,5 @@
-akka {
- loggers = ["akka.event.slf4j.Slf4jLogger"]
+pekko {
+ loggers = ["pekko.event.slf4j.Slf4jLogger"]
Review Comment:
isn't akka.event.slf4j.Slf4jLogger a class? - so the replacement in pekko would be org.apache.pekko.event.slf4j.Slf4jLogger - likewise 2 lines below this in this file - that is also a fully qualified class name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102094723
##########
testkit/src/main/java/org/apache/pekko/kafka/testkit/javadsl/BaseKafkaTest.java:
##########
@@ -47,7 +47,7 @@ public abstract class BaseKafkaTest extends KafkaTestKitClass {
protected final Materializer materializer;
/**
- * @deprecated Materializer no longer necessary in Akka 2.6, use
+ * @deprecated Materializer no longer necessary in Apache Pekko 2.6, use
Review Comment:
Interesting, I think we can drop this deprecated stuff completely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102054241
##########
tests/src/test/scala/org/apache/pekko/kafka/scaladsl/IntegrationSpec.scala:
##########
@@ -235,7 +235,7 @@ class IntegrationSpec extends SpecBase with TestcontainersKafkaLike with Inside
Await.result(produce(topic, 1 to 100), remainingOrDefault)
// Create ConsumerActor manually
- // https://doc.akka.io/docs/akka-stream-kafka/0.20/consumer.html#sharing-kafkaconsumer
Review Comment:
sure - seems ok to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102051092
##########
cluster-sharding/src/main/scala/org/apache/pekko/kafka/cluster/sharding/KafkaClusterSharding.scala:
##########
@@ -33,7 +33,7 @@ import scala.compat.java8.FutureConverters._
/**
* API MAY CHANGE
*
- * Akka Extension to enable Akka Cluster External Sharding with Alpakka Kafka.
+ * Pekko Extension to enable Pekko Cluster External Sharding with Pekko Connector Kafka.
Review Comment:
Apache Pekko is preferred to Pekko - 3 Apaches should be added to this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102051511
##########
cluster-sharding/src/main/scala/org/apache/pekko/kafka/cluster/sharding/KafkaClusterSharding.scala:
##########
@@ -33,7 +33,7 @@ import scala.compat.java8.FutureConverters._
/**
* API MAY CHANGE
*
- * Akka Extension to enable Akka Cluster External Sharding with Alpakka Kafka.
+ * Pekko Extension to enable Pekko Cluster External Sharding with Pekko Connector Kafka.
Review Comment:
this dropping of Apache is endemic - could you fix it in whole PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102051304
##########
benchmarks/src/main/resources/reference.conf:
##########
@@ -1,5 +1,5 @@
-akka {
- loggers = ["akka.event.slf4j.Slf4jLogger"]
+pekko {
+ loggers = ["pekko.event.slf4j.Slf4jLogger"]
Review Comment:
Indeed... thanks, I'll change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102053325
##########
tests/src/test/scala/org/apache/pekko/kafka/tests/javadsl/LogCapturingJunit4.scala:
##########
@@ -26,9 +26,9 @@ import org.slf4j.LoggerFactory
* Requires Logback and configuration like the following the logback-test.xml:
*
* {{{
- * <appender name="CapturingAppender" class="akka.actor.testkit.typed.internal.CapturingAppender" />
+ * <appender name="CapturingAppender" class="pekko.actor.testkit.typed.internal.CapturingAppender" />
*
- * <logger name="akka.actor.testkit.typed.internal.CapturingAppenderDelegate" >
+ * <logger name="pekko.actor.testkit.typed.internal.CapturingAppenderDelegate" >
Review Comment:
these are fully qualified class names - class packages start with 'org.apache.pekko'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102074264
##########
project/VersionGenerator.scala:
##########
@@ -2,19 +2,19 @@ import sbt._
import sbt.Keys._
/**
- * Generate version.conf and akka/kafka/Version.scala files based on the version setting.
+ * Generate version.conf and pekko/kafka/Version.scala files based on the version setting.
Review Comment:
org/apache/pekko/kafka/Version.scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102050516
##########
benchmarks/src/main/scala/org/apache/pekko/kafka/benchmarks/InflightMetrics.scala:
##########
@@ -151,7 +151,7 @@ private[benchmarks] trait InflightMetrics {
}
/**
- * Return specified consumer-level metrics using Alpakka Kafka's [[Control]] metrics API.
+ * Return specified consumer-level metrics using pekko connectors Kafka's [[Control]] metrics API.
Review Comment:
Use 'Pekko Connectors' - general English rule about proper nouns appearing with capital letters at start of words
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102077673
##########
core/src/main/scala/org/apache/pekko/kafka/ConnectionCheckerSettings.scala:
##########
@@ -42,7 +42,7 @@ class ConnectionCheckerSettings private[kafka] (val enable: Boolean,
copy(checkInterval = checkInterval.asScala)
override def toString: String =
- s"akka.kafka.ConnectionCheckerSettings(" +
+ s"pekko.kafka.ConnectionCheckerSettings(" +
Review Comment:
I'm neutral about this - it's just toString - no real harm leaving the org.apache bit out - but you can add it you prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#issuecomment-1424946585
part of #29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102075907
##########
project/VersionGenerator.scala:
##########
@@ -2,19 +2,19 @@ import sbt._
import sbt.Keys._
/**
- * Generate version.conf and akka/kafka/Version.scala files based on the version setting.
+ * Generate version.conf and pekko/kafka/Version.scala files based on the version setting.
*
- * This was adapted from https://github.com/akka/akka/blob/v2.6.8/project/VersionGenerator.scala
+ * This was adapted from https://github.com/apache/incubator-pekko/blob/main/project/VersionGenerator.scala
*/
object VersionGenerator {
val settings: Seq[Setting[_]] = inConfig(Compile)(
Seq(
- resourceGenerators += generateVersion(resourceManaged, _ / "version.conf", """|akka.kafka.version = "%s"
+ resourceGenerators += generateVersion(resourceManaged, _ / "version.conf", """|pekko.kafka.version = "%s"
|"""),
sourceGenerators += generateVersion(
sourceManaged,
- _ / "akka" / "kafka" / "Version.scala",
+ _ / "pekko" / "kafka" / "Version.scala",
Review Comment:
"org" / "apache" / "pekko"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102073636
##########
project/MetaInfLicenseNoticeCopy.scala:
##########
@@ -4,7 +4,7 @@
*
* https://www.apache.org/licenses/LICENSE-2.0
*
- * This file is part of the Apache Pekko project, which was derived from Akka.
+ * This file is part of the Apache Pekko project, which was derived from Apache Pekko.
Review Comment:
Could you revert this to Akka?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102076332
##########
project/Versions.scala:
##########
@@ -16,7 +16,7 @@ object Versions {
// Keep .scala-steward.conf pin in sync
val kafkaVersion = "3.0.1"
val KafkaVersionForDocs = "30"
- // This should align with the ScalaTest version used in the Akka 2.6.x testkit
+ // This should align with the ScalaTest version used in the Apache Pekko 2.6.x testkit
Review Comment:
Pekko 1.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102074264
##########
project/VersionGenerator.scala:
##########
@@ -2,19 +2,19 @@ import sbt._
import sbt.Keys._
/**
- * Generate version.conf and akka/kafka/Version.scala files based on the version setting.
+ * Generate version.conf and pekko/kafka/Version.scala files based on the version setting.
Review Comment:
org.apache.pekko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102053885
##########
tests/src/test/scala/org/apache/pekko/kafka/tests/CapturingAppender.scala:
##########
@@ -48,9 +48,9 @@ import ch.qos.logback.core.AppenderBase
* Use configuration like the following the logback-test.xml:
*
* {{{
- * <appender name="CapturingAppender" class="akka.actor.testkit.typed.internal.CapturingAppender" />
+ * <appender name="CapturingAppender" class="pekko.actor.testkit.typed.internal.CapturingAppender" />
*
- * <logger name="akka.actor.testkit.typed.internal.CapturingAppenderDelegate" >
Review Comment:
these are fully qualified class names - class packages start with 'org.apache.pekko' -- could you check this whole test package - same issue pops up a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #30: Using pekko config in reference.conf instead of akka
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102046096
##########
tests/src/test/scala/org/apache/pekko/kafka/scaladsl/IntegrationSpec.scala:
##########
@@ -235,7 +235,7 @@ class IntegrationSpec extends SpecBase with TestcontainersKafkaLike with Inside
Await.result(produce(topic, 1 to 100), remainingOrDefault)
// Create ConsumerActor manually
- // https://doc.akka.io/docs/akka-stream-kafka/0.20/consumer.html#sharing-kafkaconsumer
Review Comment:
IMHO: This documentation link should also point to current so I changed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102076192
##########
core/src/main/scala/org/apache/pekko/kafka/ConnectionCheckerSettings.scala:
##########
@@ -42,7 +42,7 @@ class ConnectionCheckerSettings private[kafka] (val enable: Boolean,
copy(checkInterval = checkInterval.asScala)
override def toString: String =
- s"akka.kafka.ConnectionCheckerSettings(" +
+ s"pekko.kafka.ConnectionCheckerSettings(" +
Review Comment:
Change this too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102096660
##########
testkit/src/main/java/org/apache/pekko/kafka/testkit/javadsl/BaseKafkaTest.java:
##########
@@ -47,7 +47,7 @@ public abstract class BaseKafkaTest extends KafkaTestKitClass {
protected final Materializer materializer;
/**
- * @deprecated Materializer no longer necessary in Akka 2.6, use
+ * @deprecated Materializer no longer necessary in Apache Pekko 2.6, use
Review Comment:
no - keep it - we are keeping 100% of the APIs from Akka
deprecated code can be dropped in Pekko 1.1.0
change this is to `no longer necessary since Akka 2.6` - yes keep the Akka, because 2.6 has no meaning in Pekko yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30#discussion_r1102095629
##########
testkit/src/main/java/org/apache/pekko/kafka/testkit/javadsl/BaseKafkaTest.java:
##########
@@ -47,7 +47,7 @@ public abstract class BaseKafkaTest extends KafkaTestKitClass {
protected final Materializer materializer;
/**
- * @deprecated Materializer no longer necessary in Akka 2.6, use
+ * @deprecated Materializer no longer necessary in Apache Pekko 2.6, use
Review Comment:
I'll replace `2.6` with `1.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning merged pull request #30: Using `pekko` instead of `akka` in reference.conf and related configurations
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #30:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org