You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by GitBox <gi...@apache.org> on 2026/07/15 00:17:46 UTC
[GH] (texera/fix/dataset-rename-validation): Workflow run "Required Checks" failed!
The GitHub Actions job "Required Checks" on texera.git/fix/dataset-rename-validation has failed.
Run started by GitHub user kunwp1 (triggered by kunwp1).
Head commit for run:
e5faa8318525e6f56e9e90d1d5988ddb873a71e6 / Kunwoo Park <ku...@uci.edu>
refactor: extract shared helpers and reduce duplication
Backend:
- validateDatasetName now throws BadRequestException directly,
eliminating the try/catch wrappers at both call sites
- Extract failOnDuplicateDatasetName[T] helper that catches SQLState
23505 and maps to BadRequestException, replacing two identical
6-line catch blocks
- Use jOOQ's built-in e.sqlState() instead of the manual
Option(e.getCause).collect dance
- Hoist regex to a class-level val (compiled once, not per call)
- Merge redundant null/empty check into the regex check (regex +
quantifier already rejects empty strings)
Frontend:
- Export validateDatasetName() from dataset.service.ts as the single
source of truth for the name rule (regex + max length + error message)
- All three components now call the shared validator instead of
inlining the regex, magic number 128, and error string
Report URL: https://github.com/apache/texera/actions/runs/29378122362
With regards,
GitHub Actions via GitBox