You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/27 01:58:20 UTC
[GitHub] [spark] ulysses-you edited a comment on issue #27008:
[SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison
optimization
ulysses-you edited a comment on issue #27008: [SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison optimization
URL: https://github.com/apache/spark/pull/27008#issuecomment-569165048
We can make this simply.
We just need to check if `IsNotNull` exists. If exists then optimize else not. Constraints is used by `InferFiltersFromConstraints`, we don't need to rely on it strongly.
I changed the pr title.
cc @maropu @viirya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org