[GitHub] [beam] suztomo commented on a change in pull request #14028: [BEAM-11227] Preparing vendored gRPC upgrade from 1.26 to 1.35

[GitBox <gi...@apache.org>]

suztomo commented on a change in pull request #14028:
URL: https://github.com/apache/beam/pull/14028#discussion_r586732225



##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_36_0.groovy
##########
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.beam.gradle
+
+/**
+ * Utilities for working with our vendored version of gRPC.
+ */
+class GrpcVendoring_1_36_0 {
+
+  static def guava_version = "30.1-jre"
+  // protobuf version from https://search.maven.org/artifact/io.grpc/grpc-protobuf/1.36.0/jar
+  static def protobuf_version = "3.12.0"

Review comment:
       According to the Linkage Checker ([output](https://gist.github.com/suztomo/c1d9c587ea58ad4cfd25c853ad921c93#file-beam-vendor-grpc-1_36_0-txt-L139)), this version  3.12.0 suffers from https://github.com/protocolbuffers/protobuf/issues/7827.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org